~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3

[PATCH] community/sfml: build static libraries

Details
Message ID
<20220302204051.1093-1-sir@cmpwn.com>
DKIM signature
missing
Download raw message
Patch: +14 -5
---
 community/sfml/APKBUILD | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/community/sfml/APKBUILD b/community/sfml/APKBUILD
index 5ab219f88e..81f4c362a7 100644
--- a/community/sfml/APKBUILD
+++ b/community/sfml/APKBUILD
@@ -1,7 +1,7 @@
# Maintainer: Daniel Sabogal <dsabogalcc@gmail.com>
pkgname=sfml
pkgver=2.5.1
pkgrel=2
pkgrel=3
pkgdesc="Simple and Fast Multimedia Library"
url="https://www.sfml-dev.org/"
arch="all"
@@ -15,16 +15,25 @@ source="https://github.com/SFML/SFML/archive/$pkgver/sfml-$pkgver.tar.gz"
builddir="$srcdir/SFML-$pkgver"

build() {
	cmake -B build \
	cmake -B build-shared \
		-DCMAKE_BUILD_TYPE=None \
		-DCMAKE_INSTALL_PREFIX=/usr \
		-DSFML_BUILD_DOC=TRUE \
		-DSFML_INSTALL_PKGCONFIG_FILES=TRUE
	cmake --build build
		-DSFML_INSTALL_PKGCONFIG_FILES=TRUE \
		-DBUILD_SHARED_LIBS=TRUE
	cmake --build build-shared

	cmake -B build-static \
		-DCMAKE_BUILD_TYPE=None \
		-DCMAKE_INSTALL_PREFIX=/usr \
		-DSFML_BUILD_DOC=TRUE \
		-DSFML_INSTALL_PKGCONFIG_FILES=TRUE \
		-DBUILD_SHARED_LIBS=FALSE
}

package() {
	DESTDIR="$pkgdir" cmake --build build --target install
	DESTDIR="$pkgdir" cmake --build build-shared --target install
	DESTDIR="$pkgdir" cmake --build build-static --target install

	mkdir -p "$pkgdir"/usr/share/doc
	mv "$pkgdir"/usr/share/SFML/doc "$pkgdir"/usr/share/doc/SFML
-- 
2.35.1
Details
Message ID
<164625443799.985.5861364705243667647.gitlab.31589.37c674cdb0d2094974d9306badfea0e955aae399@listserv.local>
In-Reply-To
<20220302204051.1093-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
On Wed, 02 Mar 2022 21:40:51 +0100, Drew DeVault wrote:
> +		-DSFML_BUILD_DOC=TRUE \
> +		-DSFML_INSTALL_PKGCONFIG_FILES=TRUE \
> +		-DBUILD_SHARED_LIBS=FALSE

you missed a cmake --build for this too (it builds when called with install below instead, in the slower fakeroot() )

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31589#note_219861
Details
Message ID
<164625444845.985.10087821045270410712.gitlab.31589.a8269e2ad7f9e222ce33faee5c52c2be0776806d@listserv.local>
In-Reply-To
<20220302204051.1093-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
you should add a -static before the -dev here too

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31589#note_219862
Details
Message ID
<164625455504.985.13985758719814916569.gitlab.31589.37c674cdb0d2094974d9306badfea0e955aae399@listserv.local>
In-Reply-To
<164625443799.985.5861364705243667647.gitlab.31589.37c674cdb0d2094974d9306badfea0e955aae399@listserv.local> (view parent)
DKIM signature
missing
Download raw message
On Wed, 02 Mar 2022 21:40:51 +0100, Drew DeVault wrote:
> +		-DSFML_BUILD_DOC=TRUE \
> +		-DSFML_INSTALL_PKGCONFIG_FILES=TRUE \
> +		-DBUILD_SHARED_LIBS=FALSE

you could also set both of these to MinSizeRel and add a -G Ninja and samurai to makedeps while you're here editing them :)

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/31589#note_219863
Reply to thread Export thread (mbox)