~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
6 5

[PATCH] testing/b3sum: enable for armhf

Eric Roshan-Eisner <eric.d.eisner@gmail.com>
Details
Message ID
<20220603205419.15813-1-eric.d.eisner@gmail.com>
DKIM signature
missing
Download raw message
Patch: +3 -4
Previously the APKBUILD enabled neon instructions which are not supported for armv6.
Upstream has since added broken auto-detection of arm version, which unintentionally ignores the neon flag for armv6.
https://github.com/BLAKE3-team/BLAKE3/commit/0a0bb7126e9207d3bb3d9af0f0b5ae646d532cf2

Don't set the flag for armhf in case they "fix" this bug.
---
 testing/b3sum/APKBUILD | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/testing/b3sum/APKBUILD b/testing/b3sum/APKBUILD
index 4b365727a2..93f6e7e846 100644
--- a/testing/b3sum/APKBUILD
+++ b/testing/b3sum/APKBUILD
@@ -2,17 +2,16 @@
# Maintainer:
pkgname=b3sum
pkgver=1.3.1
pkgrel=0
pkgrel=1
pkgdesc="Command line implementation of the BLAKE3 hash function"
url="https://blake3.io"
# armhf: 'vaddq_u32': target specific option mismatch
arch="all !s390x !armhf !riscv64"
arch="all !s390x !riscv64"
license="CC0-1.0 OR Apache-2.0"
makedepends="cargo"
source="b3sum-$pkgver.tar.gz::https://crates.io/api/v1/crates/b3sum/$pkgver/download"

case "$CARCH" in
	arm*) _features="neon" ;;
	armv7) _features="neon" ;;
esac

build() {
-- 
2.36.1
Details
Message ID
<165429620491.985.9410681712950127606.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local>
In-Reply-To
<20220603205419.15813-1-eric.d.eisner@gmail.com> (view parent)
DKIM signature
missing
Download raw message
the tests seem to hang forever for some reason

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_239991
Eric Roshan-Eisner <eric.d.eisner@gmail.com>
Details
Message ID
<CAHEXR0gWPvD7hkJZ9OS8d+yb3xizBmF2U=LgVft+nczr-qv7SQ@mail.gmail.com>
In-Reply-To
<165429620491.985.9410681712950127606.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local> (view parent)
DKIM signature
missing
Download raw message
What hardware are you using? The tests pass (but take a long time to
compile) on my RPI Zero.


On Fri, Jun 3, 2022 at 3:43 PM alice <no-reply@dispatch.alpinelinux.org> wrote:
>
> the tests seem to hang forever for some reason
>
> --
> via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_239991
Details
Message ID
<165430087755.985.7463230265645918416.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local>
In-Reply-To
<165429620491.985.9410681712950127606.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Eric Roshan-Eisner <eric.d.eisner@gmail.com> replied via email:

```
What hardware are you using? The tests pass (but take a long time to
compile) on my RPI Zero.


On Fri, Jun 3, 2022 at 3:43 PM alice <no-reply@dispatch.alpinelinux.org> wrote:
>
> the tests seem to hang forever for some reason
>
> --
> via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_239991

```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_239994
Details
Message ID
<165432963592.985.4073987437087319467.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local>
In-Reply-To
<165430087755.985.7463230265645918416.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local> (view parent)
DKIM signature
missing
Download raw message
it's armhf running on aarch64 with qemu if I remember correctly

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_240016
Details
Message ID
<165434537416.985.13013667745919879983.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local>
In-Reply-To
<165432963592.985.4073987437087319467.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local> (view parent)
DKIM signature
missing
Download raw message
no, it's armhf via running 32-bit code on native hardware, no qemu. uname would still say aarch64 afaik

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_240035
Details
Message ID
<165434593529.985.11847558892409821270.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local>
In-Reply-To
<165434537416.985.13013667745919879983.gitlab.35059.91f0e768addc976cebb17d49efccdca958eb67b9@listserv.local> (view parent)
DKIM signature
missing
Download raw message
CI is an 64-bits aarch64 vm running an armhf container with `linux32`. The builders are a similar setup, but then using lxc instead of docker.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/35059#note_240040
Reply to thread Export thread (mbox)