To: ~alpine/aports <alpine-aports@lists.alpinelinux.org>
Cc: leso-kn <info@lesosoftware.com>
From: leso-kn <info@lesosoftware.com>
Subject: Re: [PATCH] main/bacula: fix bacula-dir crash (pthread double detach)
Message-ID: <2ba904e7-3ca8-5d57-560c-310b32f711a4@lesosoftware.com>
Date: Fri, 1 Apr 2022 03:29:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="3hOHDcEyEhzKwoJCdq9FdTuRZR4SE9mSa"

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--3hOHDcEyEhzKwoJCdq9FdTuRZR4SE9mSa
Content-Type: multipart/mixed; boundary="FN8pUjiAfeHkq3X8IAPq5OgNC3I4mu2JH";
 protected-headers="v1"
From: leso-kn <info@lesosoftware.com>
To: ~alpine/aports <alpine-aports@lists.alpinelinux.org>
Cc: leso-kn <info@lesosoftware.com>
Message-ID: <2ba904e7-3ca8-5d57-560c-310b32f711a4@lesosoftware.com>
Subject: Re: [PATCH] main/bacula: fix bacula-dir crash (pthread double detach)

--FN8pUjiAfeHkq3X8IAPq5OgNC3I4mu2JH
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US

Hello! A short elaboration on this patch:

Summary: It's a bug fix for a crash in bacula director caused by a redund=
ant call to 'pthread_detach()'.


## Steps to reproduce: (without the proposed patch)

[see detailed instructions on how to quickly reproduce it via docker belo=
w]

1. On a fresh alpine setup, install bacula (e.g. bacula-pgsql) and bacula=
-client

2. Run bacula director

3. Try to connect to the director via 'bconsole' (type 'bconsole')


## Expected behavior:

- bconsole connects to bacula-dir and displays a command line


## Actual behavior: (without proposed patch)

- bacula-dir crashes. bconsole times out


--

Appendix

## Steps to quickly reproduce this bug inside docker:


- Create a blank alpine container: 'docker run --rm -ti alpine'

- Install bacula: 'apk add bacula-pgsql postgresql bacula-client'

- Initialize the database and bacula folders:

 =C2=A0 > mkdir -p /run/bacula
 =C2=A0 > chown bacula:bacula /run/bacula

 =C2=A0 > mkdir -p /var/lib/postgresql/data /run/postgresql
 =C2=A0 > chown -R postgres:postgres /var/lib/postgresql/data /run/postgr=
esql
 =C2=A0 > su - postgres -c "initdb /var/lib/postgresql/data"
 =C2=A0 > echo "host all=C2=A0 all=C2=A0=C2=A0=C2=A0 0.0.0.0/0=C2=A0 md5"=
 >> /var/lib/postgresql/data/pg_hba.conf
 =C2=A0 > su - postgres -c "pg_ctl start -D /var/lib/postgresql/data -l /=
var/lib/postgresql/log.log && \
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cd /etc/bacula/scr=
ipts && ./create_postgresql_database && ./make_postgresql_tables && \
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ./grant_postgresql=
_privileges && psql --command \"ALTER USER bacula WITH ENCRYPTED PASSWORD=
 'bacula';\""

- Run bacula-sd (in the background): 'su bacula - -s /bin/sh -c "bacula-s=
d -fc /etc/bacula/bacula-sd.conf" &'

- Run bacula-dir (in the background): 'su bacula - -s /bin/sh -c "bacula-=
dir -m -fc /etc/bacula/bacula-dir.conf"'

- Let it crash! 'bconsole'


Kind regards,

leso-kn



--FN8pUjiAfeHkq3X8IAPq5OgNC3I4mu2JH--

--3hOHDcEyEhzKwoJCdq9FdTuRZR4SE9mSa
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsD5BAABCAAjFiEEdQ2oFT/65TcviyX2RjM1Z7wb81EFAmJGVWEFAwAAAAAACgkQRjM1Z7wb81H7
9gv/dQ6yPO7RYkPDW3PudbT9giZWnLTEvUdjOAxeRkL6Om2DzT4wDg0uJm5xZBS2HSfD3KLUmupU
cw/S5MEJT10g3rAv+JzppaAMX4qf5yuYYMqhsUwkWYHmHHpKdTyOP8y4xeiB7xvt1cAL5RaSQcpw
6C8MizVWXWspATGeo0X46R4NU6u0To2n46e8DqNvFcLSH5UWGQi+2WNSt90SuOFUXu5G3j7xVaJY
0wRYXOt7q3ez152i6eo5GE+avS3q29rZHePAPvDeoJJr98PnGDL1Ess6zYxEn8eWbA82ozbENVS3
k9dm7RtEm4v3brh8ABspIfGWeSIqHHnKv9g8P6wXvyrUw/T4ojjk3e/pdK0bXbJbVx8EZl5o9MBO
FNTCgkteWkMJzToVvN4qlXBrdjjvXZvXCVhV8fkLzsxr1aa9ti/CBI24Buts/yom1Sk8gPPPhnt8
CPDOkhDgLfSjjTDUNWlXWvGbkg+pOTxn+JVvod1a6CAs/Cjm/Yn1SHDh3bZD
=Ii86
-----END PGP SIGNATURE-----

--3hOHDcEyEhzKwoJCdq9FdTuRZR4SE9mSa--