Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 8E103781A42
	for <~alpine/aports@lists.alpinelinux.org>; Sun, 27 Oct 2019 15:19:07 +0000 (UTC)
Received: from localhost (ip4d14d438.dynamic.kabel-deutschland.de [77.20.212.56])
	by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 49f881d0 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:YES);
	Sun, 27 Oct 2019 16:19:06 +0100 (CET)
Date: Sun, 27 Oct 2019 16:19:06 +0100
To: Drew DeVault <sir@cmpwn.com>
Cc: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] libedit: update to 20191025.3.1
From: soeren@soeren-tempel.net
References: <20191027142900.30512-1-sir@cmpwn.com>
In-Reply-To: <20191027142900.30512-1-sir@cmpwn.com>
Message-Id: <3BHSXOIFDJLIP.3MYOHDGFH159F@8pit.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

Thanks for the patch, found one minor issue though.

Drew DeVault <sir@cmpwn.com> wrote:
> -makedepends_build=3D""
> -makedepends_host=3D"$depends_dev"

If you remove this, makedepends will be empty, meaning: ncurses headers
will not be installed during compilation and the build will fail.
Unless, you have ncurses installed already, if you build with `abuild
rootbld` you might notice missing dependencies in the future.

Cheers,
S=C3=B6ren