Subject: Re: [alpine-aports] [PATCH v3] testing/flow-tools: new aport
To: Valery Kartel <valery.kartel@gmail.com>,
 alpine-aports@lists.alpinelinux.org
References: <20170426130420.20396-1-valery.kartel@gmail.com>
From: Leonardo Arena <rnalrd@gmail.com>
Message-ID: <41e904e6-570b-bd2e-6e24-45b75de244f0@gmail.com>
Date: Tue, 30 May 2017 08:36:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
Precedence: list
MIME-Version: 1.0
In-Reply-To: <20170426130420.20396-1-valery.kartel@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Hi,


On 04/26/2017 03:04 PM, Valery Kartel wrote:
> Tool set for working with NetFlow data
> https://code.google.com/p/flow-tools
>
> ---
> v1 -> v2: split to subpackages
>
> v2 -> v3: fix and improve $command_args in init-script
> ---
>   testing/flow-tools/APKBUILD                 | 106 ++++++++++++++++++++++++++++
>   testing/flow-tools/flow-capture.confd       |  33 +++++++++
>   testing/flow-tools/flow-capture.initd       |  18 +++++
>   testing/flow-tools/flow-capture.pre-install |   6 ++
>   4 files changed, 163 insertions(+)
>   create mode 100644 testing/flow-tools/APKBUILD
>   create mode 100644 testing/flow-tools/flow-capture.confd
>   create mode 100644 testing/flow-tools/flow-capture.initd
>   create mode 100644 testing/flow-tools/flow-capture.pre-install
>
> diff --git a/testing/flow-tools/APKBUILD b/testing/flow-tools/APKBUILD
> new file mode 100644
> index 0000000000..4d6c222889
> --- /dev/null
> +++ b/testing/flow-tools/APKBUILD
> @@ -0,0 +1,106 @@
> +# Contributor: Valery Kartel <valery.kartel@gmail.com>
> +# Maintainer: Valery Kartel <valery.kartel@gmail.com>
> +pkgname=flow-tools
> +pkgver=0.68.5.1
> +pkgrel=0
> +_pkgreal=flow
> +pkgdesc="Tool set for working with NetFlow data"
> +url="https://code.google.com/p/flow-tools"
> +arch="all"
> +license="BSD"
> +options="!check"
> +install="$_pkgreal-capture.pre-install"
> +pkgusers=$_pkgreal
> +pkggroups=$_pkgreal
> +depends_dev="perl"
> +makedepends="zlib-dev"
> +subpackages="$pkgname-doc libft-dev libft:libs
> +	$_pkgreal-capture $_pkgreal-log2rrd::noarch
> +	$_pkgreal-rptfmt::noarch $_pkgreal-rpt2rrd::noarch
> +	"
> +_tools="cat dscan expire export fanout filter gen header import
> +	mask merge nfilter print receive report send split stat tag xlate"
> +_tools_list="$_pkgreal-capture"
> +for _tool in $_tools; do
> +	subpackages="$subpackages $_pkgreal-$_tool:_tool"
> +	_tools_list="$_tools_list $_pkgreal-$_tool"
> +done

I see that 26 subpackages are created which are few KB in size. Is it 
really recommended to have such amount of subpkgs or the APKBUILD could 
be simplified?

Thanks!

/eo




---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---