Subject: Re: [alpine-aports] [PATCH] testing/go-dkim: new APKBUILD
To: Drew DeVault <sir@cmpwn.com>, alpine-aports@lists.alpinelinux.org
References: <20190312002211.10110-1-sir@cmpwn.com>
From: Leonardo <rnalrd@gmail.com>
Message-ID: <5e42d736-364b-2984-6562-378a40836c2f@gmail.com>
Date: Wed, 3 Apr 2019 14:55:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
Precedence: list
MIME-Version: 1.0
In-Reply-To: <20190312002211.10110-1-sir@cmpwn.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Hi,

On 3/12/19 1:22 AM, Drew DeVault wrote:
> ---
> I'm not great at openrc scripts, feedback welcome.

it looks good to me. You can avoid writing start() and stop() functions 
using "command_args" and "start_stop_daemon_args" to pass custom options.

>
>   testing/go-dkim/APKBUILD             | 42 +++++++++++++++++++++++++
>   testing/go-dkim/dkim-milter.confd    | 16 ++++++++++
>   testing/go-dkim/dkim-milter.initd    | 46 ++++++++++++++++++++++++++++
>   testing/go-dkim/go-dkim.post-install |  3 ++
>   4 files changed, 107 insertions(+)
>   create mode 100644 testing/go-dkim/APKBUILD
>   create mode 100644 testing/go-dkim/dkim-milter.confd
>   create mode 100644 testing/go-dkim/dkim-milter.initd
>   create mode 100644 testing/go-dkim/go-dkim.post-install

It seems that the build is not reproducible, since it seems to download 
some dependencies during the build process:

go: downloading github.com/emersion/go-milter 
v0.0.0-20190311184326-c3095a41a6fe
go: downloading github.com/emersion/go-msgauth 
v0.0.0-20190307192406-8646172ce7a5
go: downloading golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2

Am I mistaken?

Thanks!

/eo




---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---