X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 0435ADC08B0 for ; Wed, 7 Oct 2015 12:43:18 +0000 (UTC) Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com [209.85.220.50]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id B4B7DDC02C0 for ; Wed, 7 Oct 2015 12:43:17 +0000 (UTC) Received: by padhy16 with SMTP id hy16so20843481pad.1 for ; Wed, 07 Oct 2015 05:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=BKxAPkOPQ/nMKA6U2ys1b/oc/MlOKw4+itWTweQH2vA=; b=J+5sExnh0jo5/S6K3iAX/OcrkSlgt9YRTcor+4kBvZ6kv4dWFLlzpnRCIKZGaCYeF6 3JTf6iRsnSRyLbiia49uWdGMmuix2km0K24SYRmoKajmsPugJJMZQt90N3G5yhA7Z5tY p+5FmxMrPfywfn59aoQHJWensWsdb6bFcC6JFuSXLgs42FedKBmwv4NWNQItqfRbK4A0 Cq7h62CdoFuCL+0xjOIYztZApbCJQsWYh4o2bxDxYp4FDse6+0T3rRWn450zl0IVZaYG jGvspw1tZctSHXSXIBt0xnW6m47woPc2o97xxjL3mcy1fz1h1yLDmuqanmL/S26fpgwv T4Qg== X-Received: by 10.68.143.4 with SMTP id sa4mr924040pbb.111.1444221796514; Wed, 07 Oct 2015 05:43:16 -0700 (PDT) Received: from [192.168.1.222] ([103.233.80.102]) by smtp.gmail.com with ESMTPSA id kw10sm39429882pbc.25.2015.10.07.05.43.14 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 07 Oct 2015 05:43:15 -0700 (PDT) Date: Wed, 7 Oct 2015 20:43:11 +0800 From: Myautsai PAN To: Natanael Copa Cc: alpine-aports@lists.alpinelinux.org Message-ID: <68E15DF47C014DD1BF1681D8AE7BFDB4@gmail.com> In-Reply-To: <20150915103742.6a398cac@ncopa-desktop.alpinelinux.org> References: <1442078171-36189-1-git-send-email-myautsai@gmail.com> <20150915103742.6a398cac@ncopa-desktop.alpinelinux.org> Subject: Re: [alpine-aports] [PATCH] testing/openconnect: new aport X-Mailer: sparrow 1.6.4 (build 1176) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="5615135f_2f305def_1383" X-Virus-Scanned: ClamAV using ClamSMTP --5615135f_2f305def_1383 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Dear Natanael, Sorry about my delay. http://patchwork.alpinelinux.org/patch/562/ is the old patch. I updated the patch by instruction in http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch . But somehow [a new patch](http://patchwork.alpinelinux.org/patch/684/ ) is created. I'm not sure whether I'm doing the right thing. If not so, please close #562 and just use #684. Personally I strongly suggest immigrating from patchwork to GitHub and use the PR-mode. -- Myautsai PAN Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Tuesday, September 15, 2015 at 16:37, Natanael Copa wrote: > On Sun, 13 Sep 2015 01:16:11 +0800 > "PAN, Myautsai" wrote: > > > From: mckelvin > > > > http://www.infradead.org/openconnect/ > > Open client for Cisco AnyConnect VPN > > --- > > testing/openconnect/APKBUILD | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 testing/openconnect/APKBUILD > > > > > Thanks for this patch, but it does not build: > > checking for OPENSSL... no > checking for OpenSSL without pkg-config... no > configure: error: Could not build against OpenSSL > make: *** No targets specified and no makefile found. Stop. > > > > > > diff --git a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD > > new file mode 100644 > > index 0000000..4bdc4f2 > > --- /dev/null > > +++ b/testing/openconnect/APKBUILD > > @@ -0,0 +1,33 @@ > > +# Contributor: Myautsai PAN > > +# Maintainer: Myautsai PAN > > + > > +pkgname=openconnect > > +pkgver=7.06 > > +pkgrel=2 > > +pkgdesc="Open client for Cisco AnyConnect VPN" > > +url="http://www.infradead.org/openconnect/" > > +arch="all" > > +license="LGPL2.1" > > +depends="libxml2 gnutls libproxy vpnc krb5 lz4 openssl" > > > > > abuild will automatically pull in the needed runtime dependencies for > shared libraries so you will most likely not need the libxml2, gnutls > etc dependencies listed there. > > > +depends_dev="libxml2-dev gnutls-dev libproxy-dev vpnc krb5-dev lz4-dev openssl-dev gettext" > > +makedepends="intltool python" > > > > > depends_dev will only be added as dependency for a -dev subpackage. > Since there are no subpackages in this case, the depends_dev is > meaningless. > > I believe you need to move all the packages in depends_dev to makedepends. > > I am also not sure if gettext dep is needed? > > Care to send a v2 patch? > > http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch > > -nc --5615135f_2f305def_1383 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Dear Natanael,

Sorry about my delay.

http://patchwork.alpinelinux.org/patch/562/ is the old patch. I= updated the patch by instruction in http= ://wiki.alpinelinux.org/wiki/Creating=5Fpatches=23Resend=5Fan=5Fupdated=5F= patch . But somehow =5Ba new patch=5D(http://patchwork.alpinelinux.org/patch/= 684/ ) is created. I'm not sure whether I'm doing the right thin= g. If not so, please close =23562 and just use =23684.

Personally I strongly suggest immigrating from patchwork to GitHub= and use the PR-mode.

-- 
Myautsai PAN<= /div>
Sent with = Sparrow

=20

On Tuesday, September = 15, 2015 at 16:37, Natanael Copa wrote:

On Sun, 13 Sep 2015 01:16:11 +08= 00
=22PAN, Myautsai=22 <myautsai=40gmail.com> wrote:


Open c= lient for Cisco AnyConnect VPN
---
testing/openconne= ct/APKBUILD =7C 33 +++++++++++++++++++++++++++++++++
1 file ch= anged, 33 insertions(+)
create mode 100644 testing/openconnect= /APKBUILD

Thanks for this pat= ch, but it does not build:

checking for OPENSSL.= .. no
checking for OpenSSL without pkg-config... no
c= onfigure: error: Could not build against OpenSSL
make: *** No t= argets specified and no makefile found. Stop.

<= br>

diff --gi= t a/testing/openconnect/APKBUILD b/testing/openconnect/APKBUILD
new file mode 100644
index 0000000..4bdc4f2
--- /dev= /null
+++ b/testing/openconnect/APKBUILD
=40=40 -0,0 = +1,33 =40=40
+=23 Contributor: Myautsai PAN <myautsai=40gmail.com>
+=23 = Maintainer: Myautsai PAN <= myautsai=40gmail.com>
+
+pkgname=3Dopenconnect=
+pkgver=3D7.06
+pkgrel=3D2
+pkgdesc=3D=22O= pen client for Cisco AnyConnect VPN=22
+arch=3D=22all=22
+license=3D=22LGPL2.1=22=
+depends=3D=22libxml2 gnutls libproxy vpnc krb5 lz4 openssl=22=

abuild will automatically pu= ll in the needed runtime dependencies for
shared libraries so y= ou will most likely not need the libxml2, gnutls
etc dependenci= es listed there.

<= div>+depends=5Fdev=3D=22libxml2-dev gnutls-dev libproxy-dev vpnc krb5-dev= lz4-dev openssl-dev gettext=22
+makedepends=3D=22intltool pyth= on=22

depends=5Fdev will only= be added as dependency for a -dev subpackage.
Since there are = no subpackages in this case, the depends=5Fdev is
meaningless.<= /div>

I believe you need to move all the packages in d= epends=5Fdev to makedepends.

I am also not sure = if gettext dep is needed=3F

Care to send a v2 pa= tch=3F


-nc
=20 =20 =20 =20 =20

--5615135f_2f305def_1383-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---