Content-Type: text/plain; charset=utf-8
Precedence: list
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
Subject: Re: [alpine-aports] [PATCH] testing/mongodb: fix bug #5117 where mongo fails at start
From: Marc Vertes <marc.vertes@ugrid.net>
In-Reply-To: <20160223150743.33e55efa@vostro.util.wtbts.net>
Date: Tue, 23 Feb 2016 15:41:23 +0100
Cc: alpine-aports@lists.alpinelinux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9D775D86-8A4D-49ED-8512-EBD572ECF6D6@ugrid.net>
References: <1456083383-9196-1-git-send-email-marc.vertes@ugrid.net> <20160223150743.33e55efa@vostro.util.wtbts.net>
To: Timo Teras <timo.teras@iki.fi>


> Le 23 f=C3=A9vr. 2016 =C3=A0 14:07, Timo Teras <timo.teras@iki.fi> a =
=C3=A9crit :
>=20
> On Sun, 21 Feb 2016 19:36:23 +0000
> Marc Vertes <marc.vertes@ugrid.net> wrote:
>=20
>> The check for recursion has been disabled, as it makes mongo shell
>> aborting at start. There may be a better fix, perhaps ensuring
>> that recursion is OK under musl, and maybe increasing stack space ?
>=20
> Could you try if the following works instead:
>=20
>=20
> --- /dev/null
> +++ b/testing/mongodb/musl-process-stack-size.patch
> @@ -0,0 +1,22 @@
> +--- =
mongodb-src-r3.2.1.orig/src/mongo/platform/stack_locator_pthread_getattr_n=
p.cpp
> ++++ =
mongodb-src-r3.2.1/src/mongo/platform/stack_locator_pthread_getattr_np.cpp=

> +@@ -31,6 +31,7 @@
> + #include "mongo/platform/stack_locator.h"
> +=20
> + #include <pthread.h>
> ++#include <sys/resource.h>
> +=20
> + #include "mongo/util/assert_util.h"
> + #include "mongo/util/scopeguard.h"
> +@@ -52,6 +53,11 @@
> +     invariant(result =3D=3D 0);
> +     invariant(base !=3D nullptr);
> +     invariant(size !=3D 0);
> ++
> ++    struct rlimit rl;
> ++
> ++    invariant(getrlimit(RLIMIT_STACK, &rl) =3D=3D 0);
> ++    size =3D rl.rlim_cur ? : 2 * 1024 * 1024;
> +=20
> +     // TODO: Assumes a downward growing stack. Note here that
> +     // getstack returns the stack *base*, being the bottom of the
> --=20
> 2.7.1
>=20
It doesn't work. And on my side, I tried a similar modification (using =
getrlimit) in src/third_party/mozjs-38/extract/js/src/jsnativestack.cpp =
without success.=20

But I found a separate patch which works:

--- src/mongo/scripting/mozjs/implscope.cpp.orig
+++ src/mongo/scripting/mozjs/implscope.cpp
@@ -258,6 +258,7 @@
             //
             // TODO: What if we are running on a platform with very
             // large pages, like 4MB?
+            //JS_SetNativeStackQuota(_runtime, available.get() - (64 * =
1024));
             JS_SetNativeStackQuota(_runtime, available.get() - (32 * =
1024));
         }
=20
So I believe that it should be a matter of increasing allocated stack at =
thread creation. I'm still not able to do that, despite my various =
attempts.

Marc=


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---