Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com
 [209.85.222.193])	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id
 BFDEE781AE4	for <~alpine/aports@lists.alpinelinux.org>; Mon,  5 Aug 2019
 18:28:52 +0000 (UTC)
Received: by mail-qk1-f193.google.com with SMTP id d79so60802530qke.11       
 for <~alpine/aports@lists.alpinelinux.org>; Mon, 05 Aug 2019 11:28:52 -0700
 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=content-transfer-encoding:in-reply-to:date:cc:subject:from:to
         :message-id;
        bh=Zxk6qzfuJxNiy9WaYY2u1hc9E0L5LMKtd9OaWtDLCx8=;
        b=AYtzAaJFdUh/z9hB0k7D41MryodqW+1FUaVQl/RvKa+KCVyfaUjUUXkg5plEx5RDqL
         El5umQ2cfOItSw8zZ3SUW3Z5sIJGXPPdqc6iyU2tWokkyMb4bnrcmJCnpsPINjTAAf7u
         ivk7xkCO5VlfSG/I81rOb2sTCIZdwGjyb9Pz+HpLt992nx/VLQNWw4T2okXAkZSe4y1I
         WCd3H0Gjo+YJoJ4/gkHzskeUQRwC0bYFxYVntPXot5dPMp5uwdcsoN9Yx4khmItkQYNA
         D2lkPqRFhcn7tv1giBR+NsccXzgQeaRkB/pflZDYF16ZK6AZo711snnk/9UqTccLD5Vb
         CO/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:content-transfer-encoding:in-reply-to:date:cc
         :subject:from:to:message-id;
        bh=Zxk6qzfuJxNiy9WaYY2u1hc9E0L5LMKtd9OaWtDLCx8=;
        b=SxdgaMHkA0RKccfMB6hSXZuF4BRvyugtWsMOLdHJenfqDuO2n2oYf875HZz7KQBH+6
         ioVMVn6mpjeW777w6Tgp4HMto/aQkwZVNgsgnxlFal3M38j/8+QjsjTklOi6aPl6zdJj
         0mjyNDBec+NtkPhhOi/Z+E8rhKr8TD6x8qIfdw8AMCSV8AM458RGXcVBqugu3SwM4lTr
         RSBFJZtpyjGWZBaJ4iwejOM9mWA/IPRyWbMXbML8UnK10vAvk6+l+B/tPFKkUKLvzV9d
         xcDMaIpET2WFu3B0YfxxuWoY4UFCnv2ki0EYhojXDNlz4m8r0t40eoFlFU/J7G9wvNND
         n57g==
X-Gm-Message-State: APjAAAV+zDhqwcQxaTALaH7oLpcPeBnuMYmZNLVEigoxPzU3lmqgr1V1
	DqoDmXFg4TPYTP9HQSMLzbF/KHWL
X-Google-Smtp-Source: =?utf-8?q?APXvYqwFk/YRpAN0uKpvQ+ZdDunEr3CMrxOYkcubzhcx?=
 =?utf-8?q?hl1P8eSJpKHx2J4GdGEbt+2mWefIDQMI8A=3D=3D?=
X-Received: by 2002:a05:620a:10bc:: with SMTP id
 h28mr102143131qkk.289.1565029731306;        Mon, 05 Aug 2019 11:28:51 -0700
 (PDT)
Received: from localhost ([2804:14c:3ba1:31:e4f3:3f76:6a2c:41cc])        by
 smtp.gmail.com with ESMTPSA id q56sm43104782qtq.64.2019.08.05.11.28.49
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Mon, 05 Aug 2019 11:28:50 -0700 (PDT)
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20190805180111.30712-1-me@cosmoborsky.com>
Date: Mon, 05 Aug 2019 15:29:10 -0300
Cc: "Cosmo Borsky" <me@cosmoborsky.com>
Subject: Re: [PATCH] testing/bemenu: new aport
From: "Leo" <thinkabit.ukim@gmail.com>
To: "Cosmo Borsky" <me@cosmoborsky.com>,
 <~alpine/aports@lists.alpinelinux.org>
Message-Id: <BW1WQU3ZKFJD.PLO74EN3DGGB@Impreza>

> +arch=3D"x86_64"=20

Why explicitly only x86_64 ?=20

> +license=3D"GPL3 LGPL3"

Need to use SPDX identifiers for the license and a SPDX keyword to indicate=
 the relationship between them

> +depends=3D"pango"

Don't think this is necessary

> +makedepends=3D"cmake libxkbcommon libxinerama ncurses wayland"

I think some require the -dev suffix

> +install=3D""

empty variable can be removed for brevity

> +subpackages=3D""

empty variable can be removed for brevity

> +source=3D"
> +	$pkgname-$pkgver.tar.gz::https://github.com/Cloudef/$pkgname/archive/$p=
kgver.tar.gz
> +"

Can be in a single line, don't use $pkgname in the source url

> +builddir=3D"$srcdir/"

set to $srcdir/$pkgname-$pkgver

> +	cd "bemenu-$pkgver"

This line can be removed with the change to builddir=3D

> +	cd "bemenu-$pkgver"

Same here

> +	cd "bemenu-$pkgver"

And here