Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Originaldate: Sat Jan 11, 2020 at 2:15 AM
Originalfrom: "Leo" <thinkabit.ukim@gmail.com>
Original: =?utf-8?q?All_the_lines_contain_^M,_which_breaks_everything._Please_use_a?= =?utf-8?q?_UNIX=0D=0Aenvironment_(preferably_Alpine)_while_creating_patch?= =?utf-8?q?es.=0D=0A=0D=0APlease_use_tabs_instead_of_spaces_for_indentatio?= =?utf-8?q?n.=0D=0A=0D=0ANo_need_for_that_post-install_script,_GTK_already?= =?utf-8?q?_has_a_trigger_for_it.=0D=0A=0D=0ALastly_your_program_segfaults?= =?utf-8?q?_when_starting_on_Wayland,_only_when_you=0D=0Adidn't_start_it_a?= =?utf-8?q?lready_on_X11.=0D=0A?=
In-Reply-To: <20200111021503.053e156c@enterprise>
Date: Sat, 11 Jan 2020 21:16:51 +0100
Subject: Re: [PATCH] testing/klavaro: new aport
From: =?utf-8?q?V=C3=96R=C3=96SK=C5=90I_Andr=C3=A1s?= <voroskoi@gmail.com>
To: <alpine-aports@lists.alpinelinux.org>
Message-Id: <BZT8LWEZXO7D.OD1Z703DL76Q@parittya>

Hi Leo,

Thanks for reviewing!

On Sat Jan 11, 2020 at 2:15 AM, Leo wrote:
> All the lines contain ^M, which breaks everything. Please use a UNIX
> environment (preferably Alpine) while creating patches.

I did actually. Also 'dos2unix -u APKBUILD' does nothing with the file.
OTOH dos2unix -d appens those ^Ms to each line. What am I doing wrong?

> Please use tabs instead of spaces for indentation.

By bad. Fixed.

> No need for that post-install script, GTK already has a trigger for it.

Thanks. Removed.

> Lastly your program segfaults when starting on Wayland, only when you
> didn't start it already on X11.

I need some time for this one as I do not use wayland (yet). I will try
to reproduce and fix it.

Thanks,