Received: from mail.cmpwn.com (mail.cmpwn.com [45.56.77.53])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 87A41782C2B
	for <~alpine/aports@lists.alpinelinux.org>; Thu, 16 Jan 2020 23:08:02 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cmpwn.com; s=cmpwn;
	t=1579216080; bh=Fr3Jn463uy9EuEPbeF/qXLN5IVGDr5phFYjWkPoobUI=;
	h=In-Reply-To:Date:Cc:Subject:From:To;
	b=txBbjfXUScuYbeQlyVHa7JB07rllQmmuPj2T+PYYw194Dfyh7HgMghVqnDMhQCKb9
	 o4Ot2QCG4cqW54mUhZbthXisa4mnvRfUMhJTiMTHvW5/vkzIrsCBAVPHXn4phSZiwE
	 Dl0IxqWujulD2fRZ7oqv3Mi+zAyMCsb3/74mcDEI=
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <CALdTKe80jbhM+mamcmqqLQwm8VD=Q4cdOrdt
 =CQjHzaKgu9dYg@mail.gmail.com>
Date: Thu, 16 Jan 2020 18:06:37 -0500
Cc: <~alpine/aports@lists.alpinelinux.org>
Subject: Re: [PATCH] testing/prometheus-node-exporter: import from sr.ht
From: "Drew DeVault" <sir@cmpwn.com>
To: "Tiago Ilieve" <tiago.myhro@gmail.com>
Message-Id: <BZXLCLNE106J.2X1545VIKMF9J@homura>

On Wed Jan 15, 2020 at 7:54 AM, Tiago Ilieve wrote:
> - Doesn't the patch make sense anymore? I've not been following the
> state of Go race condition check in musl lately.

That patch affects the makefile, which is now not used.

> - Does it make sense to drop the version information from the binary?
> I'm inferring that, as the software is being installed by a package
> manager, you are considering this information to be irrelevant.

We can update this to specify the version information in a manner
similar to how the prometheus package does it. Good point for v2.

> - If the binary name is being changed, why opt for
> 'prometheus_node_exporter' (with underscores) instead of
> 'prometheus-node-exporter' (with hyphens), like other distributions[1]
> are doing?

It doesn't really matter (you use it through the init.d file), but we
can change this too.

> - Changing the default binding to 127.0.0.1:9100 might break user
> expectations, as it currently defaults to 0.0.0.0:9100. My use cases,
> for instance, always involved fetching data from it remotely. Binding
> it to localhost by default seems too restrictive in this case, akin to
> doing the same to a HTTP server.

Ack, let's use 0.0.0.0.