MIME-Version: 1.0
References: <20191128015742.21302-1-sir@cmpwn.com> <20191128015742.21302-2-sir@cmpwn.com>
In-Reply-To: <20191128015742.21302-2-sir@cmpwn.com>
From: Konstantin Kulikov <k.kulikov2@gmail.com>
Date: Fri, 29 Nov 2019 14:37:00 +0300
Message-ID: <CAD+eXGQe8597KdoCC-95Xj2DXYS+bt6eXW830wA654O-7TJbBg@mail.gmail.com>
Subject: Re: [PATCH 1/2] community/prometheus: new APKBUILD
To: Drew DeVault <sir@cmpwn.com>
Cc: ~alpine/aports@lists.alpinelinux.org
Content-Type: text/plain; charset="UTF-8"

>+               -gcflags "all=-trimpath=$PWD" \
>+               -asmflags "all=-trimpath=$PWD" \

You can use simpler go build -trimpath here.
Also add -mod=vendor to avoid downloading modules during build (will
become the default in go1.14).

>+config_file=/etc/prometheus/prometheus.yml
>+storage_path=/var/lib/prometheus/data

Usual convention is to prefix variable name with service name (eg
prometheus_config_file) to avoid potential conflicts with other openrc
defined variables.

>+supervise_daemon_args="-1 /var/log/prometheus.log -2 /var/log/prometheus.log"

I recommend to use output_log and error_log variables in conf.d
instead. The biggest problem with supervise-daemon is that you can't
rotate log files without your restarting service.

>+pidfile="/run/${RC_SVCNAME}.pid"
Not needed with supervise-daemon

>+grep '^prometheus' /etc/group
This will also match usernames starting with "prometheus", for ex
"prometheusexporter".