X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) by lists.alpinelinux.org (Postfix) with ESMTP id 848D55C5169 for ; Sun, 24 Jun 2018 06:35:30 +0000 (GMT) Received: by mail-lf0-f47.google.com with SMTP id v17-v6so5045603lfe.13 for ; Sat, 23 Jun 2018 23:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=duniel-no.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+paChDqAAUSIFWi5rfP/y1qdxk6OVB2jyo59ugfL2CA=; b=aqZH3ZE8I53AGs8QLXSXXwFcVSavmXEj8qz4XCDWATnpQYyayZBnP4dmxRbokY3Ws7 BxK/WcXYoRP9oWWtoFwpPnl113cvVlhRiNoxMER2fSd/l+9mRhxgfbjfLBEA+aTbTV9j 1M/eIKxvrLjgzUlLk+d8Is1CCEAybVAyRQaZjismk065UQQi12t9WIFbAeHeJfyz5LpF kdOjCwLA6TpQ4LS/gITCuDM9FCzYeesXqKFY7d2qeKSwe8g3ei1zsZq/I6ef/+Wz8Tor p4iqFPVTcrH8Wv/d6EurB6ZRXDcafSoZgLH3qm9BHX8HLbugHmE4Yz1fOnImBlRGOT3i WSKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+paChDqAAUSIFWi5rfP/y1qdxk6OVB2jyo59ugfL2CA=; b=gfx1GOdXbeRTdIEAn2Pfve3wEVzJ3iSt0QNUa4L9So94QX7g3sWQQDD9vaHeYZ+BlW brC6lJiKSkdNIgddmHYBaZDLT3aiCkWxrTde2IK6E0SBWhAdoqtVaTrXyL2V9tqGsnDE iYQJvw4Ek++pQs+CJu5FfOLp0JgdcDLy7ST8Z0n0WJ92ZASTJo0MjrfTBwUgMwbQfwCV kGxsoaWjlmVvZ0LWPiMqKXFmWXVo5fpqjQB6HyWB9JRzRejZYKU9F9M+1uo+IYgtTSn5 b8xfXIEm5t0/I059UaZtVUASVJxrpP5FfOkih0SqHS7ac/Nd4LgXt0Hm7SFv1LTIx0Ef GlWA== X-Gm-Message-State: APt69E0oEcc5zdcFXIZ4lkvnhtEGMRvBsS2xOuh9DU781lNp3DYnF8Pn qta3D6TCNpUn22xHDqYAyMuFVfsov0xq4kTg3EL84g== X-Google-Smtp-Source: ADUXVKKWN9pqeBdXl45uCbFTMljl5uHrELb0mTghXDwglIMh+aM07BOP2PwSeLQ8a+OIvPUmQ4zeMVnzyMi2oxZAp4o= X-Received: by 2002:a19:7:: with SMTP id 7-v6mr3209966lfa.62.1529822128990; Sat, 23 Jun 2018 23:35:28 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 2002:ab3:1d08:0:0:0:0:0 with HTTP; Sat, 23 Jun 2018 23:35:28 -0700 (PDT) In-Reply-To: <20180623203923.8920-1-azarus@posteo.net> References: <20180623203923.8920-1-azarus@posteo.net> From: Daniel Isaksen Date: Sun, 24 Jun 2018 08:35:28 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] community/wine: switch to https:// & whitespace To: Sascha Paunovic Cc: alpine-aports@lists.alpinelinux.org Content-Type: multipart/alternative; boundary="000000000000917e58056f5d787d" --000000000000917e58056f5d787d Content-Type: text/plain; charset="UTF-8" Hi Sascha, apk verifies downloaded content with their hashes, which is why we don't use HTTPS in the sources. In this case, it will merely make the builder system spend unnecessary resources doing cryptography. Changing the URL is fine though - but I recommend you create a new patch addressing this. - Daniel On Sat, Jun 23, 2018 at 10:39 PM, Sascha Paunovic wrote: > --- > community/wine/APKBUILD | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/community/wine/APKBUILD b/community/wine/APKBUILD > index 39b1f29dc3..2bef62aa51 100644 > --- a/community/wine/APKBUILD > +++ b/community/wine/APKBUILD > @@ -8,7 +8,7 @@ pkgver=3.0 > _pkgver=${pkgver/_/-} > pkgrel=0 > pkgdesc="A compatibility layer for running Windows programs" > -url="http://www.winehq.com" > +url="https://www.winehq.com" > arch="x86 x86_64" > license="LGPL-2.0-or-later" > # As of 2.0.3 most of the tests fails > @@ -22,7 +22,7 @@ makedepends="fontconfig-dev openldap-dev libxslt-dev > libxxf86dga-dev > cups-dev alsa-lib-dev lcms-dev libxml2-dev paxmark dbus-dev > libxi-dev > gnutls-dev tiff-dev v4l-utils-dev udisks2-dev autoconf automake > " > -source="http://dl.winehq.org/$pkgname/source/${pkgver%.[1- > 9]}/$pkgname-$_pkgver.tar.xz > +source="https://dl.winehq.org/$pkgname/source/${pkgver%. > [1-9]}/$pkgname-$_pkgver.tar.xz > no-pie.patch > winhlp32-flex.patch > " > @@ -50,7 +50,7 @@ build() { > --localstatedir=/var \ > --with-dbus \ > --with-x \ > - $_win64 > + $_win64 > make > } > > -- > 2.18.0 > > > > --- > Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org > Help: alpine-aports+help@lists.alpinelinux.org > --- > > --000000000000917e58056f5d787d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Sascha,

apk verifies downloaded cont= ent with their hashes, which is why we don't use HTTPS in the sources.<= /div>

In this case, it will merely make the builder syst= em spend unnecessary resources doing cryptography.

Changing the URL is fine though - but I recommend you create a new patch a= ddressing this.

- Daniel <d@duniel.no>

On Sat, Jun 23, 2018 at 10:39 PM, Sascha Paunovic <= span dir=3D"ltr"><azarus@posteo.net> wrote:
= ---
=C2=A0community/wine/APKBUILD | 6 +++---
=C2=A01 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/community/wine/APKBUILD b/community/wine/APKBUILD
index 39b1f29dc3..2bef62aa51 100644
--- a/community/wine/APKBUILD
+++ b/community/wine/APKBUILD
@@ -8,7 +8,7 @@ pkgver=3D3.0
=C2=A0_pkgver=3D${pkgver/_/-}
=C2=A0pkgrel=3D0
=C2=A0pkgdesc=3D"A compatibility layer for running Windows programs&qu= ot;
-url=3D"http://www.winehq.com"
+url=3D"https://www.winehq.com"
=C2=A0arch=3D"x86 x86_64"
=C2=A0license=3D"LGPL-2.0-or-later"
=C2=A0# As of 2.0.3 most of the tests fails
@@ -22,7 +22,7 @@ makedepends=3D"fontconfig-dev openldap-dev libxslt-d= ev libxxf86dga-dev
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cups-dev alsa-lib-dev lcms-dev libxml2-dev paxm= ark dbus-dev libxi-dev
=C2=A0 =C2=A0 =C2=A0 =C2=A0 gnutls-dev tiff-dev v4l-utils-dev udisks2-dev a= utoconf automake
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "
-source=3D"http://dl.winehq.org/= $pkgname/source/${pkgver%.[1-9]}/$pkgname-$_pkgver.tar.xz
+source=3D
"h= ttps://dl.winehq.org/$pkgname/source/${pkgver%.[1-9]}/$pkgname-$_= pkgver.tar.xz
=C2=A0 =C2=A0 =C2=A0 =C2=A0 no-pie.patch
=C2=A0 =C2=A0 =C2=A0 =C2=A0 winhlp32-flex.patch
=C2=A0 =C2=A0 =C2=A0 =C2=A0 "
@@ -50,7 +50,7 @@ build() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --localstatedir=3D/= var \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-dbus \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-x \
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$_win64
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0$_win64
=C2=A0 =C2=A0 =C2=A0 =C2=A0 make
=C2=A0}
=C2=A0
--
2.18.0



---
Unsubscribe:=C2=A0 alpine-aports+unsubscribe@lists.alpinelinux.org
Help:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0alpine-aports+help@lists.alpinelinux.org=
---


--000000000000917e58056f5d787d-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---