X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-vk0-f46.google.com (mail-vk0-f46.google.com [209.85.213.46]) by lists.alpinelinux.org (Postfix) with ESMTP id C43C65C56D6 for ; Thu, 28 Sep 2017 10:01:35 +0000 (GMT) Received: by mail-vk0-f46.google.com with SMTP id h63so473493vka.4 for ; Thu, 28 Sep 2017 03:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=duniel-no.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ufComgjl+9TwSMps4KUa6qANq4swbBNrz50YAAV9+l0=; b=O/virRsvvbIyrEGYrvndstho2622q5Xz1uwmNESwcGlHDvW1lUAGZ6tJFaFv85LykT FB2Sj4lzLSSOBLSXgf8Cg4+AvApAPqwZHLE/VVYdrg65Xr9gebC3lZANwFYHCiatjamB nOe1ecqmPkgaueyyvZTLzqYZxChHE/ImlNFfhKxZk1Ah4lzvaukzFQycCaWYKnUj2vXa 9X5eSpYnfbJI2cy4PlgzyWx/h6QmeDqDg9KCBcVzfsB2fkHgTacwuPElKkzxHH8ztaGi 9zfkhDmfekCHZDqp9fgz5mlp4GG1UCypf2JFjwvS9LuSrOuOcs4J1q6eACFJ11RHTE1Q dJrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ufComgjl+9TwSMps4KUa6qANq4swbBNrz50YAAV9+l0=; b=EADw1U0Tf3p30iodrmEfntHOJHxq21rzP8KKnP518VfT4Q/S0V9BTgoGXpAg+l4mr9 FHPIDa32CblSj5casQ7c9Skc4GGzW9chCIrhZ4xKRXPKeQnGveKjsczd89nRxvcjke7X o3EtVPkfADz4/+zNJ3QS11/f6Q3HbHPE7BsUWpbNr/d2cyci82b+N1Q6ZiEjqg1YxYJM 68ieCYGGD5pW53mlGu+IgnV+ZsUKCdlygiIAnblZ8qYkUxqbXmIT7TUS9T9T+qn0Ye8t QgUnurQfPcyUjYBT67f1LtIqkX14BjlWhZC6xEkar22LcSf67Y2NkYrCvCiOsK2cW/4T 72rw== X-Gm-Message-State: AMCzsaVtfuZOEICGlfCDpDWhctN2NwzCqpmLLeJxIDk3XCbXijfGncnC Qx1Dqapr+yfgmBFtlo4qoBzcjM/KOkRURxZkgXAY4A== X-Google-Smtp-Source: AOwi7QDU1u9GiQuHMiLK6FIovIdgSRkXVw8lgfivJU4Pbh6hf9UMJ7h2+RENvQ/ScUUF7/ufKVq/ecrlaEzQ2ZpwpB4= X-Received: by 10.31.34.84 with SMTP id i81mr2261202vki.66.1506592895189; Thu, 28 Sep 2017 03:01:35 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 10.159.39.4 with HTTP; Thu, 28 Sep 2017 03:01:34 -0700 (PDT) X-Originating-IP: [81.93.98.194] Received: by 10.159.39.4 with HTTP; Thu, 28 Sep 2017 03:01:34 -0700 (PDT) In-Reply-To: <20170928115034.7a8789d8@ncopa-desktop.copa.dup.pw> References: <20170927014037.11808-1-d@duniel.no> <20170928115034.7a8789d8@ncopa-desktop.copa.dup.pw> From: Daniel Isaksen Date: Thu, 28 Sep 2017 12:01:34 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/tmate: new aport To: Natanael Copa Cc: alpine-aports@lists.alpinelinux.org Content-Type: multipart/alternative; boundary="001a113dc3e856d4f4055a3cfea4" --001a113dc3e856d4f4055a3cfea4 Content-Type: text/plain; charset="UTF-8" I forgot to remove the dependency. I will fix it ASAP - or you can, if you have the time. - Daniel On Sep 28, 2017 11:50 AM, "Natanael Copa" wrote: > On Wed, 27 Sep 2017 01:40:37 +0000 > Daniel Isaksen wrote: > > > --- > > testing/tmate/APKBUILD | 51 > +++++++++++++++++++++++++++++++ > > testing/tmate/remove-backtrace-musl.patch | 28 +++++++++++++++++ > > 2 files changed, 79 insertions(+) > > create mode 100644 testing/tmate/APKBUILD > > create mode 100644 testing/tmate/remove-backtrace-musl.patch > > > > diff --git a/testing/tmate/APKBUILD b/testing/tmate/APKBUILD > > new file mode 100644 > > index 0000000000..82e4bdf021 > > --- /dev/null > > +++ b/testing/tmate/APKBUILD > > @@ -0,0 +1,51 @@ > > +# Maintainer: Daniel Isaksen > > +pkgname=tmate > > +pkgver=2.2.1 > > +pkgrel=0 > > +pkgdesc="Instant Terminal Sharing" > > +url="https://tmate.io/" > > +arch="all" > > +license="ISC" > > +depends="ncurses-terminfo" > > +makedepends="ncurses-dev libevent-dev autoconf automake > bsd-compat-headers > > + libtool zlib-dev libssh-dev msgpack-c-dev libexecinfo-dev" > > Do you need libexecinfo when you remove the use of backtrace? > > -nc > > > +install= > > +subpackages="$pkgname-doc" > > +source="$pkgname-$pkgver.tar.gz::https://github.com/$ > pkgname-io/$pkgname/archive/$pkgver.tar.gz > > + remove-backtrace-musl.patch" > > + > > +builddir="$srcdir/"$pkgname-$pkgver > > + > > +build() { > > + cd "$builddir" > > + > > + ./autogen.sh || return 1 > > + > > + ./configure \ > > + --build=$CBUILD \ > > + --host=$CHOST \ > > + --prefix=/usr \ > > + --sysconfdir=/etc \ > > + --mandir=/usr/share/man \ > > + --localstatedir=/var > > + make > > +} > > + > > +check() { > > + cd "$builddir" > > + make check > > +} > > + > > +package() { > > + cd "$builddir" > > + make DESTDIR="$pkgdir" install > > + > > + install -Dm644 example_tmux.conf \ > > + "$pkgdir"/usr/share/doc/$pkgname/examples/$pkgname.conf > > + for file in CHANGES FAQ README TODO; do > > + install -m644 "$file" "$pkgdir"/usr/share/doc/$pkgname/ > > + done > > +} > > + > > +sha512sums="3d4ce7510cd8da39bc4fe63f2a6417 > 9846a813bb3560ca811d9e1e2a28b06d95a9033047a900d76bda069c249d > 7ebbe1143daa082b23212c5d32a50bf1819d2d tmate-2.2.1.tar.gz > > +530f17f86688980fb3e0d48adaff70cc413efafda7025be4f1dfaaf5a3d7 > 1ab21ee923a1d658d30691464e375aea73ba1b06a4b5545998c4a7df9dc19fc91561 > remove-backtrace-musl.patch" > > diff --git a/testing/tmate/remove-backtrace-musl.patch > b/testing/tmate/remove-backtrace-musl.patch > > new file mode 100644 > > index 0000000000..650634855b > > --- /dev/null > > +++ b/testing/tmate/remove-backtrace-musl.patch > > @@ -0,0 +1,28 @@ > > +This is a quite ugly hack to make it compile. > > + > > +TODO: use libunwind instead. > > + > > +--- > > +--- a/tmate-debug.c > > ++++ b/tmate-debug.c > > +@@ -60,18 +60,17 @@ void tmate_print_stack_trace(void) > > + char **strings; > > + size_t i; > > + > > ++#if 0 > > + size = backtrace (array, 20); > > + strings = backtrace_symbols (array, size); > > + > > + tmate_info ("============ %zd stack frames ============", size); > > + > > + for (i = 1; i < size; i++) { > > +-#if DEBUG > > + if (print_resolved_stack_frame(strings[i]) < 0) > > +-#endif > > + tmate_info("%s", strings[i]); > > + } > > +- > > ++#endif > > + free (strings); > > + } > > + > > --001a113dc3e856d4f4055a3cfea4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I forgot to remove the dependency. I will fix it ASAP - o= r you can, if you have the time.

- Daniel

On Sep 28, 2017 11:50 AM, "Natanael Copa" <ncopa@alpinelinux.org> wrote:
On Wed, 27 Sep 2017 01:40:37 += 0000
Daniel Isaksen <d@duniel.no> wrote= :

> ---
>=C2=A0 testing/tmate/APKBUILD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 51 +++++++++++++++++++++++++++++++
>=C2=A0 testing/tmate/remove-backtrace-musl.patch | 28 ++++++++++++= +++++
>=C2=A0 2 files changed, 79 insertions(+)
>=C2=A0 create mode 100644 testing/tmate/APKBUILD
>=C2=A0 create mode 100644 testing/tmate/remove-backtrace-musl.patc= h
>
> diff --git a/testing/tmate/APKBUILD b/testing/tmate/APKBUILD
> new file mode 100644
> index 0000000000..82e4bdf021
> --- /dev/null
> +++ b/testing/tmate/APKBUILD
> @@ -0,0 +1,51 @@
> +# Maintainer: Daniel Isaksen <d@dun= iel.no>
> +pkgname=3Dtmate
> +pkgver=3D2.2.1
> +pkgrel=3D0
> +pkgdesc=3D"Instant Terminal Sharing"
> +url=3D"https://tmate.io/"
> +arch=3D"all"
> +license=3D"ISC"
> +depends=3D"ncurses-terminfo"
> +makedepends=3D"ncurses-dev libevent-dev autoconf automake bsd-co= mpat-headers
> +=C2=A0 =C2=A0 =C2=A0libtool zlib-dev libssh-dev msgpack-c-dev libexec= info-dev"

Do you need libexecinfo when you remove the use of backtrace?

-nc

> +install=3D
> +subpackages=3D"$pkgname-doc"
> +source=3D"$pkgname-$pkgver.tar.gz::https://github.com/$pkgname-io/$pkgname/archive/$pkg= ver.tar.gz
> +=C2=A0 =C2=A0 =C2=A0remove-backtrace-musl.patch"
> +
> +builddir=3D"$srcdir/"$pkgname-$pkgver
> +
> +build() {
> +=C2=A0 =C2=A0 =C2=A0cd "$builddir"
> +
> +=C2=A0 =C2=A0 =C2=A0./autogen.sh || return 1
> +
> +=C2=A0 =C2=A0 =C2=A0./configure \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--build=3D$CBUILD \ > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--host=3D$CHOST \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--prefix=3D/usr \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--sysconfdir=3D/etc \=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--mandir=3D/usr/share= /man \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--localstatedir=3D/va= r
> +=C2=A0 =C2=A0 =C2=A0make
> +}
> +
> +check() {
> +=C2=A0 =C2=A0 =C2=A0cd "$builddir"
> +=C2=A0 =C2=A0 =C2=A0make check
> +}
> +
> +package() {
> +=C2=A0 =C2=A0 =C2=A0cd "$builddir"
> +=C2=A0 =C2=A0 =C2=A0make DESTDIR=3D"$pkgdir" install
> +
> +=C2=A0 =C2=A0 =C2=A0install -Dm644 example_tmux.conf \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"$pkgdir"/u= sr/share/doc/$pkgname/examples/$pkgname.conf
> +=C2=A0 =C2=A0 =C2=A0for file in CHANGES FAQ README TODO; do
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0install -m644 "$= file" "$pkgdir"/usr/share/doc/$pkgname/
> +=C2=A0 =C2=A0 =C2=A0done
> +}
> +
> +sha512sums=3D"3d4ce7510cd8da39bc4fe63f2a64179846a813bb= 3560ca811d9e1e2a28b06d95a9033047a900d76bda069c249d7ebbe1143daa082= b23212c5d32a50bf1819d2d=C2=A0 tmate-2.2.1.tar.gz
> +530f17f86688980fb3e0d48adaff70cc413efafda7025be4f1dfaaf5a3d= 71ab21ee923a1d658d30691464e375aea73ba1b06a4b5545998c4a7df9dc19fc91561=C2=A0 remove-backtrace-musl.patch"
> diff --git a/testing/tmate/remove-backtrace-musl.patch b/testing/= tmate/remove-backtrace-musl.patch
> new file mode 100644
> index 0000000000..650634855b
> --- /dev/null
> +++ b/testing/tmate/remove-backtrace-musl.patch
> @@ -0,0 +1,28 @@
> +This is a quite ugly hack to make it compile.
> +
> +TODO: use libunwind instead.
> +
> +---
> +--- a/tmate-debug.c
> ++++ b/tmate-debug.c
> +@@ -60,18 +60,17 @@ void tmate_print_stack_trace(void)
> +=C2=A0 =C2=A0 =C2=A0char **strings;
> +=C2=A0 =C2=A0 =C2=A0size_t i;
> +
> ++#if 0
> +=C2=A0 =C2=A0 =C2=A0size =3D backtrace (array, 20);
> +=C2=A0 =C2=A0 =C2=A0strings =3D backtrace_symbols (array, size);
> +
> +=C2=A0 =C2=A0 =C2=A0tmate_info ("=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D %zd stack frames =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D", size);<= br> > +
> +=C2=A0 =C2=A0 =C2=A0for (i =3D 1; i < size; i++) {
> +-#if DEBUG
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (print_resolved_st= ack_frame(strings[i]) < 0)
> +-#endif
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0tmate_info("%s", strings[i]);
> +=C2=A0 =C2=A0 =C2=A0}
> +-
> ++#endif
> +=C2=A0 =C2=A0 =C2=A0free (strings);
> + }
> +

--001a113dc3e856d4f4055a3cfea4-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---