Precedence: list
MIME-Version: 1.0
In-Reply-To: <20170921164722.GA3@computer.craftyguy.net>
References: <20170921164722.GA3@computer.craftyguy.net>
From: Leonardo Arena <rnalrd@gmail.com>
Date: Wed, 10 Jan 2018 15:19:28 +0100
Message-ID: <CAGG_d8AkQZF_LnqELemihgdjktL5nomwNFbHQW2SOq7kPG9X1g@mail.gmail.com>
Subject: Re: [alpine-aports] testing/tslib: new aport
To: Clayton Craft <clayton@craftyguy.net>
Cc: alpine-aports <alpine-aports@lists.alpinelinux.org>
Content-Type: multipart/alternative; boundary="001a114a7a1627d52e05626cb8eb"

--001a114a7a1627d52e05626cb8eb
Content-Type: text/plain; charset="UTF-8"

Hi,

sorry for the delayed feedback.

On Thu, Sep 21, 2017 at 6:47 PM, Clayton Craft <clayton@craftyguy.net>
wrote:

> https://github.com/kergoth/tslib
> tslib is a touchscreen access library
> ---
> testing/tslib/APKBUILD | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 testing/tslib/APKBUILD
>
> diff --git a/testing/tslib/APKBUILD b/testing/tslib/APKBUILD
> new file mode 100644
> index 0000000000..e1c56237f3
> --- /dev/null
> +++ b/testing/tslib/APKBUILD
> @@ -0,0 +1,30 @@
> +# Contributor: Clayton Craft <clayton@craftyguy.net>
> +# Maintainer: Clayton Craft <clayton@craftyguy.net>
> +pkgname=tslib
> +pkgver=1.13
> +pkgrel=0
> +pkgdesc="Touchscreen Access Library"
> +arch="all"
> +url="https://github.com/kergoth/tslib"
> +license="GPL2"
> +makedepends="autoconf automake libtool linux-headers"
> +source="https://github.com/kergoth/tslib/releases/download/
> ${pkgver}/${pkgname}-${pkgver}.tar.xz"
> +subpackages="$pkgname-dev $pkgname-doc"
> +builddir="${srcdir}/${pkgname}-${pkgver}"
>

Only "$srcdir" needs to be between brackets. Please omit also "{}".


> +
> +build() {
> +    ./autogen.sh
>

This needs to be moved into prepare().


> +    ./configure --prefix=/usr --sysconfdir=/etc
> +    make
> +}
> +
> +check() {
> +    cd "${builddir}"
>

"{}" aren't needed.



> +    make check
> +}
> +
> +package() {
> +    cd "${builddir}"
>

Same here.

Thanks

/eo

--001a114a7a1627d52e05626cb8eb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,<br><br></div>sorry for the delayed feedback.<br><=
div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Thu, Sep 2=
1, 2017 at 6:47 PM, Clayton Craft <span dir=3D"ltr">&lt;<a href=3D"mailto:c=
layton@craftyguy.net" target=3D"_blank">clayton@craftyguy.net</a>&gt;</span=
> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex"><a href=3D"https://github.com/ke=
rgoth/tslib" rel=3D"noreferrer" target=3D"_blank">https://github.com/kergot=
h/tsl<wbr>ib</a><br>
tslib is a touchscreen access library<br>
---<br>
testing/tslib/APKBUILD | 30 ++++++++++++++++++++++++++++++<br>
1 file changed, 30 insertions(+)<br>
create mode 100644 testing/tslib/APKBUILD<br>
<br>
diff --git a/testing/tslib/APKBUILD b/testing/tslib/APKBUILD<br>
new file mode 100644<br>
index 0000000000..e1c56237f3<br>
--- /dev/null<br>
+++ b/testing/tslib/APKBUILD<br>
@@ -0,0 +1,30 @@<br>
+# Contributor: Clayton Craft &lt;<a href=3D"mailto:clayton@craftyguy.net" =
target=3D"_blank">clayton@craftyguy.net</a>&gt;<br>
+# Maintainer: Clayton Craft &lt;<a href=3D"mailto:clayton@craftyguy.net" t=
arget=3D"_blank">clayton@craftyguy.net</a>&gt;<br>
+pkgname=3Dtslib<br>
+pkgver=3D1.13<br>
+pkgrel=3D0<br>
+pkgdesc=3D&quot;Touchscreen Access Library&quot;<br>
+arch=3D&quot;all&quot;<br>
+url=3D&quot;<a href=3D"https://github.com/kergoth/tslib" rel=3D"noreferrer=
" target=3D"_blank">https://github.com/kergo<wbr>th/tslib</a>&quot;<br>
+license=3D&quot;GPL2&quot;<br>
+makedepends=3D&quot;autoconf automake libtool linux-headers&quot;<br>
+source=3D&quot;<a href=3D"https://github.com/kergoth/tslib/releases/downlo=
ad/$%7Bpkgver%7D/$%7Bpkgname%7D-$%7Bpkgver%7D.tar.xz" rel=3D"noreferrer" ta=
rget=3D"_blank">https://github.com/ke<wbr>rgoth/tslib/releases/download/<wb=
r>${pkgver}/${pkgname}-${pkgver}<wbr>.tar.xz</a>&quot;<br>
+subpackages=3D&quot;$pkgname-dev $pkgname-doc&quot;<br>
+builddir=3D&quot;${srcdir}/${pkgname<wbr>}-${pkgver}&quot;<br></blockquote=
><div><br></div><div>Only &quot;$srcdir&quot; needs to be between brackets.=
 Please omit also &quot;{}&quot;.<br></div><div>=C2=A0</div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pa=
dding-left:1ex">
+<br>
+build() {<br>
+=C2=A0 =C2=A0 ./autogen.sh<br></blockquote><div><br></div><div>This needs =
to be moved into prepare().<br></div><div>=C2=A0</div><blockquote class=3D"=
gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-=
left:1ex">
+=C2=A0 =C2=A0 ./configure --prefix=3D/usr --sysconfdir=3D/etc<br>
+=C2=A0 =C2=A0 make<br>
+}<br>
+<br>
+check() {<br>
+=C2=A0 =C2=A0 cd &quot;${builddir}&quot;<br></blockquote><div><br></div><d=
iv>&quot;{}&quot; aren&#39;t needed.<br></div><div><br></div><div>=C2=A0</d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left=
:1px #ccc solid;padding-left:1ex">
+=C2=A0 =C2=A0 make check<br>
+}<br>
+<br>
+package() {<br>
+=C2=A0 =C2=A0 cd &quot;${builddir}&quot;<br></blockquote><div><br></div><d=
iv>Same here.<br></div><div>=C2=A0</div><div>Thanks<br></div><br></div>/eo<=
br></div></div></div>

--001a114a7a1627d52e05626cb8eb--


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---