X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by lists.alpinelinux.org (Postfix) with ESMTP id BA3825C0D84 for ; Mon, 15 Oct 2018 06:40:35 +0000 (GMT) Received: by mail-vs1-f49.google.com with SMTP id i10so15584288vsm.13 for ; Sun, 14 Oct 2018 23:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OEQaC/YUxrQuGLaMkkbKo/DoL3SW2YYiGWSsI9BVQiw=; b=oxvP22xYD3q1VEADp9B53jAt9BbY2I/SQm3u//qWvAa9boRHSiFJjCQYBQmPjhrtTD E1ZbIOGm6nTtgA5L+RA3dXPvN77FeeKhx1r4RC+8Vil/zkDc98WC1LIMVbrtgesDgbXS e4HUAlL0k+vspFwLS0iiOxNwChZkaZZygOvKrPQdH7+QryIwWfQQNS3xOInk8Qu/zyWI XCqETqD3CdDFA3EU7m/2nu5PFa0KK59nOQUB2DLLs7lQ8hFTHkQYri3UkPlgJKlcszMo iILt4aiEv9jdnpZXj42AErmirqgEFaBfI5ggs97IfVLzOHOTkfRQ+kjAn4QuX/rTMwUa b05g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OEQaC/YUxrQuGLaMkkbKo/DoL3SW2YYiGWSsI9BVQiw=; b=McA0qdCuZ30eFStWG0S1TMdstRsUcmLG14IeKUghdf44H7E8t5qYjpOdd+9SwW0qJW ESLPhNorEuP45M23MBm93CJ/X4IXbvonU80bPC5ssJ4rMmV7QCJbiGhyBCg/i37fESFI 6kAle4ccbYvo/mnws0tYA4Eoxe36R+Uqe/MytC/vgA1m9Hl39wcnY6Vy9DWshhl1oOin d0mASRzZm4ntboy36EQVMKu5T0a7AXkSJTk/aJbVl0H3h8fbzQIv12ODyYdTJbW0j8ff fM6mqMGr8x4VZGJegJe1rvUp1iiklFoo14iS4yoP0BZ1I4yhYHT2OK74/L5dppUM9G+4 HC8Q== X-Gm-Message-State: ABuFfohiuW3NhXXJacWW56sI/2S3iUZk9aHVk1Ijyg0Y3rCH6aIijiD3 zoK/9ESfWOD2OppdSnLoco2iDC3dqQU0u7UvJDi+hQ== X-Google-Smtp-Source: ACcGV639yRCFphhdNh7T319yQ1q3co8j7CY/zqEQsLoj5jRTn4Nq9vufU5d+Ilk6bCkw/7MLLZ0LSCkxVqYmFb2FDK8= X-Received: by 2002:a67:1205:: with SMTP id 5mr3394104vss.207.1539585635238; Sun, 14 Oct 2018 23:40:35 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 References: <20180502145222.5059-1-marian.buschsieweke@ovgu.de> <20180530163417.21284613@faultier2go> In-Reply-To: <20180530163417.21284613@faultier2go> From: Leonardo Arena Date: Mon, 15 Oct 2018 08:40:24 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/pygal: New aport To: Marian Buschsieweke Cc: alpine-aports Content-Type: multipart/alternative; boundary="000000000000e3c6e505783eb617" --000000000000e3c6e505783eb617 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, applied with further modifications. On Wed, May 30, 2018 at 4:34 PM Marian Buschsieweke < marian.buschsieweke@ovgu.de> wrote: > Hi, > > thanks for the feedback. I attached the fixed patch. > > Kind regards, > Marian > > ------------------------------------------------------------- > M.Sc. Marian Buschsieweke > Dept. Communication and Networked Systems (ComSys) > Institute for Intelligent Cooperating Systems (IKS) > Otto-von-Guericke-University of Magdeburg > Universit=C3=A4tsplatz 2, Building 29, Room 314 > 39106 Magdeburg > Germany > > http://www.comsys.ovgu.de/Team/Marian+Buschsieweke.html > Tel.: +49 - 391 - 67 - 52673 > Fax: +49 - 391 - 67 - 41161 > > ------------------------------------------------------------- > > On Wed, 30 May 2018 15:35:04 +0200 > Leonardo Arena wrote: > > > Hi, > > > > please see some comments below. > > > > On Wed, May 2, 2018 at 4:52 PM, Marian Buschsieweke < > > marian.buschsieweke@ovgu.de> wrote: > > > > > pygal is a dynamic SVG charting library written in python > > > https://pygal.org > > > --- > > > testing/pygal/APKBUILD | 42 ++++++++++++++++++++++++++++++++++++++++= ++ > > > 1 file changed, 42 insertions(+) > > > create mode 100644 testing/pygal/APKBUILD > Looking at other packages whose name start with "py", I kept the "py" in the name and added the prefix "py-". So the package name is actually py-pygal. > > > > > > diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD > > > new file mode 100644 > > > index 0000000000..e459f22ec6 > > > --- /dev/null > > > +++ b/testing/pygal/APKBUILD > > > @@ -0,0 +1,42 @@ > > > +# Maintainer: Marian Buschsieweke > > > +pkgname=3Dpygal > > > > > > > > > I think we should call it "py-gal" regardless of the actual upstream > name, > > for the sake of naming consistency of all pyhon packages. > > > > > > > > > +pkgver=3D2.4.0 > > > +pkgrel=3D0 > > > +pkgdesc=3D"pygal is a dynamic SVG charting library written in python= " > > > +url=3D"https://pygal.org" > > > +arch=3D"noarch" > > > +license=3D"LGPL3" > Fixed license ID. > > > +makedepends=3D"python2-dev python3-dev py-setuptools" > > > +subpackages=3D"py2-${pkgname}:_py2 py3-${pkgname}:_py3" > > > +source=3D" > https://files.pythonhosted.org/packages/source/${pkgname:0:1}/$ > > > pkgname/$pkgname-$pkgver.tar.gz" > > > +builddir=3D"$srcdir"/$pkgname-$pkgver > Disabled tests since there aren't any. Thanks /eo --000000000000e3c6e505783eb617 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

applied with further mod= ifications.

On Wed, Ma= y 30, 2018 at 4:34 PM Marian Buschsieweke <marian.buschsieweke@ovgu.de> wrote:
Hi,

thanks for the feedback. I attached the fixed patch.

Kind regards,
Marian

-------------------------------------------------------------
M.Sc. Marian Buschsieweke
Dept. Communication and Networked Systems (ComSys)
Institute for Intelligent Cooperating Systems (IKS)
Otto-von-Guericke-University of Magdeburg
Universit=C3=A4tsplatz 2, Building 29, Room 314
39106 Magdeburg
Germany

http://www.comsys.ovgu.de/Team/Marian+Buschsi= eweke.html
Tel.: +49 - 391 - 67 - 52673
Fax:=C2=A0 +49 - 391 - 67 - 41161

-------------------------------------------------------------

On Wed, 30 May 2018 15:35:04 +0200
Leonardo Arena <rn= alrd@gmail.com> wrote:

> Hi,
>
> please see some comments below.
>
> On Wed, May 2, 2018 at 4:52 PM, Marian Buschsieweke <
> maria= n.buschsieweke@ovgu.de> wrote:=C2=A0
>
> > pygal is a dynamic SVG charting library written in python
> > https://pygal.org
> > ---
> >=C2=A0 testing/pygal/APKBUILD | 42 +++++++++++++++++++++++++++++++= +++++++++++
> >=C2=A0 1 file changed, 42 insertions(+)
> >=C2=A0 create mode 100644 testing/pygal/APKBUILD
<= div>
Looking at other packages whose name start with "py= ", I kept the "py" in the name and added the prefix "py= -".
So the package name is actually py-pygal.
=
=C2=A0
> >
> > diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD
> > new file mode 100644
> > index 0000000000..e459f22ec6
> > --- /dev/null
> > +++ b/testing/pygal/APKBUILD
> > @@ -0,0 +1,42 @@
> > +# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de><= br> > > +pkgname=3Dpygal
> >=C2=A0
>
>
> I think we should call it "py-gal" regardless of the actual = upstream name,
> for the sake of naming consistency of all pyhon packages.
>
>
>
> > +pkgver=3D2.4.0
> > +pkgrel=3D0
> > +pkgdesc=3D"pygal is a dynamic SVG charting library written = in python"
> > +url=3D"https://pygal.org"
> > +arch=3D"noarch"
> > +license=3D"LGPL3"

=
Fixed license ID.
=C2=A0
> > +makedepends=3D"python2-dev python3-dev py-setuptools"<= br> > > +subpackages=3D"py2-${pkgname}:_py2 py3-${pkgname}:_py3"= ;
> > +source=3D"https:/= /files.pythonhosted.org/packages/source/${pkgname:0:1}/$
> > pkgname/$pkgname-$pkgver.tar.gz"
> > +builddir=3D"$srcdir"/$pkgname-$pkgver
=


Disabled tests since there aren't an= y.

=C2=A0Thanks

/eo
--000000000000e3c6e505783eb617-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---