X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua0-f175.google.com (mail-ua0-f175.google.com [209.85.217.175]) by lists.alpinelinux.org (Postfix) with ESMTP id 2F3065C418B for ; Tue, 20 Mar 2018 10:41:32 +0000 (GMT) Received: by mail-ua0-f175.google.com with SMTP id w3so681668uae.5 for ; Tue, 20 Mar 2018 03:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vL2x8piHonHOpqGr/m97Ey6nJcZLt1/0H8E5YH6k1Ds=; b=Cihof2jkc4p9p3m49sTxUyeD8MiYh2TB77Imn+NZc5QAbRsVP+V1rkimYiz5Zw4MXW 3LpxwVNpWX5c+fQbBE7pnYncggnyNyA6KKYviJUlL3EHT3k+U5Jgt9nCZvfBzXVUN6Ts FoEf0h6DWZbAGQGItdffoEkPuUsIe2jAWg79vfF+JKT6DF3gT9+waKF7rUhMgWG82qVi dNldjeQhmPaNTY18X67Q6WvBRriw7AflJdVpMW6TH6isekfsHUhS5KfPLxmIqhpU6NwA knLEWeR0bsWAUqOXRJ3HJOzGcR0c93fj0E4AxgNZGFLRwzqrFlAo4KgCtRhCriS+wz/9 GEdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vL2x8piHonHOpqGr/m97Ey6nJcZLt1/0H8E5YH6k1Ds=; b=AHzpysxq3Zi26xF9rYTcLl6DqqGdllKedAP1T8xY9MqF/EUsvN3W9b9hAOcI87XAWp QSk7k6HW/JPGWWKOQf2C6z/rAD+aqIqsmF9/oP2MGwVfU5kJLBY/bFVRXRYtSxhCKt/Z NiYiQS1lDta6i0qvBv7E2p8VVAxF+YOEhX4k1A7PjdCVUtJWKl9j1202HYTW7Fg+PjYW X1BjAE3jCgP7eZepnhlZdWkUjLpg1mSNZEO9EwHxjTU9hrkZo8gSCsEvTSkrLQWf7tMU 9LQIO9RlbctojNORrq7fAgY2WRoKQWGSlCRSDdAY2UHkoiP3/oGNUj4i/6Gl3Uqh7Kaf TP2Q== X-Gm-Message-State: AElRT7EEHw/54/N7SUs0zQpYLp62B5FmEwMlmpb+JHba1rtkgfSh9Bda DhqFDDHdAwGHvvb5seq8++VV7j1/usJJNaEPlXs= X-Google-Smtp-Source: AG47ELu2WVdhdT/bUiRrRV4ir3NiKIkbTQ+zwqlLAIwJmy/KTNgl1zPwe8m83Dzsqe2EAV42Gh7C2VrQY/xFOzp9ip8= X-Received: by 10.176.4.118 with SMTP id 109mr8377191uav.198.1521542491424; Tue, 20 Mar 2018 03:41:31 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 10.159.38.23 with HTTP; Tue, 20 Mar 2018 03:41:31 -0700 (PDT) In-Reply-To: <20180303130713.8869-1-taner76@gmail.com> References: <20180303130713.8869-1-taner76@gmail.com> From: Leonardo Arena Date: Tue, 20 Mar 2018 11:41:31 +0100 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/vdr: new plugin: vaapidevice, fix streamdev install path, grand config files to video group, cosmetics To: Taner Tas Cc: alpine-aports Content-Type: multipart/alternative; boundary="94eb2c08e9dcb64acf0567d5b703" --94eb2c08e9dcb64acf0567d5b703 Content-Type: text/plain; charset="UTF-8" Hi, sorry for the late review: On Sat, Mar 3, 2018 at 2:07 PM, Taner Tas wrote: > --- > testing/vdr/APKBUILD | 74 +++++++++++++++++++++++++----- > ------ > testing/vdr/Make.config | 25 ++++++------ > testing/vdr/streamdev-fix-path.patch | 10 +++++ > 3 files changed, 74 insertions(+), 35 deletions(-) > create mode 100644 testing/vdr/streamdev-fix-path.patch > > [snip] > @@ -38,19 +41,31 @@ prepare() { > rm -rf ${builddir}/PLUGINS/src/skincurses > cp -aP $srcdir/vdr-plugin-femon-${_femon_ver} > ${builddir}/PLUGINS/src/femon > cp -aP $srcdir/vdr-plugin-softhddevice-${_softhddevice_ver} > ${builddir}/PLUGINS/src/softhddevice > + cp -aP $srcdir/vdr-plugin-vaapidevice-${_vaapidevice_ver} > ${builddir}/PLUGINS/src/vaapidevice > cp -aP $srcdir/vdr-plugin-mpv-${_mpv_ver} > ${builddir}/PLUGINS/src/mpv > cp -aP $srcdir/vdr-plugin-vnsiserver-${_vnsiserver_ver} > ${builddir}/PLUGINS/src/vnsiserver > cp -aP $srcdir/vdr-plugin-streamdev-${_streamdev_ver} > ${builddir}/PLUGINS/src/streamdev > cd "$builddir" > + cp "$srcdir"/Make.config "$builddir" > default_prepare > } > > build() { > cd "$builddir" > - cp $srcdir/Make.config $builddir > + sed -i -e 's/LIBS =/LIBS=-lintl -lexecinfo/' Makefile > This should go into prepare(). Also a patch is preferable instead of dynamic editing. > make > } > > +package() { > + cd "$builddir" > + source "$builddir"/Make.config > + make -j1 DESTDIR="$pkgdir" install > Would be nice to fix parallel building, but it's okay for pushing as is. Thanks! /eo --94eb2c08e9dcb64acf0567d5b703 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

sorry for the late review:

On Sat, Mar 3, 2018 at = 2:07 PM, Taner Tas <taner76@gmail.com> wrote:
---
=C2=A0testing/vdr/APKBUILD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 74 +++++++++++++++++++++++++-----------
=C2=A0testing/vdr/Make.config=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 | 25 ++++++------
=C2=A0testing/vdr/streamdev-fix-path.patch | 10 +++++
=C2=A03 files changed, 74 insertions(+), 35 deletions(-)
=C2=A0create mode 100644 testing/vdr/streamdev-fix-path.patch

=C2=A0
=C2=A0[snip]


@@ -38,19 +41,31 @@ prepare() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 rm -rf ${builddir}/PLUGINS/src/skincurses<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 cp -aP $srcdir/vdr-plugin-femon-${_femon_v= er} ${builddir}/PLUGINS/src/femon
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cp -aP $srcdir/vdr-plugin-softhddevice-${_= softhddevice_ver} ${builddir}/PLUGINS/src/softhddevice
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cp -aP $srcdir/vdr-plugin-vaapidevice-${_v= aapidevice_ver} ${builddir}/PLUGINS/src/vaapidevice
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cp -aP $srcdir/vdr-plugin-mpv-${_mpv_ver} = ${builddir}/PLUGINS/src/mpv
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cp -aP $srcdir/vdr-plugin-vnsiserver-${_vn= siserver_ver} ${builddir}/PLUGINS/src/vnsiserver
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cp -aP $srcdir/vdr-plugin-streamdev-${_str= eamdev_ver} ${builddir}/PLUGINS/src/streamdev
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cp "$srcdir"/Make.config "$build= dir"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 default_prepare
=C2=A0}

=C2=A0build() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cd "$builddir"
-=C2=A0 =C2=A0 =C2=A0 =C2=A0cp $srcdir/Make.config $builddir
+=C2=A0 =C2=A0 =C2=A0 =C2=A0sed -i -e 's/LIBS=C2=A0 =C2=A0 =C2=A0 =3D/L= IBS=3D-lintl -lexecinfo/' Makefile

This should go into prepare(). Also a patch is preferable instead of = dynamic editing.

=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 make
=C2=A0}

+package() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0source "$builddir"/Make.config
+=C2=A0 =C2=A0 =C2=A0 =C2=A0make -j1 DESTDIR=3D"$pkgdir" install<= br>

Would be nice to fix parallel bui= lding, but it's okay for pushing as is.
=C2=A0
Thank= s!

/eo
--94eb2c08e9dcb64acf0567d5b703-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---