X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com [209.85.213.41]) by lists.alpinelinux.org (Postfix) with ESMTP id 3454D5C525D for ; Wed, 11 Jul 2018 13:40:33 +0000 (GMT) Received: by mail-vk0-f41.google.com with SMTP id e139-v6so12957658vkf.6 for ; Wed, 11 Jul 2018 06:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kxpzDVkeTByHXdvdaW4TS+/5ZQvc9tM76SNv+Q5EePg=; b=RSsphsDR5TKU9kdIennnv+S+DjsFsAmF48uRk5dXQkehOUnFAmv+9XvdVUxCThYXK2 4Cwh9ofAkxx+MJR0aSNh9H7Yhj4MfCgElOgFCh8rkOXz0cWpO0s/jUeeqF/EVBVxx+/n cCdPPo2RP0XI4EEN1eKTbAOLa5d6jqZI7sO5n0IO3Dy/zAdbCiBvdjMos+ygHw4dKILj EcCGQJzbiRWLzD3EuH0BMyMTLxbXZt8i+4j1BzI+hsYdV6YBNmwp7seBDTnUaPOlwi8m PiLG6EsBtrQMMeZWxZUUdlEJDLYMS3OMTAIV8WdZp27BHrj6CzL0xKk9U93bApjtvXjy DaNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kxpzDVkeTByHXdvdaW4TS+/5ZQvc9tM76SNv+Q5EePg=; b=eZGz18p+ZHRUJI+rYuErXznNXVmv0xhFZrLlkxmWh5VPdXMwyOQRQAgPR8Getoi+Vu ilsFcjVwFt3/uo9BEwu95y2Q5d3lrz0jqKxbfWxR+8LqgZJPl2hLEiKVT7v07UMKN0bk Yom7VIP4D+vbkdjWcBVqbsQxFeHbE1/igpIMmJ9DXixT4Seu2GbjWUK6wTyogdIkfMnp TwbuvKfvZLw4uWOZlYiXW+1V2UgqZQC0Mz+GZPEYxHq4dvZ3fhynNd4FhR4D9n0mXS8C Blcma8KyvK1mllWJfIzZNeoDhJq51OJv8V3jqWo9gbVgMDp6uV2MjNsgoFq3aOwbOOEg IvLA== X-Gm-Message-State: AOUpUlHfUq7AxZD3EOwxv8s/mySi2QbRud2565/NuA7X3ToO76e3BJU7 CsRMGxlZ/SuhhYNz30f9Jw9GPtGWF9hwtU8+J2YbTg== X-Google-Smtp-Source: AAOMgpdcExCBmox291BdWsDbUecBNWUWRBzEt6XkOdHuDuCSAJXjXboQdF/pJhRVSo9f2zkiALGcNFunBAlsEpg6o5A= X-Received: by 2002:a1f:9b16:: with SMTP id d22-v6mr2063809vke.164.1531316432436; Wed, 11 Jul 2018 06:40:32 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 2002:ab0:6152:0:0:0:0:0 with HTTP; Wed, 11 Jul 2018 06:40:32 -0700 (PDT) In-Reply-To: <20180701144515.6785-1-azarus@posteo.net> References: <20180701144515.6785-1-azarus@posteo.net> From: Leonardo Arena Date: Wed, 11 Jul 2018 15:40:32 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/cava: new aport To: Sascha Paunovic Cc: alpine-aports Content-Type: multipart/alternative; boundary="000000000000fe819d0570b9638d" --000000000000fe819d0570b9638d Content-Type: text/plain; charset="UTF-8" Hi, please see some comments below: On Sun, Jul 1, 2018 at 4:45 PM, Sascha Paunovic wrote: > --- > testing/cava/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 testing/cava/APKBUILD > > diff --git a/testing/cava/APKBUILD b/testing/cava/APKBUILD > new file mode 100644 > index 0000000000..b2dfe566e7 > --- /dev/null > +++ b/testing/cava/APKBUILD > @@ -0,0 +1,38 @@ > +# Contributor: Sascha Paunovic > +# Maintainer: Sascha Paunovic > +#TODO: pulseaudio & sndio subpackage > +pkgname=cava > +pkgver=0.6.1 > +pkgrel=0 > +pkgdesc="console based audio visualizer for ALSA & more" > +url="https://github.com/karlstav/cava" > +arch="all" > +license="MIT" > +makedepends="fftw-dev ncurses-dev alsa-lib-dev libtool" > Automake and autoconf are missing. > +source="$pkgname-$pkgver.tar.gz::https://github.com/ > karlstav/$pkgname/archive/$pkgver.tar.gz" > +builddir="$srcdir/$pkgname-$pkgver" > + > +build() { > + cd "$builddir" > + autoreconf -if > autoreconf should be moved into "prepare()" which should run also "default_prepare" first. > + ./configure \ > + --build=$CBUILD \ > + --host=$CHOST \ > + --prefix=/usr \ > + --sysconfdir=/etc \ > + --mandir=/usr/share/man \ > + --localstatedir=/var > + make > +} > + > +check() { > + cd "$builddir" > + make check # currently doesn't do much, but better than nothing > +} > + > +package() { > + cd "$builddir" > + make DESTDIR="$pkgdir" install > +} > + > +sha512sums="fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c3052b0821c2f69f342 > 3e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a6fba8139ca128ebecb > cava-0.6.1.tar.gz" > > Everything else looks good, thanks! /eo --000000000000fe819d0570b9638d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

please see some comments= below:

= On Sun, Jul 1, 2018 at 4:45 PM, Sascha Paunovic <azarus@posteo.net>= wrote:
---
=C2=A0testing/cava/APKBUILD | 38 +++++++++++++++++++++++++++++++++++++= +
=C2=A01 file changed, 38 insertions(+)
=C2=A0create mode 100644 testing/cava/APKBUILD

diff --git a/testing/cava/APKBUILD b/testing/cava/APKBUILD
new file mode 100644
index 0000000000..b2dfe566e7
--- /dev/null
+++ b/testing/cava/APKBUILD
@@ -0,0 +1,38 @@
+# Contributor: Sascha Paunovic <az= arus@posteo.net>
+# Maintainer: Sascha Paunovic <aza= rus@posteo.net>
+#TODO: pulseaudio & sndio subpackage
+pkgname=3Dcava
+pkgver=3D0.6.1
+pkgrel=3D0
+pkgdesc=3D"console based audio visualizer for ALSA & more" +url=3D"https://github.com/karlstav/cava"
+arch=3D"all"
+license=3D"MIT"
+makedepends=3D"fftw-dev ncurses-dev alsa-lib-dev libtool"


Automake and autoconf are miss= ing.

=C2=A0
https://github.com/karlstav/$pkgname/archive/$pkgver.tar.gz<= /a>"
+builddir=3D"$srcdir/$pkgname-$pkgver"
+
+build() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0autoreconf -if

<= div>
autoreconf should be moved into "prepare()" wh= ich should run also "default_prepare" first.
=

=C2=A0
+=C2=A0 =C2=A0 =C2=A0 =C2=A0./configure \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--build=3D$CBUILD \=
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--host=3D$CHOST \ +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--prefix=3D/usr \ +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--sysconfdir=3D/etc= \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--mandir=3D/usr/sha= re/man \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--localstatedir=3D/= var
+=C2=A0 =C2=A0 =C2=A0 =C2=A0make
+}
+
+check() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0make check # currently doesn't do much, but= better than nothing
+}
+
+package() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0make DESTDIR=3D"$pkgdir" install
+}
+
+sha512sums=3D"fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c305= 2b0821c2f69f3423e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a= 6fba8139ca128ebecb=C2=A0 cava-0.6.1.tar.gz"



Everything else looks good, thanks!

/eo

--000000000000fe819d0570b9638d-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---