X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by lists.alpinelinux.org (Postfix) with ESMTP id E8385F8315F for ; Tue, 12 Feb 2019 13:00:20 +0000 (UTC) Received: by mail-ua1-f53.google.com with SMTP id e16so814550uam.12 for ; Tue, 12 Feb 2019 05:00:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ja5gHWspD3EMUPCRoZQdWA4AFeId446WyrqsVMcxr+o=; b=ZVnqHMLw3ir7/10BEOB0EPUKhdn68Iw2BZmzKLh3iNN83qqmoT2tO+LR9nybB1NyRq Ue64Nq0WnpP5y94ZiiSB4DrcROYRPhedm70r+z6r/F+NULc5v+d464r08J0tpbSxVVDU SMokBOR2a4AuQ9KvKXyzX0A8LpTa3g27GDRCtWqG36UDw0/tv4PkEwPVvt8cYazSJyWv aEgQbCWGjp6sGGXwh8+HmDDdcrWpm3qzYPKecijsVQPhbEmTMV2IoWYXihDUf+BjULLs dxiZFuzqNMlWzT1p5qK3TYctWGO8u1DDy/lJ8TKvHOa8jhTnyt4Nc4dMmDUuUXT0M+Z+ vA9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ja5gHWspD3EMUPCRoZQdWA4AFeId446WyrqsVMcxr+o=; b=CclsNACqz3hM6e+/MDdLjujfsDjjs3+9tvUec3LJadJ8d0Cgyq9WmkIzAUnI0pZOjc wGenMuDlcGBSC36MNPYOyFHsgnbqfiGhkzBDEoFP4OavqNWxTQ5GD1NLBSXnm9VGwiDf cBv51VBMns/eAPbEXAZrNzPjEHhBo5AUdThcOeivtJNNt9XIGzfIbiiVlUGIMM8919x+ 4XMh+fD+pDgVLMYKR/3Q8S0xJqvUHX/ACPPUmFz7RCWqW/LZ0kd+qQhpRXrxECr8Z0ER 4smunfgxqMQsmtHzzMkhIPiGQfJy3/vMri1U4GuvbVHHMSx91lgzIUjGaJNdqSFXQxBc 6n1Q== X-Gm-Message-State: AHQUAuYBC169/FBrSRUchRkdnaapL+T/+ZkpTx8BZp6f5jKK8xFR20WS JHUNMJ36LchaizP+GzwQuzlF6x/75xllGQ3Fvmo= X-Google-Smtp-Source: AHgI3IYOm5Z8Q45dWPFTsQrldFSU8Om9u5gsKKvZa5R3oTd5YkN0mbHuf+04rsPzPSi96Y2lLv1NpOZp1W9AOwdlu5I= X-Received: by 2002:ab0:6151:: with SMTP id w17mr1466325uan.114.1549976419968; Tue, 12 Feb 2019 05:00:19 -0800 (PST) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 References: <20190211165934.9069-1-bradsoto@gmail.com> In-Reply-To: <20190211165934.9069-1-bradsoto@gmail.com> From: Leonardo Arena Date: Tue, 12 Feb 2019 14:00:08 +0100 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/firefox: upgrade to 65.0 To: Bradley Saulteaux Cc: alpine-aports Content-Type: multipart/alternative; boundary="000000000000ec2b870581b20133" --000000000000ec2b870581b20133 Content-Type: text/plain; charset="UTF-8" Hi, see few comments below. On Mon, Feb 11, 2019 at 5:56 PM Bradley Saulteaux wrote: > https://www.firefox.com/ > Firefox web browser > --- > .../firefox/0002-Use-C99-math-isfinite.patch | 17 ----- > testing/firefox/APKBUILD | 41 +++++----- > testing/firefox/disable-moz-stackwalk.patch | 10 +-- > testing/firefox/fix-arm-atomics-grsec.patch | 74 ++++++++----------- > testing/firefox/fix-arm-version-detect.patch | 13 ---- > testing/firefox/fix-seccomp-bpf.patch | 26 +++---- > testing/firefox/fix-stack-overflow.patch | 45 ----------- > testing/firefox/fix-toolkit.patch | 8 +- > testing/firefox/fix-tools.patch | 18 ++--- > testing/firefox/fix-webrtc-glibcisms.patch | 18 ++--- > testing/firefox/rust-unitialized-field.patch | 11 ++- > 11 files changed, 94 insertions(+), 187 deletions(-) > delete mode 100644 testing/firefox/0002-Use-C99-math-isfinite.patch > delete mode 100644 testing/firefox/fix-arm-version-detect.patch > delete mode 100644 testing/firefox/fix-stack-overflow.patch > > diff --git a/testing/firefox/0002-Use-C99-math-isfinite.patch > b/testing/firefox/0002-Use-C99-math-isfinite.patch > deleted file mode 100644 > index ba4f5cfb3d..0000000000 > --- a/testing/firefox/0002-Use-C99-math-isfinite.patch > +++ /dev/null > @@ -1,17 +0,0 @@ > ---- ./xpcom/ds/nsMathUtils.h.orig > -+++ ./xpcom/ds/nsMathUtils.h > -@@ -104,12 +104,12 @@ > - #ifdef WIN32 > - // NOTE: '!!' casts an int to bool without spamming MSVC warning C4800. > - return !!_finite(aNum); > --#elif defined(XP_DARWIN) > -+#elif defined(XP_DARWIN) || defined(_GLIBCXX_CMATH) > - // Darwin has deprecated |finite| and recommends |isfinite|. The > former is > - // not present in the iOS SDK. > - return std::isfinite(aNum); > - #else > -- return finite(aNum); > -+ return isfinite(aNum); > - #endif > - } > - > diff --git a/testing/firefox/APKBUILD b/testing/firefox/APKBUILD > index b31c1997b7..c53275e7b1 100644 > --- a/testing/firefox/APKBUILD > +++ b/testing/firefox/APKBUILD > @@ -1,7 +1,7 @@ > # Contributor: William Pitcock > # Maintainer: Natanael Copa > pkgname=firefox > -pkgver=62.0.3 > +pkgver=65.0 > _pkgver=$pkgver > _xulver=$pkgver > pkgrel=2 > @@ -11,6 +11,7 @@ url="https://www.firefox.com/" > arch="x86_64" > license="GPL LGPL MPL" > depends="" > +# icu-dev icu has been recently updated to 63.1. As I understand is needed by firefox 65. > > makedepends=" > alsa-lib-dev > autoconf2.13 > @@ -18,6 +19,7 @@ makedepends=" > bsd-compat-headers > bzip2-dev > cargo > + cbindgen > We don't have a package for it yet. Thanks! /eo --000000000000ec2b870581b20133 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

= see few comments below.

On Mon, Feb 11, 2019 at 5:56 PM Bradley Saulteau= x <bradsoto@gmail.com> wrot= e:
https://www.fi= refox.com/
Firefox web browser
---
=C2=A0.../firefox/0002-Use-C99-math-isfinite.patch=C2=A0 | 17 -----
=C2=A0testing/firefox/APKBUILD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 41 +++++-----
=C2=A0testing/firefox/disable-moz-stackwalk.patch=C2=A0 =C2=A0| 10 +--
=C2=A0testing/firefox/fix-arm-atomics-grsec.patch=C2=A0 =C2=A0| 74 ++++++++= -----------
=C2=A0testing/firefox/fix-arm-version-detect.patch=C2=A0 | 13 ----
=C2=A0testing/firefox/fix-seccomp-bpf.patch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 26 +++----
=C2=A0testing/firefox/fix-stack-overflow.patch=C2=A0 =C2=A0 =C2=A0 | 45 ---= --------
=C2=A0testing/firefox/fix-toolkit.patch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 8 +-
=C2=A0testing/firefox/fix-tools.patch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 18 ++---
=C2=A0testing/firefox/fix-webrtc-glibcisms.patch=C2=A0 =C2=A0 | 18 ++--- =C2=A0testing/firefox/rust-unitialized-field.patch=C2=A0 | 11 ++-
=C2=A011 files changed, 94 insertions(+), 187 deletions(-)
=C2=A0delete mode 100644 testing/firefox/0002-Use-C99-math-isfinite.patch =C2=A0delete mode 100644 testing/firefox/fix-arm-version-detect.patch
=C2=A0delete mode 100644 testing/firefox/fix-stack-overflow.patch

diff --git a/testing/firefox/0002-Use-C99-math-isfinite.patch b/testing/fir= efox/0002-Use-C99-math-isfinite.patch
deleted file mode 100644
index ba4f5cfb3d..0000000000
--- a/testing/firefox/0002-Use-C99-math-isfinite.patch
+++ /dev/null
@@ -1,17 +0,0 @@
---- ./xpcom/ds/nsMathUtils.h.orig
-+++ ./xpcom/ds/nsMathUtils.h
-@@ -104,12 +104,12 @@
- #ifdef WIN32
-=C2=A0 =C2=A0// NOTE: '!!' casts an int to bool without spamming M= SVC warning C4800.
-=C2=A0 =C2=A0return !!_finite(aNum);
--#elif defined(XP_DARWIN)
-+#elif defined(XP_DARWIN) || defined(_GLIBCXX_CMATH)
-=C2=A0 =C2=A0// Darwin has deprecated |finite| and recommends |isfinite|. = The former is
-=C2=A0 =C2=A0// not present in the iOS SDK.
-=C2=A0 =C2=A0return std::isfinite(aNum);
- #else
--=C2=A0 return finite(aNum);
-+=C2=A0 return isfinite(aNum);
- #endif
- }
-
diff --git a/testing/firefox/APKBUILD b/testing/firefox/APKBUILD
index b31c1997b7..c53275e7b1 100644
--- a/testing/firefox/APKBUILD
+++ b/testing/firefox/APKBUILD
@@ -1,7 +1,7 @@
=C2=A0# Contributor: William Pitcock <nenolod@dereferenced.org>
=C2=A0# Maintainer: Natanael Copa <ncopa@alpinelinux.org>
=C2=A0pkgname=3Dfirefox
-pkgver=3D62.0.3
+pkgver=3D65.0
=C2=A0_pkgver=3D$pkgver
=C2=A0_xulver=3D$pkgver
=C2=A0pkgrel=3D2
@@ -11,6 +11,7 @@ url=3D"https://www.firefox.com/"
=C2=A0arch=3D"x86_64"
=C2=A0license=3D"GPL LGPL MPL"
=C2=A0depends=3D""
+# icu-dev

icu has been recently updated to= 63.1. As I understand is needed by firefox 65.
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
=C2=A0makedepends=3D"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 alsa-lib-dev
=C2=A0 =C2=A0 =C2=A0 =C2=A0 autoconf2.13
@@ -18,6 +19,7 @@ makedepends=3D"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 bsd-compat-headers
=C2=A0 =C2=A0 =C2=A0 =C2=A0 bzip2-dev
=C2=A0 =C2=A0 =C2=A0 =C2=A0 cargo
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cbindgen

We= don't have a package for it yet.

Thanks!

/eo
--000000000000ec2b870581b20133-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---