X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua0-f181.google.com (mail-ua0-f181.google.com [209.85.217.181]) by lists.alpinelinux.org (Postfix) with ESMTP id D41665C53C5 for ; Fri, 20 Jul 2018 08:06:02 +0000 (GMT) Received: by mail-ua0-f181.google.com with SMTP id r18-v6so6928674ual.13 for ; Fri, 20 Jul 2018 01:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TL3SEbxL+lqNTBWma/lsMZVtcjopT+SHa1gacsspcjo=; b=ep3HyJXrfhKbQ1uLGkYDPsGiR3AiumXI5WKRxUmqk4Dd13OgzvStJrsrlVTNsMbZGw ia4QC4UvCJQaYwALOsMKB1SQjTE0OUJ0TDbOaGtgDYIBwyNkZdY7O0dNIGzLdERC82fC VTTiyEvVkfMUCQL6YMkBKbVr0lSZ03agvcjuMd5RwqrS0hSsmLF1W/UVD1ty9qkV36Sj gwN//A0fE6HUmXVsdyuhg7zD0+7SQsw9sZEF80eleOZzRNGMew3TE65FYV6zZuKIPn4f amDBX1SLBNZkZPDQn1XZX+v007HphPBbTcgECVKO2ezm43SqLZ9HgOEC1HKpTZ/X1syh 3RGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TL3SEbxL+lqNTBWma/lsMZVtcjopT+SHa1gacsspcjo=; b=d+BSdw+PJ1JOGh6UgdfPUSMa3akHS1mlczjPm4o4HDKpemMZjiEEKqx/4Xv3VLTx49 yVXcabSc++1Dw13OeTClpphRlVK0c7KxlP7AwyKhIuv2t6UP9+d+1AsXkQFNk+iTQdzh nIs0p2Pl81GTzRg3MvZxEkFc8fyXbNelJ6DkmbIUZSxHVkGwrrbEeh1wPf0afscxxH5Q /GFoZ7k9KZgD3b6NsZTcaIJgvR2RpuwUXCHkbaxH3eJoyiP8Kf3LkR9RbTsOyvglYIhw tlhfAhlzVMrdewBi/SP5iYzFZHnO0jF8mBbBfcZBYQs0yKJXawjcTrKjz6P2hPbEr3wI bAFQ== X-Gm-Message-State: AOUpUlGFiUvKvq9hSd7CuD26h/SH+9vhwQOnNDCI7H8YBQXBf4RPhyFc e79bahlLZq+BGu/6R/fuNEcDJnzvjJB6+5URrpg4lDZxKqo= X-Google-Smtp-Source: AAOMgpdkn1uHW1sQQHv8k00FryOn71KvuDGsl+osrtk/va4BKbNNpo9OjyC9VV9Km6dmahtnzjWHEHT6hoHTWy6LQSg= X-Received: by 2002:ab0:512d:: with SMTP id e42-v6mr573522uaa.183.1532073962376; Fri, 20 Jul 2018 01:06:02 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 2002:a9f:3223:0:0:0:0:0 with HTTP; Fri, 20 Jul 2018 01:06:01 -0700 (PDT) In-Reply-To: <20180701135522.20390-4-marian.buschsieweke@ovgu.de> References: <20180701135522.20390-1-marian.buschsieweke@ovgu.de> <20180701135522.20390-4-marian.buschsieweke@ovgu.de> From: Leonardo Arena Date: Fri, 20 Jul 2018 10:06:01 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH 4/5] testing/py-axolotl: New aport To: Marian Buschsieweke Cc: alpine-aports Content-Type: multipart/alternative; boundary="0000000000004c1408057169c4c0" --0000000000004c1408057169c4c0 Content-Type: text/plain; charset="UTF-8" Hi, please see few comments below. On Sun, Jul 1, 2018 at 3:55 PM, Marian Buschsieweke < marian.buschsieweke@ovgu.de> wrote: > https://github.com/tgalal/python-axolotl > Python port of libsignal-protocol-java > --- > testing/py-axolotl/APKBUILD | 51 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 testing/py-axolotl/APKBUILD > > diff --git a/testing/py-axolotl/APKBUILD b/testing/py-axolotl/APKBUILD > new file mode 100644 > index 0000000000..fe9e416195 > --- /dev/null > +++ b/testing/py-axolotl/APKBUILD > @@ -0,0 +1,51 @@ > +# Maintainer: Marian Buschsieweke > +pkgname=py-axolotl > +_pkgname="python-${pkgname#py-}" > +pkgver=0.1.42 > +pkgrel=0 > +pkgdesc="Python port of libsignal-protocol-java" > +url="https://github.com/tgalal/python-axolotl" > +arch="noarch" > +license="GPL3" > Please replace it with "GPL-3.0-only" Please add the dependencies here instead of adding them into the subpbackages. depends="py-crypto py-protobuf py-axolotl-curve25519" +makedepends="py-setuptools python2-dev python3-dev" > +subpackages="py2-${pkgname#py-}:_py2 py3-${pkgname#py-}:_py3" > +source="$pkgname-$pkgver.tar.gz::https://github.com/tgalal/ > $_pkgname/archive/$pkgver.tar.gz" > +builddir="$srcdir"/$_pkgname-$pkgver > + > +build() { > + cd "$builddir" > + python2 setup.py build > + python3 setup.py build > +} > + > +check() { > + cd "$builddir" > + python3 setup.py test > Python 2 tests are missing. > +} > + > +package() { > + mkdir -p "$pkgdir" > +} > + > +_py2() { > + depends="py2-crypto py2-protobuf py2-axolotl-curve25519" > Please do a variable substitution here instead. This is the approach used for all the other python packages: depends="${depends//py-/py2-}" > + replaces="$pkgname" > This should not be needed. > + _py python2 > +} > + > +_py3() { > + depends="py3-crypto py3-protobuf py3-axolotl-curve25519" > See comment above. Thanks! /eo --0000000000004c1408057169c4c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

please see few comments = below.

O= n Sun, Jul 1, 2018 at 3:55 PM, Marian Buschsieweke <marian.busch= sieweke@ovgu.de> wrote:
https://github.com/tgalal/python-axolot= l
Python port of libsignal-protocol-java
---
=C2=A0testing/py-axolotl/APKBUILD | 51 +++++++++++++++++++++++++++++++= ++++++
=C2=A01 file changed, 51 insertions(+)
=C2=A0create mode 100644 testing/py-axolotl/APKBUILD

diff --git a/testing/py-axolotl/APKBUILD b/testing/py-axolotl/APKBUILD
new file mode 100644
index 0000000000..fe9e416195
--- /dev/null
+++ b/testing/py-axolotl/APKBUILD
@@ -0,0 +1,51 @@
+# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
+pkgname=3Dpy-axolotl
+_pkgname=3D"python-${pkgname#py-}"
+pkgver=3D0.1.42
+pkgrel=3D0
+pkgdesc=3D"Python port of libsignal-protocol-java"
+url=3D"https://github.com/tgalal/python-axolotl"
+arch=3D"noarch"
+license=3D"GPL3"


<= div>Please replace it with "GPL-3.0-only"

Please add the dependencies here instead of adding them into the subpback= ages.


+makedepends=3D"py-setuptools python2-dev python3-dev"
+subpackages=3D"py2-${pkgname#py-}:_py2 py3-${pkgname#py-}:_py3&q= uot;
+source=3D"$pkgname-$pkgver.tar.gz::https://github.com/tgalal/$_pkgname/archive/$pkgver.tar.gz"
+builddir=3D"$srcdir"/$_pkgname-$pkgver
+
+build() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0python2 setup.py build
+=C2=A0 =C2=A0 =C2=A0 =C2=A0python3 setup.py build
+}
+
+check() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0python3 setup.py test

+=C2=A0 =C2=A0 =C2=A0 =C2=A0_py python2
+}
+
+_py3() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0depends=3D"py3-crypto py3-protobuf py3-axo= lotl-curve25519"



Thanks!=

/eo
--0000000000004c1408057169c4c0-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---