X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua0-f173.google.com (mail-ua0-f173.google.com [209.85.217.173]) by lists.alpinelinux.org (Postfix) with ESMTP id 843A45C5019 for ; Wed, 30 May 2018 13:35:05 +0000 (GMT) Received: by mail-ua0-f173.google.com with SMTP id y8-v6so12476606ual.5 for ; Wed, 30 May 2018 06:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ejXtO92vLyqar7PvQFWAKUWIYXMy9QKFSRixC/Zg6U0=; b=WnqHVkQoS9TZ/ZcPEKmnHoRS0dAeo+vk9ykVO2Z47z3Tu8sDtdD5H6gWgYpg+71JnN TvcUoMJX5M6rimazbIshryPP+I+Rn1ZVc0E6vbEFXdSbwaaI1UOPXvpD9ZQs1oZt5pMT sBhiiZB7zSa35d0iQ6j1UPXxdv1qSB/M0pTa3R7kp+B6Tj7QWaJpIMpfxnrpfkuLkHex iQG5766MqS+Qkyzj29Xd8l6rIovhfPhGg9lteOVnPf0kfyoUbEYHK+CoOMn4nGVFvpLU l1b6ZqgBfG6SaH5iUjvH5nrs97wFPa2F3MRu5XXE2gK0XxXV3NgWb5iKFWnZ/x6b+htu okdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ejXtO92vLyqar7PvQFWAKUWIYXMy9QKFSRixC/Zg6U0=; b=l5Zf5SjXdCvffa5TYXBrBqDiFgdVQFWjifIXREsYCVQgM5ldKAyj5XIhg4b8Lgd2Rm 3tBJ/rXQ+EEpqtvjkrp9Q/MyOmknBHw4LkPb/9e0aEokuySSu5nTZkellpbhTmWLaOE1 eXb5n01SoZxfcZbydGwdKwizd6ygFAG8e1oeS+TcW6UilijcThBiA+O2M8WSAgEUY+w+ UDmhkbsu6mKHnKQkyZjaVCGcZAi5yEY3EJCnXl9Hfuv7HtwAeWm6HLTg5EoGAIM2MJiQ wAJOAxbuNLya3Kl/FCod7yFwVXJo5upgC1bKCJi0HG+EpNsGqpKcrQOD6b8R83Mjp1yA Du1w== X-Gm-Message-State: ALKqPwdowd1rdoK736lxvwL+vp+a48t0Fra1ABCZ7Cc68qwwAeKVTvKT tJ+mWW02zYhc0HpnHf0trcSehR/owb4XRIu5X9E= X-Google-Smtp-Source: ADUXVKLD6/9GJMWGYPBCtnNj3EBhzyg1l8Fjj7+zGxJPZnsNmGqJyAhVmjoa7rvnngNe5cIc/aqcTJUFs2jRaDofJOU= X-Received: by 2002:ab0:18ee:: with SMTP id d46-v6mr1699159uah.39.1527687304491; Wed, 30 May 2018 06:35:04 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 2002:ab0:5507:0:0:0:0:0 with HTTP; Wed, 30 May 2018 06:35:04 -0700 (PDT) In-Reply-To: <20180502145222.5059-1-marian.buschsieweke@ovgu.de> References: <20180502145222.5059-1-marian.buschsieweke@ovgu.de> From: Leonardo Arena Date: Wed, 30 May 2018 15:35:04 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/pygal: New aport To: Marian Buschsieweke Cc: alpine-aports Content-Type: multipart/alternative; boundary="0000000000001cb69f056d6c6b22" --0000000000001cb69f056d6c6b22 Content-Type: text/plain; charset="UTF-8" Hi, please see some comments below. On Wed, May 2, 2018 at 4:52 PM, Marian Buschsieweke < marian.buschsieweke@ovgu.de> wrote: > pygal is a dynamic SVG charting library written in python > https://pygal.org > --- > testing/pygal/APKBUILD | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 testing/pygal/APKBUILD > > diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD > new file mode 100644 > index 0000000000..e459f22ec6 > --- /dev/null > +++ b/testing/pygal/APKBUILD > @@ -0,0 +1,42 @@ > +# Maintainer: Marian Buschsieweke > +pkgname=pygal > I think we should call it "py-gal" regardless of the actual upstream name, for the sake of naming consistency of all pyhon packages. > +pkgver=2.4.0 > +pkgrel=0 > +pkgdesc="pygal is a dynamic SVG charting library written in python" > +url="https://pygal.org" > +arch="noarch" > +license="LGPL3" > +makedepends="python2-dev python3-dev py-setuptools" > +subpackages="py2-${pkgname}:_py2 py3-${pkgname}:_py3" > +source="https://files.pythonhosted.org/packages/source/${pkgname:0:1}/$ > pkgname/$pkgname-$pkgver.tar.gz" > +builddir="$srcdir"/$pkgname-$pkgver > + > +build() { > + cd "$builddir" > + python2 setup.py build || return 1 > + python3 setup.py build || return 1 > +} > + > "|| return 1" can be omitted Thanks! /eo --0000000000001cb69f056d6c6b22 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

please see some comments below.
<= div class=3D"gmail_extra">
On Wed, May 2, 201= 8 at 4:52 PM, Marian Buschsieweke <marian.buschsieweke@ovgu.de> wrote:
pygal is a dynamic S= VG charting library written in python
https://= pygal.org
---
=C2=A0testing/pygal/APKBUILD | 42 ++++++++++++++++++++++++++++++++++++= ++++++
=C2=A01 file changed, 42 insertions(+)
=C2=A0create mode 100644 testing/pygal/APKBUILD

diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD
new file mode 100644
index 0000000000..e459f22ec6
--- /dev/null
+++ b/testing/pygal/APKBUILD
@@ -0,0 +1,42 @@
+# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
+pkgname=3Dpygal


I think we should = call it "py-gal" regardless of the actual upstream name, for the = sake of naming consistency of all pyhon packages.

=C2=A0<= /div>
+pkgver=3D2.4.0
+pkgrel=3D0
+pkgdesc=3D"pygal is a dynamic SVG charting library written in python&= quot;
+url=3D"https://pygal.org"
+arch=3D"noarch"
+license=3D"LGPL3"
+makedepends=3D"python2-dev python3-dev py-setuptools"
+subpackages=3D"py2-${pkgname}:_py2 py3-${pkgname}:_py3"
+source=3D"https://files.pythonhosted.org/packages/source/${pkgn= ame:0:1}/$pkgname/$pkgname-$pkgver.tar.gz"
+builddir=3D"$srcdir"/$pkgname-$pkgver
+
+build() {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0cd "$builddir"
+=C2=A0 =C2=A0 =C2=A0 =C2=A0python2 setup.py build || return 1
+=C2=A0 =C2=A0 =C2=A0 =C2=A0python3 setup.py build || return 1
+}
+


"|| return 1" can be om= itted


Thanks!
=C2=A0
/eo
--0000000000001cb69f056d6c6b22-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---