X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by lists.alpinelinux.org (Postfix) with ESMTP id 3E8D1F856A6 for ; Wed, 2 Jan 2019 15:13:45 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id x64so19027644vsa.5 for ; Wed, 02 Jan 2019 07:13:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iZ00J3WFrwcP3Z9Yywh6ZEXxVwMOK+xA02XTHI92lbA=; b=oMQoFc4w2uQIBXqD8Cwz7LHTCoeKrJNzJAxux7/AhUMXzzfFtRGMlTLTdoNnjsNCXa zS9rdZJ7g/AVCpytZPoZ4AYQA+7fLwZDCPRQPQsDvaFGdoFtYiA1AQdZ7uITA1mneGow lRQ34ymIjF4WC9AhqzMxXJuSR6Lt26l1GRsxWeVwJPKaFRVKav8goD5TcOTmgU3XSLXQ 4Ep9bDD6MbJBuc+BX5rWR2S9xhh44zsLZ1OMqXhJYy9bnznvGOm63w1Hhy4OTDDo9V0g 450365hhQ4TAhDcdB9Gq99VDXGH3gNXUQsV+Oe4xGVXQizajQWyAnImyptfaTPWZY2ib cFTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iZ00J3WFrwcP3Z9Yywh6ZEXxVwMOK+xA02XTHI92lbA=; b=Jpi57qPvKOXUpwc4ifsnzZonkBqcNHULNrp+pliDvGBE983I0dmrpvcxJ96MdjP8yO LfQJBODZCFbLXqchjPXDPKYaT20SVN+3C6qU33u7+tCDvZqnRegT1SkiIK07pIxER3Jp /cJyzC4sq310BVWLk9zDxbpO06ckxGflDTpqRYOK8fth9L7m5Eb+ABSI4M89zd38GzUs cAWXLyhCsQgNXR2JhdNxalcaj7e51Y7JTDwZUeslYARehron9hnz3c7JCgCQg9+lzFGI ZxxgCPICvBp0PaDoh1duxoCHsWpZEX5Bb5La1XaZIyIQq13dtk+DWp5vrOiMPlpUled4 W2Vw== X-Gm-Message-State: AJcUukeWc8LOlX+vuJTKj/UfeYEucNfubXBiYK7jdkJ9X9IWJjnllRpM L/va6XhM1wdcfdGEGqVq1TQphziheXZU23vk70w= X-Google-Smtp-Source: ALg8bN64G71aOhIG5TYozmgnN16Qnqjggr2ISEv0CmmWGaznqa9N6cs70qwKGA3IPaNOupOWSI2O6TtcyqAGif5sHB0= X-Received: by 2002:a67:f896:: with SMTP id h22mr13583055vso.29.1546442024144; Wed, 02 Jan 2019 07:13:44 -0800 (PST) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 References: <20181230111722.21006-1-martin.rusko@gmail.com> In-Reply-To: From: Leonardo Arena Date: Wed, 2 Jan 2019 16:13:32 +0100 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/minidyndns: new aport To: Martin Rusko Cc: alpine-aports Content-Type: multipart/alternative; boundary="00000000000083d5cc057e7b177c" --00000000000083d5cc057e7b177c Content-Type: text/plain; charset="UTF-8" Hi, sorry for the late reply. On Mon, Dec 31, 2018 at 3:49 PM Martin Rusko wrote: > Many thanks for your comments. I will update it accordingly. I will > send it again as new patch. There is just one thing I'm not certain > about, see below. > > On Mon, Dec 31, 2018 at 12:18 PM Leonardo Arena wrote: > >> > >> diff --git a/testing/minidyndns/minidyndns.confd > b/testing/minidyndns/minidyndns.confd > >> new file mode 100644 > >> index 0000000000..3cf5d10be2 > >> --- /dev/null > >> +++ b/testing/minidyndns/minidyndns.confd > >> @@ -0,0 +1,5 @@ > >> +# > >> +# Specify daemon options here. > >> +# > >> + > >> +minidyndns_opts="--config /etc/minidyndns_config.yml --db > /var/lib/minidyndns/db.yml" > > > > > > > > Since these are default values, may be you can add those to the init > script itself and leave the conf file for customizations. > > > > : ${minidyndns_opts:="--config /etc/minidyndns_config.yml --db > /var/lib/minidyndns/db.yml"} > > > Will I not stand in a way of someone who will want to change the > location of these files? The administrator will need to edit both the > file in conf.d and the one init.d script as well. I feel it's better > to keep these options defined in conf.d file. If I'm overthinking it, > just say so and I will move them to init.d script. > > My suggestion above does hardcode the location of the configuration files. If $minidyndns_opts is not set in conf.d/minidyndns, it sets the values to those specified into init.d/minidyndns_opts. The administrator does not need to touch the init.d at all to move the configuration files somewhere else. Thanks! /eo --00000000000083d5cc057e7b177c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

sorry for the late reply= .

On Mon, Dec 31, 2018= at 3:49 PM Martin Rusko <mart= in.rusko@gmail.com> wrote:
Many thanks for your comments. I will update it according= ly. I will
send it again as new patch. There is just one thing I'm not certain
about, see below.

On Mon, Dec 31, 2018 at 12:18 PM Leonardo Arena <rnalrd@gmail.com> wrote:
>>
>> diff --git a/testing/minidyndns/minidyndns.confd b/testing/minidyn= dns/minidyndns.confd
>> new file mode 100644
>> index 0000000000..3cf5d10be2
>> --- /dev/null
>> +++ b/testing/minidyndns/minidyndns.confd
>> @@ -0,0 +1,5 @@
>> +#
>> +# Specify daemon options here.
>> +#
>> +
>> +minidyndns_opts=3D"--config /etc/minidyndns_config.yml --db = /var/lib/minidyndns/db.yml"
>
>
>
> Since these are default values, may be you can add those to the init s= cript itself and leave the conf file for customizations.
>
> : ${minidyndns_opts:=3D"--config /etc/minidyndns_config.yml --db = /var/lib/minidyndns/db.yml"}
>
Will I not stand in a way of someone who will want to change the
location of these files? The administrator will need to edit both the
file in conf.d and the one init.d script as well. I feel it's better to keep these options defined in conf.d file. If I'm overthinking it, just say so and I will move them to init.d script.


My suggestion above does hardcode the = location of the configuration files. If $minidyndns_opts is not set in conf= .d/minidyndns, it sets the values to those specified into init.d/minidyndns= _opts.
The administrator does not need to touch the init.d at all= to move the configuration files somewhere else.

T= hanks!

/eo

--00000000000083d5cc057e7b177c-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---