X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id 17B64DC101D for ; Sun, 21 Feb 2016 23:46:04 +0000 (UTC) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id F12A2DC0D2A for ; Sun, 21 Feb 2016 23:46:02 +0000 (UTC) Received: by mail-lf0-f51.google.com with SMTP id j78so83648143lfb.1 for ; Sun, 21 Feb 2016 15:46:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=OB2oqkyVu2gAxfpmeBCQirBz7eBYWqqJSxv6ni40sC4=; b=Stc09JF28oo+aYxo3mNXSkBGux2pO+L0Odp4rbTC1CrSpFTtS8vA4ThF2HZjp5k9cm 800jvqSB4I6Edcg7/lXzRxx1qNurrjFhOWFD+JF7fyzuS/ALXtIxue/RNnpQbsof/8rX UbdIYVvp87kOGZZEOoru5pJFqLm9ksWjDPG1C+HS4Qh0LUq4cnIGnM7rgrmLhA7+Ndya 35m1oj6LxJo3aT7xo/f+NYi3AYIVnFHuu7uD1aKeywlsazo5CpLUiF+NgNARq5y9/PrD ITzvJutTCjkmnVJR6HUYRpxlz3cne+wMBX882av69WRrtKex4eFaKSNPt8abvCkotEHj T1Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=OB2oqkyVu2gAxfpmeBCQirBz7eBYWqqJSxv6ni40sC4=; b=KHPEFQdIff2YsBYyr7EzZu0bySnTusw2frfYuNm5KZfyepjMBQ2T7DZFwwue4zKJ4j f5ytWa+CpAAHMsE+Xhdl7YMqvd+Mk+pnKpNT3R8v3RO4uUZQPOdfgRT2WURiKnAl/flj TwEBLewWloxnXJrKScA28haJ8qKYoRXBTYCJ6xoubLKCkQnD2x0zPeu5LdrBCa2T73wy O+ql6yqjLnEMNLKNyUYb0riYNA4s07c3n29pT8sfXV2lkwIh36cdOeG2e1t1JghDLJ2X BYxDgxYtbG6ymTOW0NYBAXYnIUj6ULANdLJ/y3CgLeaZFLeAp/CtTpbOqLV42NkwsTfs S3ug== X-Gm-Message-State: AG10YOQmol/lHr7Re6iXYe5S1Iu2tDXC/Zwp0BTV0aYSM4s8fcKdPD6PL0uAxssAkIAt55N7ImUn/bnH2ZXuBQ== X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 X-Received: by 10.25.205.7 with SMTP id d7mr9248300lfg.70.1456098358463; Sun, 21 Feb 2016 15:45:58 -0800 (PST) Received: by 10.25.196.1 with HTTP; Sun, 21 Feb 2016 15:45:58 -0800 (PST) In-Reply-To: <20160220110226.11b7a343@ncopa-desktop.alpinelinux.org> References: <1449704654-5599-1-git-send-email-valery.kartel@gmail.com> <20160220110226.11b7a343@ncopa-desktop.alpinelinux.org> Date: Mon, 22 Feb 2016 01:45:58 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] main/dovecot: split some plugins to subpackages From: Valery Kartel To: Natanael Copa Cc: alpine-aports@lists.alpinelinux.org Content-Type: multipart/alternative; boundary=001a1142091a6a14b5052c5051a3 X-Virus-Scanned: ClamAV using ClamSMTP --001a1142091a6a14b5052c5051a3 Content-Type: text/plain; charset=UTF-8 2016-02-20 12:02 GMT+02:00 Natanael Copa : > On Thu, 10 Dec 2015 01:44:14 +0200 > Valery Kartel wrote: > > > -acl: plugin for acl-s with related configs > > -quota: quota plugin with related configs > > -trash: trash for quota plugin with related configs. has dovecot-quota > as dependency > > -stats: Statistics plugin with related configs > > -zlib: maildir compression plugin with related configs > > > > -expire: message expire plugin with no configs > > -snarf: move mails from a "snarf mailbox" to user's real INBOX plugin > with no configs > > -listescape: Listescape plugin with no configs > > -mail-filter: mail filter plugin with no configs > > -fts: full text search plugin with no configs > > Hi sorry for late response on this patch. It didn't work and I have not > had so much extrea time lately. > Hi, This patch has not been claimed for a long time and I forgot about it for a while. > + $pkgname-trash $pkgname-zlib $pkgname-stats $pkgname-expire > + $pkgname-mail-filter:filter $pkgname-listescape $pkgname-snarf > + $pkgname-fts" > " You have an extra " in there. Abuild will not even parse this APKBUILDm > which means that you have not tested if it even builds. > > I check it twice and found that I was not sent it from the main folder with 'ready to go' patches but from a testing one where I constantly change something. It's really my mistake. ... > > > diff --git a/main/dovecot/dovecot-trash.conf.ext > b/main/dovecot/dovecot-trash.conf.ext > > new file mode 100644 > > index 0000000..4689935 > > --- /dev/null > > +++ b/main/dovecot/dovecot-trash.conf.ext > > @@ -0,0 +1,8 @@ > > +# Spam mailbox is emptied before Trash > > +1 Spam > > +# Trash mailbox is emptied before Sent > > +2 Trash > > +# If both Sent and "Sent Messages" mailboxes exist, the next oldest > message > > +# to be deleted is looked up from both of the mailboxes. > > +3 Sent > > +3 Sent Messages > > I know for sure that you didn't even try build the APKBUILD. What > should I think about the config changes? I wonder if you tested it or > not. > My criteria for sending the changes, it is at least a successful compilation . > > > diff --git a/main/dovecot/dovecot.initd b/main/dovecot/dovecot.initd > > index 880a39f..ca6852f 100644 > > --- a/main/dovecot/dovecot.initd > > +++ b/main/dovecot/dovecot.initd > > @@ -31,8 +31,7 @@ checkconfig() { > > fi > > DOVECOT_BASEDIR=${DOVECOT_BASEDIR:-/run/dovecot} > > DOVECOT_PIDFILE=${DOVECOT_BASEDIR}/master.pid > > - checkpath --directory --owner dovecot:dovecot --mode 0755 \ > > - ${DOVECOT_BASEDIR} > > + checkpath --directory ${DOVECOT_BASEDIR} > > } > > The commit message give no hint on why this change was necessary or > that it actually happened. If I would have just applied it (and if it > would have compiled) and I would have pushed it, the I would have been > pushing code changes that I was not aware of had happened. > It's a last minute change and as I wrote before - it's a testing variant and was not supposed to be sent. But this change I can describe: We have a world-readable directory and the master process runs from root. So it's a kind of overhead to change owner and mode for /run/dovecot. All runtime sockets are created with owner of child process and their permissions are setted-up in configs. So, I just remove unnecessary startup overhead. What do you think about sneaking in changes like this? Will my trust > improve or decrease? > > What will I think when I see future patches? > It's my fault, and I acknowledge it, so you decide. > I think the general idea is good, splitting up dovecot plugins in > subpackages is good. Shipping a working config is good too. > > But I cannot commit this. > > Sorry. > > Never mind. In any case I'll remade it and send new version, because this one has long been obsolete. > -nc > -vaka --001a1142091a6a14b5052c5051a3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2016= -02-20 12:02 GMT+02:00 Natanael Copa <ncopa@alpinelinux.org>:
On Thu, 10 Dec 2015 01:44:14 +0200
Valery Kartel <valery.kartel@= gmail.com> wrote:

> -acl: plugin for acl-s with related configs
> -quota: quota plugin with related configs
> -trash: trash for quota plugin with related configs. has dovecot-quota= as dependency
> -stats: Statistics plugin with related configs
> -zlib: maildir compression plugin with related configs
>
> -expire: message expire plugin with no configs
> -snarf: move mails from a "snarf mailbox" to user's real= INBOX plugin with no configs
> -listescape: Listescape plugin with no configs
> -mail-filter: mail filter plugin with no configs
> -fts: full text search plugin with no configs

Hi sorry for late response on this patch. It didn't work and I h= ave not
had so much extrea time lately.

= Hi,
This= patch has not been claimed for a long time and I forgot about it for a while.

=C2=A0> +=C2=A0 =C2=A0 =C2=A0$pkgname-trash $pkgname-= zlib $pkgname-stats $pkgname-expire
> +=C2=A0 =C2=A0 =C2=A0$pkgname-mail-filter:filter $pkgname-listescape $= pkgname-snarf
> +=C2=A0 =C2=A0 =C2=A0$pkgname-fts"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0"


You have an extra &= quot; in there. Abuild will not even parse this APKBUILDm
which means that you have not tested if it even builds.

I check it twice and found that I was not sent it from the main folder with 'ready to go' patches but from= a testing one where I constantly<= /span> change something.
It's really = my mistake.
...

> diff --git a/main/dovecot/dovecot-trash.conf.ext b/main/dovecot/doveco= t-trash.conf.ext
> new file mode 100644
> index 0000000..4689935
> --- /dev/null
> +++ b/main/dovecot/dovecot-trash.conf.ext
> @@ -0,0 +1,8 @@
> +# Spam mailbox is emptied before Trash
> +1 Spam
> +# Trash mailbox is emptied before Sent
> +2 Trash
> +# If both Sent and "Sent Messages" mailboxes exist, the nex= t oldest message
> +# to be deleted is looked up from both of the mailboxes.
> +3 Sent
> +3 Sent Messages

I know for sure that you didn't even try build the APKBUILD. Wha= t
should I think about the config changes? I wonder if you tested it or
not.

My criteria for sending <= span class=3D"">the changes, it is at = least a successful compilat= ion.

> diff --git a/main/dovecot/dovecot.initd b/main/dovecot/dovecot.initd > index 880a39f..ca6852f 100644
> --- a/main/dovecot/dovecot.initd
> +++ b/main/dovecot/dovecot.initd
> @@ -31,8 +31,7 @@ checkconfig() {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0fi
>=C2=A0 =C2=A0 =C2=A0 =C2=A0DOVECOT_BASEDIR=3D${DOVECOT_BASEDIR:-/run/do= vecot}
>=C2=A0 =C2=A0 =C2=A0 =C2=A0DOVECOT_PIDFILE=3D${DOVECOT_BASEDIR}/master.= pid
> -=C2=A0 =C2=A0 =C2=A0checkpath --directory --owner dovecot:dovecot --m= ode 0755 \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0${DOVECOT_BASEDIR} > +=C2=A0 =C2=A0 =C2=A0checkpath --directory ${DOVECOT_BASEDIR}
>=C2=A0 }

The commit message give no hint on why this change was necessary or<= br> that it actually happened. If I would have just applied it (and if it
would have compiled) and I would have pushed it, the I would have been
pushing code changes that I was not aware of had happened.
=C2=A0
It's a last minute change and as I wrote before= - it's a testing variant and was not supposed to be sent.

But= this change I can describe: We have a world-readable directory and the mas= ter process runs from root. So it's a kind of overhead to change owner = and mode for /run/dovecot. All runtime sockets are created with owner of ch= ild process and their permissions are setted-up in configs.
So, I just remove unnecessary startup overhead.

What do you think about sneaking in changes like this? Will my trust
improve or decrease?

What will I think when I see future patches?

It's my faul= t, and I ackno= wledge it, so = you decide.
=C2=A0
I think the general idea is good, splitting up dovecot plugins in
subpackages is good. Shipping a working config is good too.

But I cannot commit this.

Sorry.

Never mind. In any case I'll remade it and send new version= , because this one has long been obsolete.
=C2=A0
-nc

-vaka=
--001a1142091a6a14b5052c5051a3-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---