X-Original-To: alpine-aports@mail.alpinelinux.org Delivered-To: alpine-aports@mail.alpinelinux.org Received: from mail.alpinelinux.org (dallas-a1.alpinelinux.org [127.0.0.1]) by mail.alpinelinux.org (Postfix) with ESMTP id E935EDC0EC2 for ; Tue, 15 Dec 2015 11:05:35 +0000 (UTC) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mail.alpinelinux.org (Postfix) with ESMTPS id 74C1FDC0160 for ; Tue, 15 Dec 2015 11:05:34 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id p66so85266643wmp.0 for ; Tue, 15 Dec 2015 03:05:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=n6Gclf77Ji0c6ZRIRmg6+tQUFMQDB5LOazMrMXUwfi0=; b=Z26iofx9CQECIJI7Qa6u9vo2y5xCIBTGy4v4f+ytuhn4bjDdwZ87Qvx+QWZemagyoO 7jPi3sgBE8EJeNn3aZxm/A15EYC/m4b2iRIcDsk+G11Z3TQIYrbxHyXv2Tao4PLJ73ZG hKWaIZzsb6RACWAGO/+IKyw+PHe85j7Okl8z16tcVuPVyhf8CW7bOEYpnHTPXFtnEh4N b9DnBZavLQRHzpfH25Q1lkWOL6AfcsgktWce7IPDQjJFvK1YiWH8KFM58uJ5Os9zrNWv Tf6QoZFUS+W5r6okvcMy79h3z35lor7HOrrOmMh3fNM4BsP3TITkSPXi9ax/CQzmAdHw TYdw== X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 X-Received: by 10.194.24.226 with SMTP id x2mr42798135wjf.43.1450177533077; Tue, 15 Dec 2015 03:05:33 -0800 (PST) Received: by 10.28.90.132 with HTTP; Tue, 15 Dec 2015 03:05:33 -0800 (PST) In-Reply-To: <20151215093418.1e11d4fe@ncopa-desktop.alpinelinux.org> References: <1445213109-6697-1-git-send-email-valery.kartel@gmail.com> <20151215093418.1e11d4fe@ncopa-desktop.alpinelinux.org> Date: Tue, 15 Dec 2015 13:05:33 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] main/mariadb: upgrade to stable 10.1.8 From: Valery Kartel To: Natanael Copa Cc: alpine-aports@lists.alpinelinux.org Content-Type: multipart/alternative; boundary=047d7b45066eb875ac0526edc45b X-Virus-Scanned: ClamAV using ClamSMTP --047d7b45066eb875ac0526edc45b Content-Type: text/plain; charset=UTF-8 Hi, Don't know why I do that. Maybe because I use mysql on loopback interface only and if I need to make it visible outide, I wrote DNAT iptables rule. So in my case it doesn't need firewall or dns. And you are right. In general purpose it uses dns and must be started after firewall. It was a mistake to implement my own IMHO to init-script. 2015-12-15 10:34 GMT+02:00 Natanael Copa : > Valery, > > I have a question on a change that was not clearly explained in the > commit message. > > On Mon, 19 Oct 2015 03:05:09 +0300 > Valery Kartel wrote: > > > --- > > main/mariadb/APKBUILD | 19 +++++++------- > > main/mariadb/mariadb.initd | 63 > +++++++++++++--------------------------------- > > 2 files changed, 27 insertions(+), 55 deletions(-) > > > > diff --git a/main/mariadb/APKBUILD b/main/mariadb/APKBUILD > > index 67c6239..7015b78 100644 > > --- a/main/mariadb/APKBUILD > > +++ b/main/mariadb/APKBUILD > > @@ -3,8 +3,8 @@ > > # Maintainer: Natanael Copa > > > > pkgname=mariadb > > -pkgver=10.0.21 > > -pkgrel=2 > > +pkgver=10.1.8 > > +pkgrel=0 > > pkgdesc="A fast SQL database server" > > url="http://www.mariadb.org" > > pkgusers="mysql" > > ... > > > diff --git a/main/mariadb/mariadb.initd b/main/mariadb/mariadb.initd > > index 8409bad..cb2a388 100644 > > --- a/main/mariadb/mariadb.initd > > +++ b/main/mariadb/mariadb.initd > > @@ -1,15 +1,19 @@ > > #!/sbin/openrc-run > > -# Copyright 1999-2004 Gentoo Foundation > > -# Distributed under the terms of the GNU General Public License v2 > > -# $Header: /var/cvsroot/gentoo-x86/dev-db/mysql/files/mysql.init,v 1.7 > 2004/07/14 21:41:15 agriffis Exp $ > > > > +getconf() { > > + v=$(my_print_defaults --mysqld | grep ^--$1) > > + [ -z $v ] && echo $2 || echo ${v#*=} > > +} > > + > > +retry="60" > > +pidfile=$(getconf pid-file "/run/mysqld/mysqld.pid") > > extra_stopped_commands="setup" > > -pidfile=/var/run/mysqld/mysqld.pid > > +command="/usr/bin/mysqld_safe" > > +command_args="--pid-file=$pidfile --syslog --nowatch" > > > > depend() { > > - need net > > - after firewall > > - use dns > > + use net > > + need localmount > > } > > Why do we accept that mariadb may be started before the firewall? Isn't > that a potensial risk? What was the reason for this change? > > Why do we remove the 'use dns'? Did it create problems? Did you > investigate why it was added in first place? > > -nc > --047d7b45066eb875ac0526edc45b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Don't know why I do that. M= aybe because I use mysql on loopback interface only and if I need to make i= t visible outide, I wrote DNAT iptables rule. So in my case it doesn't = need firewall or dns.
And you are right. In general purpose it us= es dns and must be started after firewall.

It was a mistake to imple= ment my own IMHO to init-script.


2015-12-15 10:34 GMT+02:00 Natanael= Copa <ncopa@alpinelinux.org>:
Valery,

I have a question on a change that was not clearly explained in the
commit message.

On Mon, 19 Oct 2015 03:05:09 +0300
Valery Kartel <valery.kartel@= gmail.com> wrote:

> ---
>=C2=A0 main/mariadb/APKBUILD=C2=A0 =C2=A0 =C2=A0 | 19 +++++++------- >=C2=A0 main/mariadb/mariadb.initd | 63 +++++++++++++-------------------= --------------
>=C2=A0 2 files changed, 27 insertions(+), 55 deletions(-)
>
> diff --git a/main/mariadb/APKBUILD b/main/mariadb/APKBUILD
> index 67c6239..7015b78 100644
> --- a/main/mariadb/APKBUILD
> +++ b/main/mariadb/APKBUILD
> @@ -3,8 +3,8 @@
>=C2=A0 # Maintainer: Natanael Copa <ncopa@alpinelinux.org>
>
>=C2=A0 pkgname=3Dmariadb
> -pkgver=3D10.0.21
> -pkgrel=3D2
> +pkgver=3D10.1.8
> +pkgrel=3D0
>=C2=A0 pkgdesc=3D"A fast SQL database server"
>=C2=A0 url=3D"http://www.mariadb.org"
>=C2=A0 pkgusers=3D"mysql"

...

> diff --git a/main/mariadb/mariadb.initd b/main/mariadb/mariadb.initd > index 8409bad..cb2a388 100644
> --- a/main/mariadb/mariadb.initd
> +++ b/main/mariadb/mariadb.initd
> @@ -1,15 +1,19 @@
>=C2=A0 #!/sbin/openrc-run
> -# Copyright 1999-2004 Gentoo Foundation
> -# Distributed under the terms of the GNU General Public License v2 > -# $Header: /var/cvsroot/gentoo-x86/dev-db/mysql/files/mysql.init,v 1.= 7 2004/07/14 21:41:15 agriffis Exp $
>
> +getconf() {
> +=C2=A0 =C2=A0 =C2=A0v=3D$(my_print_defaults --mysqld | grep ^--$1) > +=C2=A0 =C2=A0 =C2=A0[ -z $v ] && echo $2 || echo ${v#*=3D} > +}
> +
> +retry=3D"60"
> +pidfile=3D$(getconf pid-file "/run/mysqld/mysqld.pid")
>=C2=A0 extra_stopped_commands=3D"setup"
> -pidfile=3D/var/run/mysqld/mysqld.pid
> +command=3D"/usr/bin/mysqld_safe"
> +command_args=3D"--pid-file=3D$pidfile --syslog --nowatch" >
>=C2=A0 depend() {
> -=C2=A0 =C2=A0 =C2=A0need net
> -=C2=A0 =C2=A0 =C2=A0after firewall
> -=C2=A0 =C2=A0 =C2=A0use dns
> +=C2=A0 =C2=A0 =C2=A0use net
> +=C2=A0 =C2=A0 =C2=A0need localmount
>=C2=A0 }

Why do we accept that mariadb may be started before the firewal= l? Isn't
that a potensial risk? What was the reason for this change?

Why do we remove the 'use dns'? Did it create problems? Did you
investigate why it was added in first place?

-nc

--047d7b45066eb875ac0526edc45b-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---