Precedence: list
MIME-Version: 1.0
In-Reply-To: <41369f5f0c87accff0ee2c9f6428c45a@server-speed.net>
References: <20160616122941.8114-1-valery.kartel@gmail.com> <41369f5f0c87accff0ee2c9f6428c45a@server-speed.net>
From: Valery Kartel <valery.kartel@gmail.com>
Date: Thu, 7 Jul 2016 13:14:08 +0300
Message-ID: <CAKTwcDMbG7SeucX=gmiUM+GB=FeMEzx_cSJNXusNEUAv3bjsiQ@mail.gmail.com>
Subject: Re: [alpine-aports] [PATCH V2] main/dnsmasq: change default
 user/group, add config directory, cleanups in init script.
To: =?UTF-8?Q?Bart=C5=82omiej_Piotrowski?= <b@bpiotrowski.pl>
Cc: alpine-aports@lists.alpinelinux.org, droid@infogroup.kiev.ua
Content-Type: multipart/alternative; boundary=001a11403d0463c099053708f2b2

--001a11403d0463c099053708f2b2
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi

Yes, dnsmasq supports command-line user/group. But I think it's better to
set them correctly at compile time to get rid of unnecessary entries in
init scripts and it would start correctly from command line without any
additional flags just out of the box.

=D0=9F=D0=B5=D1=80=D0=B5=D0=BA=D0=BB=D0=B0=D0=B4=D0=B0=D1=87 Google =D0=B4=
=D0=BB=D1=8F =D0=BA=D0=BE=D0=BC=D0=BF=D0=B0=D0=BD=D1=96=D0=B9:Translator To=
olkit
<http://www.google.com/url?rs=3Drsmf&q=3Dhttp://translate.google.com/toolki=
t%3Fhl%3Duk>=D0=86=D0=BD=D1=81=D1=82=D1=80=D1=83=D0=BC=D0=B5=D0=BD=D1=82
=D0=BF=D0=B5=D1=80=D0=B5=D0=BA=D0=BB=D0=B0=D0=B4=D1=83 =D0=B2=D0=B5=D0=B1-=
=D1=81=D0=B0=D0=B9=D1=82=D1=96=D0=B2
<http://www.google.com/url?rs=3Drsmf&q=3Dhttp://translate.google.com/manage=
r/website/%3Fhl%3Duk>=D0=9F=D0=BE=D1=88=D1=83=D0=BA
=D0=BD=D0=B0 =D1=81=D0=B2=D1=96=D1=82=D0=BE=D0=B2=D0=BE=D0=BC=D1=83 =D1=80=
=D0=B8=D0=BD=D0=BA=D1=83
<http://www.google.com/url?rs=3Drsmf&q=3Dhttp://translate.google.com/global=
marketfinder/%3Flocale%3Duk>

To compile with DBUS it's need to explictly set HAVE_DBUS. So DBUS_* flags
are useless.

I think it's have no sense to make a patch to change 1 line in config file.
But you decide.

2016-07-07 12:17 GMT+03:00 Bart=C5=82omiej Piotrowski <b@bpiotrowski.pl>:

> Hi,
>
> Seems that dnsmasq supports --user and --groups flags so no patching is
> necessary. Are you sure about DBUS_* removal? We don't want to pull dbus =
by
> mistake.
>
> Natanael mentioned he would prefer patching the configuration file instea=
d
> of sed'ing it. Let me know if you are going to send another revision or y=
ou
> want me to make these changes.
>
> Bart=C5=82omiej
>

--001a11403d0463c099053708f2b2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div><div>Hi<br><br></div>Yes, dnsmasq supports comma=
nd-line user/group. But I think it&#39;s better to set them correctly at co=
mpile time to get rid of unnecessary entries in init scripts and it would s=
tart correctly from command line without any additional flags just out of t=
he box.<span id=3D"result_box" class=3D"" lang=3D"en"><br><span><br></span>=
</span><div id=3D"gt-text-all"><div id=3D"gt-main"><div id=3D"gt-text-c"><d=
iv id=3D"gt-ft"><div id=3D"gt-ft-mkt"><div class=3D""><span class=3D"">=D0=
=9F=D0=B5=D1=80=D0=B5=D0=BA=D0=BB=D0=B0=D0=B4=D0=B0=D1=87 Google =D0=B4=D0=
=BB=D1=8F =D0=BA=D0=BE=D0=BC=D0=BF=D0=B0=D0=BD=D1=96=D0=B9:</span><a href=
=3D"http://www.google.com/url?rs=3Drsmf&amp;q=3Dhttp://translate.google.com=
/toolkit%3Fhl%3Duk"><span id=3D"gt-ft-mkt-toolkit" class=3D""></span>Transl=
ator Toolkit</a><a href=3D"http://www.google.com/url?rs=3Drsmf&amp;q=3Dhttp=
://translate.google.com/manager/website/%3Fhl%3Duk"><span id=3D"gt-ft-mkt-e=
lement" class=3D""></span>=D0=86=D0=BD=D1=81=D1=82=D1=80=D1=83=D0=BC=D0=B5=
=D0=BD=D1=82 =D0=BF=D0=B5=D1=80=D0=B5=D0=BA=D0=BB=D0=B0=D0=B4=D1=83 =D0=B2=
=D0=B5=D0=B1-=D1=81=D0=B0=D0=B9=D1=82=D1=96=D0=B2</a><a href=3D"http://www.=
google.com/url?rs=3Drsmf&amp;q=3Dhttp://translate.google.com/globalmarketfi=
nder/%3Flocale%3Duk"><span id=3D"gt-ft-mkt-gmf" class=3D""></span>=D0=9F=D0=
=BE=D1=88=D1=83=D0=BA =D0=BD=D0=B0 =D1=81=D0=B2=D1=96=D1=82=D0=BE=D0=B2=D0=
=BE=D0=BC=D1=83 =D1=80=D0=B8=D0=BD=D0=BA=D1=83</a></div></div> </div></div>=
</div></div><br>To compile with DBUS it&#39;s need to explictly set HAVE_DB=
US. So DBUS_* flags are useless.<br><br>I think it&#39;s have no sense to m=
ake a patch to change 1 line in config file. But you decide.<br></div></div=
></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">2016-07-07=
 12:17 GMT+03:00 Bart=C5=82omiej Piotrowski <span dir=3D"ltr">&lt;<a href=
=3D"mailto:b@bpiotrowski.pl" target=3D"_blank">b@bpiotrowski.pl</a>&gt;</sp=
an>:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border=
-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Seems that dnsmasq supports --user and --groups flags so no patching is nec=
essary. Are you sure about DBUS_* removal? We don&#39;t want to pull dbus b=
y mistake.<br>
<br>
Natanael mentioned he would prefer patching the configuration file instead =
of sed&#39;ing it. Let me know if you are going to send another revision or=
 you want me to make these changes.<span class=3D"HOEnZb"><font color=3D"#8=
88888"><br>
<br>
Bart=C5=82omiej<br>
</font></span></blockquote></div><br></div>

--001a11403d0463c099053708f2b2--


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---