X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua0-f172.google.com (mail-ua0-f172.google.com [209.85.217.172]) by lists.alpinelinux.org (Postfix) with ESMTP id 9E55E5C41B6 for ; Mon, 23 Jan 2017 13:24:32 +0000 (GMT) Received: by mail-ua0-f172.google.com with SMTP id 96so109394891uaq.3 for ; Mon, 23 Jan 2017 05:24:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tybuAuu6De9nXiYcU3muQIDWBYvg8BEYv8ads1cLRlc=; b=QVpIZH/PVnee5gIUkwqRDlBxZkkHg1WuOMuutUz1/olu/+YpmJOL5W0oTJtfs0ADwT XPdFpLi13O8SA8gBKdlHUWllIf4HufSoA5YZuAyTNBW4NY/TnJUQ7ERPYbsGyOit6MxB PxzSPM9yvirWp2gX9WCatnuMzGLzio3qw5NMt+AJeW5DArXNGdNslPipaoJX9iNYYxSD WTCaODnNa8j/8J0AXV7U0Dk7Yb90OHrYLJKJw/heWoTbkXQr3uiXfp4oz9Of7pfjfghb hgw1Xb28ctd/H+515TWARaMtGn8iAegig6dUcXTc2jvOrSs83+B+aL+56919bjAzI/69 AglA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tybuAuu6De9nXiYcU3muQIDWBYvg8BEYv8ads1cLRlc=; b=B2Y2Hi83WoNJRgX6FFy8tIq5pQmOT+VyVXDO7hq5xL1pNtBuHuMaL8yt15GbRjBipW 6JamboPra52tH21dKxqw8j5FkEewF29xnaEabOHWjNyLATsw/XxZ4MVw/avIAc44a8gP tD9+D1asTu06viqkcmGqOGwRIQuRcVkmked+g13mXFx/sLS3PGh2slPJq59PK3sM6XTa qBeXh92FFI/K3PlCx0Vu+SbIoqFAUo5qpPaUfwwf4lvZTutz2i0Q2JVKTwe6ZYgCmLGl 7ZYXru+JRdWosbCrF1YE+untJt3iGQSBVgaxkmxBjLkE2MWtIxM993/nZUpE1PJKjzz2 3QIw== X-Gm-Message-State: AIkVDXLqOKspuxyjMHZ3zm3Y64JgZBzZwMhPZSURXEJ5Mj4/jk1ZeSJpmtqW/25GC/JQhQVB6HNKo1TxR/88IQ== X-Received: by 10.176.93.21 with SMTP id u21mr15123772uaf.139.1485177872146; Mon, 23 Jan 2017 05:24:32 -0800 (PST) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 10.31.140.138 with HTTP; Mon, 23 Jan 2017 05:24:31 -0800 (PST) In-Reply-To: References: <20170123115119.32715-1-valery.kartel@gmail.com> <1485176528.11710.9.camel@gmail.com> From: Valery Kartel Date: Mon, 23 Jan 2017 15:24:31 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] main/perl-encode: upgrade to 2.88 To: Leonardo Arena Cc: alpine-aports Content-Type: multipart/alternative; boundary=94eb2c19f7607f6a5d0546c2ebdb --94eb2c19f7607f6a5d0546c2ebdb Content-Type: text/plain; charset=UTF-8 What do you think about to apply perl fixes http://patchwork.alpinelinux. org/patch/2816/ ? 2017-01-23 15:07 GMT+02:00 Valery Kartel : > Oh, > > previously I post http://patchwork.alpinelinux.org/patch/2816/ and > somehow thought it's accepted and used it on my own build host. > > for now it replaces="perl" :) > > 2017-01-23 15:02 GMT+02:00 Leonardo Arena : > >> Hi, >> >> On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote: >> > - fix doc >> > - move *.pod to -doc >> > - rename -piconv subpackage to -utils (because there are several >> > utils) >> > - move development script and data to -dev >> > --- >> > main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++-- >> > ------------ >> > 1 file changed, 35 insertions(+), 15 deletions(-) >> > >> >> [...] >> >> > -# we split out /usr/bin/piconv to separate package to avoid conflict >> > with >> > -# piconv shipped with perl itself >> > -piconv() { >> > - pkgdesc="perl implementation of iconv" >> > +utils() { >> > + pkgdesc="perl Encode utils" >> > + replaces="perl-utils" >> > + mkdir -p "$subpkgdir"/usr >> > + mv "$pkgdir"/usr/bin "$subpkgdir"/usr/ >> > +} >> > + >> >> there's no package "perl-utils" to be replaced. piconv and encguess >> belong to main perl package: >> >> (1/1) Installing perl-encode-utils (2.88-r0) >> ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess >> owned by perl-5.24.0-r0. >> ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv >> owned by perl-5.24.0-r0. >> >> > +dev() { >> > + default_dev >> > + replaces="perl-dev" >> > mkdir -p "$subpkgdir"/usr/bin >> > - mv "$pkgdir"/usr/bin/piconv "$subpkgdir"/usr/bin/ >> > + mv "$pkgdir"/usr/bin/enc2xs "$subpkgdir"/usr/bin || reutrn 1 >> >> Spelling error ^ >> >> Other than these it looks okay to me. >> >> Thanks! >> >> -|_eo >> >> > --94eb2c19f7607f6a5d0546c2ebdb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
What do you think about to apply perl fixes http://patchwo= rk.alpinelinux.org/patch/2816/=C2=A0 ?

2017-01-23 15:07 GMT+02:00 Valery K= artel <valery.kartel@gmail.com>:
Oh,

previously I post= http://patchwork.alpinelinux.org/patch/2816/ and somehow thought = it's accepted and used it on my own build host.

for now it= replaces=3D"perl" :)

2017-01-2= 3 15:02 GMT+02:00 Leonardo Arena <rnalrd@gmail.com>:
Hi,

On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote:
> - fix doc
> - move *.pod to -doc
> - rename -piconv subpackage to -utils (because there are several
> utils)
> - move development script and data to -dev
> ---
> =C2=A0main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++--
> ------------
> =C2=A01 file changed, 35 insertions(+), 15 deletions(-)
>

[...]=C2=A0

> -# we split out /usr/bin/piconv to separate package to avoid conflict<= br> > with
> -# piconv shipped with perl itself
> -piconv() {
> -=C2=A0 =C2=A0 =C2=A0pkgdesc=3D"perl implementation of iconv"= ;
> +utils() {
> +=C2=A0 =C2=A0 =C2=A0pkgdesc=3D"perl Encode utils"
> +=C2=A0 =C2=A0 =C2=A0replaces=3D"perl-utils"
> +=C2=A0 =C2=A0 =C2=A0mkdir -p "$subpkgdir"/usr
> +=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin "$subpkgdir&q= uot;/usr/
> +}
> +

there's no package "perl-utils" to be replaced. piconv= and encguess
belong to main perl package:

(1/1) Installing perl-encode-utils (2.88-r0)
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess
owned by perl-5.24.0-r0.
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv
owned by perl-5.24.0-r0.

> +dev() {
> +=C2=A0 =C2=A0 =C2=A0default_dev
> +=C2=A0 =C2=A0 =C2=A0replaces=3D"perl-dev"
> =C2=A0=C2=A0 =C2=A0 =C2=A0mkdir -p "$subpkgdir"/usr/bin
> -=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin/piconv "$subp= kgdir"/usr/bin/
> +=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin/enc2xs "$subp= kgdir"/usr/bin || reutrn 1

Spelling error =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^

Other than these it looks okay to me.

Thanks!

-|_eo



--94eb2c19f7607f6a5d0546c2ebdb-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---