X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com [209.85.213.47]) by lists.alpinelinux.org (Postfix) with ESMTP id EA4AC5C41BC for ; Mon, 23 Jan 2017 13:07:53 +0000 (GMT) Received: by mail-vk0-f47.google.com with SMTP id k127so89693903vke.0 for ; Mon, 23 Jan 2017 05:07:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=q7QLmjpnQcrrG1vSg/yw2bzfRqI550JnfLjXrgUF2cw=; b=pbnr6zEyQ0a8CT+nEAsyzSLWHxk3svtrmHoe7PC0FMpBOG09rEfntgL1K7MCjfeHJJ P3A+Z+42Q/mJaBmqVgzd+EXs0Bfpq7XvRdv66HeQbhsetw2DAHBX0xfOPzw3Bbe9YxZW UtWJ7eyS3osI5EwO5+Uu7XNrB4ilXfhGCid7LlLLeomtaEEari0BF4bjQAkqGxrsQ4uO 3vfEj1JQNZlgr+dt2iYVZWd+k1EcGqXqrDWuleTD0OtXeYRyi+wUTUpKZtLLoDC5Stw+ K8QQDkMWg+y7EdyNqGKjiiLtpk/uV3Voqqn9x7WVDiZMQGKYzHmcTNUbHL4RayHGH3+1 eJxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=q7QLmjpnQcrrG1vSg/yw2bzfRqI550JnfLjXrgUF2cw=; b=XF05XSUbOkRqAYo616oiJptZponf538QNvBiZHk6wDvJf4YcGIhMiUCDM1EcM1wB+x cWi0LXeovlQnaNadVGrH4ggklylixbCM2rT45vI+ixETGuv2anOnSHtNQIvpOUjGthSx O8SxiJfkjVLLIyqpMHNfkFdm+ClnQx/gznLiEUhUiV6kSz6YHKBGrAOoIHlNafu0/9Hv mgBQwl06AF7gB4zUR0zYpbi+KLX15AO+IGVjluomyHE0EXnwZJFuKte7Gqsp2AhYGk89 FUaJjH5pufvkldilYi3gwzdadDiJhZ1HiAO43DyclqtBmPxU/ktgVjyxU9cZ+meAfYOx rP2w== X-Gm-Message-State: AIkVDXJC4Bb2WE+Fp77BMb4yewLMma2VDFPAOUb9GD2NXf/8XhFh9L0Rn/iBw0yU/nC3K7D6Nih9hBhmNOGEJQ== X-Received: by 10.31.179.73 with SMTP id c70mr10655289vkf.81.1485176873541; Mon, 23 Jan 2017 05:07:53 -0800 (PST) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 10.31.140.138 with HTTP; Mon, 23 Jan 2017 05:07:53 -0800 (PST) In-Reply-To: <1485176528.11710.9.camel@gmail.com> References: <20170123115119.32715-1-valery.kartel@gmail.com> <1485176528.11710.9.camel@gmail.com> From: Valery Kartel Date: Mon, 23 Jan 2017 15:07:53 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] main/perl-encode: upgrade to 2.88 To: Leonardo Arena Cc: alpine-aports Content-Type: multipart/alternative; boundary=001a1142efbef9e7760546c2af71 --001a1142efbef9e7760546c2af71 Content-Type: text/plain; charset=UTF-8 Oh, previously I post http://patchwork.alpinelinux.org/patch/2816/ and somehow thought it's accepted and used it on my own build host. for now it replaces="perl" :) 2017-01-23 15:02 GMT+02:00 Leonardo Arena : > Hi, > > On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote: > > - fix doc > > - move *.pod to -doc > > - rename -piconv subpackage to -utils (because there are several > > utils) > > - move development script and data to -dev > > --- > > main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++-- > > ------------ > > 1 file changed, 35 insertions(+), 15 deletions(-) > > > > [...] > > > -# we split out /usr/bin/piconv to separate package to avoid conflict > > with > > -# piconv shipped with perl itself > > -piconv() { > > - pkgdesc="perl implementation of iconv" > > +utils() { > > + pkgdesc="perl Encode utils" > > + replaces="perl-utils" > > + mkdir -p "$subpkgdir"/usr > > + mv "$pkgdir"/usr/bin "$subpkgdir"/usr/ > > +} > > + > > there's no package "perl-utils" to be replaced. piconv and encguess > belong to main perl package: > > (1/1) Installing perl-encode-utils (2.88-r0) > ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess > owned by perl-5.24.0-r0. > ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv > owned by perl-5.24.0-r0. > > > +dev() { > > + default_dev > > + replaces="perl-dev" > > mkdir -p "$subpkgdir"/usr/bin > > - mv "$pkgdir"/usr/bin/piconv "$subpkgdir"/usr/bin/ > > + mv "$pkgdir"/usr/bin/enc2xs "$subpkgdir"/usr/bin || reutrn 1 > > Spelling error ^ > > Other than these it looks okay to me. > > Thanks! > > -|_eo > > --001a1142efbef9e7760546c2af71 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Oh,

previously I post http://patchwork.alpinelinux.or= g/patch/2816/ and somehow thought it's accepted and used it on my o= wn build host.

for now it replaces=3D"perl" :)

2017-01-23 15= :02 GMT+02:00 Leonardo Arena <rnalrd@gmail.com>:
Hi,

On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote:
> - fix doc
> - move *.pod to -doc
> - rename -piconv subpackage to -utils (because there are several
> utils)
> - move development script and data to -dev
> ---
> =C2=A0main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++--
> ------------
> =C2=A01 file changed, 35 insertions(+), 15 deletions(-)
>

[...]=C2=A0

> -# we split out /usr/bin/piconv to separate package to avoid conflict<= br> > with
> -# piconv shipped with perl itself
> -piconv() {
> -=C2=A0 =C2=A0 =C2=A0pkgdesc=3D"perl implementation of iconv"= ;
> +utils() {
> +=C2=A0 =C2=A0 =C2=A0pkgdesc=3D"perl Encode utils"
> +=C2=A0 =C2=A0 =C2=A0replaces=3D"perl-utils"
> +=C2=A0 =C2=A0 =C2=A0mkdir -p "$subpkgdir"/usr
> +=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin "$subpkgdir&q= uot;/usr/
> +}
> +

there's no package "perl-utils" to be replaced. piconv= and encguess
belong to main perl package:

(1/1) Installing perl-encode-utils (2.88-r0)
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess
owned by perl-5.24.0-r0.
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv
owned by perl-5.24.0-r0.

> +dev() {
> +=C2=A0 =C2=A0 =C2=A0default_dev
> +=C2=A0 =C2=A0 =C2=A0replaces=3D"perl-dev"
> =C2=A0=C2=A0 =C2=A0 =C2=A0mkdir -p "$subpkgdir"/usr/bin
> -=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin/piconv "$subp= kgdir"/usr/bin/
> +=C2=A0 =C2=A0 =C2=A0mv "$pkgdir"/usr/bin/enc2xs "$subp= kgdir"/usr/bin || reutrn 1

Spelling error =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^

Other than these it looks okay to me.

Thanks!

-|_eo


--001a1142efbef9e7760546c2af71-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---