X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-ua0-f196.google.com (mail-ua0-f196.google.com [209.85.217.196]) by lists.alpinelinux.org (Postfix) with ESMTP id B8FBA5C43EC for ; Wed, 1 Mar 2017 16:19:49 +0000 (GMT) Received: by mail-ua0-f196.google.com with SMTP id 72so5395150uaf.1 for ; Wed, 01 Mar 2017 08:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hW85ud+BwmmVyOOBCVTtqBxhu5MbGQJJ9uEgh2mUszI=; b=SQlSkCI2NQFlBlyDfqqvXmBU+FcKf6R1sDE5tghWVfTdduC8PBKsAgMMp6JrIt3LGk m0zbUdROxe7N0c2P/V0E7R6EMZioXFdedGSRlQMAXGhVfa0ViVCEop1S+RzLYuKEjS9p 2jPfD1PvGEQNmcCQcLopPJ9+k255/9vfKYndo2jmqpRxoNGhDTnER5WtIGUo7cftzZxp 8tYrv7pko01022sPwyDOoz4IhZcjJLl6AbNZShzRd1Ke5kKlgh5KY4ErEZCgQ2wsY6+h DEND14cPgIVmn640dQBqcAMvmfE06DgDKuvK45KFanQct1iIhDN1SRe+iSARvSTa4VqF ZOxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hW85ud+BwmmVyOOBCVTtqBxhu5MbGQJJ9uEgh2mUszI=; b=dT36b98ug4EGM+hO17w5D2XO16MB/SwRdb3x4k7m1c6OQ3Ket8+BJt/h9P1LPaFzaz EGb50z1Sjctio3zmpJpJMAZxFgDd1t54wOMfR9twr13AeqMr9wXgBrDgwGgIdTZtbGx3 UR+ep1S3q4nY6ccBP/ce9tPHm/5kYLWMinWMf246XUBVWrL5H34KIQDPj2P9PKkj1IKI udhyF5gaWmx1WSBZsZwbUq/7xhMcDwiqpMqnXbFHgqs8n5XRlm6ET/ReZpdZazUt5r// VnMVsw/ZUyxQJOu0jE94wu7aSZj+FMHS3AhOQQPoBAOAaAE1BxFHaNVZjvpTalxX8/o1 bwAw== X-Gm-Message-State: AMke39lW3H47oUkrtXpiz76e1am6AAsXFT0lwO/ibxw0n0uMJ7xJh2llLLVttTixRxRn8PlpvpXXXRTdGII8zw== X-Received: by 10.176.23.89 with SMTP id k25mr3710994uaf.49.1488385189190; Wed, 01 Mar 2017 08:19:49 -0800 (PST) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Received: by 10.103.104.66 with HTTP; Wed, 1 Mar 2017 08:19:48 -0800 (PST) In-Reply-To: <20170301170449.1ef9a5f0@ncopa-desktop.copa.dup.pw> References: <20170301091223.29158-1-valery.kartel@gmail.com> <20170301170449.1ef9a5f0@ncopa-desktop.copa.dup.pw> From: Valery Kartel Date: Wed, 1 Mar 2017 18:19:48 +0200 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/php7.1: do not build fileinfo with system magic file To: Natanael Copa Cc: alpine-aports Content-Type: multipart/alternative; boundary=f40304361e127da4690549adae41 --f40304361e127da4690549adae41 Content-Type: text/plain; charset=UTF-8 I added a feature to use system-wide magic.mgc when I made fileinfo extension shared (pre-last commit). Then a guys who deploy alpine and php7.1 in their projects wrote me me and reported a problem with it :: But once installed, Nextcloud for instance cannot generated preview of images, :: I get this explicit error from the logs :; finfo::finfo(): Failed to load magic database at '(null)' and there is an open bug with the same problem: https://bugs.alpinelinux.org/issues/6945 I not investigate where the problem is, but as a quick fix I made a switch-back to bundled in php magic database 2017-03-01 18:04 GMT+02:00 Natanael Copa : > On Wed, 1 Mar 2017 11:12:23 +0200 > Valery Kartel wrote: > > > -- > > because its buggy > > is php buggy or system magic file? > Do we want fix system magic? > > -nc > > > --- > > testing/php7.1/APKBUILD | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/testing/php7.1/APKBUILD b/testing/php7.1/APKBUILD > > index 717daa1c96..74a4e3ce6e 100644 > > --- a/testing/php7.1/APKBUILD > > +++ b/testing/php7.1/APKBUILD > > @@ -2,7 +2,7 @@ > > # Maintainer: Valery Kartel > > pkgname=php7.1 > > pkgver=7.1.2 > > -pkgrel=3 > > +pkgrel=4 > > _apiver=20160303 > > _suffix=${pkgname#php} > > _pkgreal=${pkgname%$_suffix} > > @@ -19,7 +19,7 @@ makedepends="autoconf bison re2c apache2-dev > libxml2-dev libxslt-dev libzip-dev > > aspell-dev enchant-dev expat-dev pcre-dev curl-dev gmp-dev icu-dev > imap-dev gd-dev > > libical-dev libressl-dev openldap-dev net-snmp-dev db-dev krb5-dev > gdbm-dev sqlite-dev > > freetds-dev mariadb-dev postgresql-dev unixodbc-dev freetype-dev > tidyhtml-dev libwebp-dev > > - libpng-dev libjpeg-turbo-dev libmcrypt-dev recode-dev libedit-dev > gettext-dev file-dev > > + libpng-dev libjpeg-turbo-dev libmcrypt-dev recode-dev libedit-dev > gettext-dev > > " > > source="http://php.net/distributions/$_pkgreal-$pkgver.tar.bz2 > > $pkgname-module.conf > > @@ -168,10 +168,6 @@ build() { > > --with-litespeed \ > > --with-imap=shared --with-imap-ssl \ > > || return 1 > > - # rebuild fileinfo with current /usr/share/misc/magic.mgc > > - sapi/cli/php -n ext/fileinfo/create_data_file.php \ > > - /usr/share/misc/magic.mgc > ext/fileinfo/data_file.c || > return 1 > > - make > > } > > > > check() { > > --f40304361e127da4690549adae41 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I added a feature to use system-wide magic.mgc when I made= fileinfo extension shared (pre-last commit).

Then a guys who deploy= alpine and php7.1 in their projects wrote me me and reported a problem wit= h it

:: But once installed, Nextcloud for instance cannot generated = preview of images,
:: I get this explicit error from the logs
:; finf= o::finfo(): Failed to load magic database at '(null)'

and th= ere is an open bug with the same problem: https://bugs.alpinelinux.org/issues/6945

I n= ot investigate where the problem is, but as a quick fix I made a switch-bac= k to bundled in php magic database

=
2017-03-01 18:04 GMT+02:00 Natanael Copa <n= copa@alpinelinux.org>:
On Wed,=C2=A0 1 Mar 2017 11:12:23 +0200
Valery Kartel <valery.kartel@= gmail.com> wrote:

> --
> because its buggy

is php buggy or system magic file?
Do we want fix system magic?

-nc

> ---
>=C2=A0 testing/php7.1/APKBUILD | 8 ++------
>=C2=A0 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/testing/php7.1/APKBUILD b/testing/php7.1/APKBUILD
> index 717daa1c96..74a4e3ce6e 100644
> --- a/testing/php7.1/APKBUILD
> +++ b/testing/php7.1/APKBUILD
> @@ -2,7 +2,7 @@
>=C2=A0 # Maintainer: Valery Kartel <valery.kartel@gmail.com>
>=C2=A0 pkgname=3Dphp7.1
>=C2=A0 pkgver=3D7.1.2
> -pkgrel=3D3
> +pkgrel=3D4
>=C2=A0 _apiver=3D20160303
>=C2=A0 _suffix=3D${pkgname#php}
>=C2=A0 _pkgreal=3D${pkgname%$_suffix}
> @@ -19,7 +19,7 @@ makedepends=3D"autoconf bison re2c apache2-dev = libxml2-dev libxslt-dev libzip-dev
>=C2=A0 =C2=A0 =C2=A0 =C2=A0aspell-dev enchant-dev expat-dev pcre-dev cu= rl-dev gmp-dev icu-dev imap-dev gd-dev
>=C2=A0 =C2=A0 =C2=A0 =C2=A0libical-dev libressl-dev openldap-dev net-sn= mp-dev db-dev krb5-dev gdbm-dev sqlite-dev
>=C2=A0 =C2=A0 =C2=A0 =C2=A0freetds-dev mariadb-dev postgresql-dev unixo= dbc-dev freetype-dev tidyhtml-dev libwebp-dev
> -=C2=A0 =C2=A0 =C2=A0libpng-dev libjpeg-turbo-dev libmcrypt-dev recode= -dev libedit-dev gettext-dev file-dev
> +=C2=A0 =C2=A0 =C2=A0libpng-dev libjpeg-turbo-dev libmcrypt-dev recode= -dev libedit-dev gettext-dev
>=C2=A0 =C2=A0 =C2=A0 =C2=A0"
>=C2=A0 source=3D"http://php.net/= distributions/$_pkgreal-$pkgver.tar.bz2
>=C2=A0 =C2=A0 =C2=A0 =C2=A0$pkgname-module.conf
> @@ -168,10 +168,6 @@ build() {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-litespeed= \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--with-imap=3Dsh= ared --with-imap-ssl \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|| return 1
> -=C2=A0 =C2=A0 =C2=A0# rebuild fileinfo with current /usr/share/misc/m= agic.mgc
> -=C2=A0 =C2=A0 =C2=A0sapi/cli/php -n ext/fileinfo/create_data_file.php \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/usr/share/misc/magic= .mgc > ext/fileinfo/data_file.c || return 1
> -=C2=A0 =C2=A0 =C2=A0make
>=C2=A0 }
>
>=C2=A0 check() {


--f40304361e127da4690549adae41-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---