Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 2AD1F782C53
	for <~alpine/aports@lists.alpinelinux.org>; Fri, 17 Jan 2020 03:20:23 +0000 (UTC)
Received: by mail-io1-f67.google.com with SMTP id n11so24416030iom.9
        for <~alpine/aports@lists.alpinelinux.org>; Thu, 16 Jan 2020 19:20:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=BvzRnqAeQ50MfoxW1x+P2xOdGtG5dYiH89BZGWkTQbI=;
        b=kFvI4uRAdNh0oE3x5mxRRnO4erg4QM0YzhAfIhNU7tTPXb0FH1TzRWTHyn/j50rAnp
         XJuP229WqjxdhbOqbV5F8yc91CgRjwdRX8Yu8QM7TZ5aGk/+RiLzJZu07gMq+VEqA2/2
         gyQT4rbq6rj5ubetnwnto+lE0MwLkxv8Ps2eTYtPLWDRb3bW9H9A/CAl/sHZK5PoqSTV
         bAhDVrTK5aswLiZw2bBpGAhGc0xOlT5UJquv+yuYogaF1U+OCyk3KcaiIcu0eZX4uWk1
         jU0hdghKUXGYRqT2gr8PoqBF9ZDbcb4Gj7kBwSUeD5BKSs+MNo7se7o5vYqvf+U2Q1cI
         9MLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=BvzRnqAeQ50MfoxW1x+P2xOdGtG5dYiH89BZGWkTQbI=;
        b=WNJSfo0tv4Qp2sIMdocUi4LFGFC+4TmpEt96wYLhamwatUDs0jUjKrLc75yelN52qY
         fSjaWwSxS3H/O2qdKkqqFnG8xht362lUSwpIr6Em2Sj8PE8tenhCIYz+aF3Pd7xnmMxq
         GfjWWNeYWj0XXHAi64uaYR1BJwjLOQM5yt5Knjr5Q26EuTSwWDGsPRq4G+ldaV5S7IIi
         fjh4LmfX2aLe1dAHwE4g8SnPtugCT2B1Uxo/K9rJLApduYXkiunK8D8TneL4HKT/ORjR
         xT4/HakVt4YTtJQIlRIGWal1pBjkDzUo0Btf6+7+9sXJHkI1nop6kePBs5GYsrYOLy9C
         qdXQ==
X-Gm-Message-State: APjAAAW/KjDk93Aie1jWnnP6QCQgQeP3cB9HUv0ODPBuxyRL4Y+EgAMu
	T6Tp8krINActty1byGGiGYqPMHc5jnh6QBCPx70=
X-Google-Smtp-Source: APXvYqxOfg7t9GVXO+limEPuOia6z6feyMzivqXm8iMkJOPLVIYnzsMSK7XPtqc8c0sV9+OYH+uGCbakvt+virudHLc=
X-Received: by 2002:a6b:490f:: with SMTP id u15mr30964272iob.192.1579231221529;
 Thu, 16 Jan 2020 19:20:21 -0800 (PST)
MIME-Version: 1.0
References: <BZXLCLNE106J.2X1545VIKMF9J@homura>
In-Reply-To: <BZXLCLNE106J.2X1545VIKMF9J@homura>
From: Tiago Ilieve <tiago.myhro@gmail.com>
Date: Fri, 17 Jan 2020 00:19:45 -0300
Message-ID: <CALdTKe8n6Xgr==szzHo1naxNf46DdGDCEuaoMhzCaUx56T-Mcg@mail.gmail.com>
Subject: Re: [PATCH] testing/prometheus-node-exporter: import from sr.ht
To: Drew DeVault <sir@cmpwn.com>
Cc: ~alpine/aports@lists.alpinelinux.org
Content-Type: text/plain; charset="UTF-8"

Hi Drew,

On Thu, 16 Jan 2020 at 20:08, Drew DeVault <sir@cmpwn.com> wrote:
> That patch affects the makefile, which is now not used.

Great. I hadn't noticed it in the first time.

> We can update this to specify the version information in a manner
> similar to how the prometheus package does it. Good point for v2.

No problem.

> It doesn't really matter (you use it through the init.d file), but we
> can change this too.

> Ack, let's use 0.0.0.0.

Thanks. Please let me know if you need another round of review.

Regards,
Tiago.


--
Tiago "Myhro" Ilieve
Blog: https://blog.myhro.info/
GitHub: https://github.com/myhro
LinkedIn: https://www.linkedin.com/in/myhro/
Montes Claros, Brazil