Precedence: list
MIME-Version: 1.0
In-Reply-To: <20160819110711.GB28952@francium>
References: <20160819104928.71007-1-keegan.csmith@gmail.com> <20160819110711.GB28952@francium>
From: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
Date: Fri, 19 Aug 2016 13:11:35 +0200
Message-ID: <CAMVcy0SEp9VBexA_j9KYWWXTP7Qjg8OUS-43-jpajsgcwhTrmg@mail.gmail.com>
Subject: Re: [alpine-aports] [PATCH] community/go: upgrade to 1.7
To: =?UTF-8?Q?S=C3=B6ren_Tempel?= <soeren@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

> The go aport contains the following arm specific instructions:
>
> >       # go before 1.7 has issues with randmmap on arm
> >       # https://github.com/golang/go/issues/16081
> >       if [ "$GOARCH" =3D "arm" ]; then
> >               paxmark -r bin/go || attr -s pax.flags -V "rx" bin/go \
> >                       || return 1
> >       fi
>
> Did go 1.7 in fact fix this issue? If so: Please remove the code from
> the APKBUILD when upgrading to 1.7.

According to the issue it is fixed in 1.7 for a while. So the arm
patch likely should of been removed in one of the earlier rc's. I'm
not too familiar with aport development workflow (first time I have
submitted). Should I submit a separate patch removing the arm patch? I
also have no idea how to validate this.

Keegan

On Fri, Aug 19, 2016 at 1:07 PM, S=C3=B6ren Tempel <soeren@soeren-tempel.ne=
t> wrote:
>
>
> S=C3=B6ren.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---