Precedence: list
MIME-Version: 1.0
References: <20181230111722.21006-1-martin.rusko@gmail.com> <CAGG_d8DQfTXEB4BMu-Z=ChMv3F57kzRbwu62b=y3ognwatc4yQ@mail.gmail.com>
In-Reply-To: <CAGG_d8DQfTXEB4BMu-Z=ChMv3F57kzRbwu62b=y3ognwatc4yQ@mail.gmail.com>
From: Martin Rusko <martin.rusko@gmail.com>
Date: Mon, 31 Dec 2018 15:49:15 +0100
Message-ID: <CAMYYbY4qkQX0FrA-q+LbE_Xna=g7HP_1z0Z8JU+W2WM0XfNjmQ@mail.gmail.com>
Subject: Re: [alpine-aports] [PATCH] testing/minidyndns: new aport
To: Leonardo Arena <rnalrd@gmail.com>
Cc: alpine-aports <alpine-aports@lists.alpinelinux.org>
Content-Type: text/plain; charset="UTF-8"

Many thanks for your comments. I will update it accordingly. I will
send it again as new patch. There is just one thing I'm not certain
about, see below.

On Mon, Dec 31, 2018 at 12:18 PM Leonardo Arena <rnalrd@gmail.com> wrote:
>>
>> diff --git a/testing/minidyndns/minidyndns.confd b/testing/minidyndns/minidyndns.confd
>> new file mode 100644
>> index 0000000000..3cf5d10be2
>> --- /dev/null
>> +++ b/testing/minidyndns/minidyndns.confd
>> @@ -0,0 +1,5 @@
>> +#
>> +# Specify daemon options here.
>> +#
>> +
>> +minidyndns_opts="--config /etc/minidyndns_config.yml --db /var/lib/minidyndns/db.yml"
>
>
>
> Since these are default values, may be you can add those to the init script itself and leave the conf file for customizations.
>
> : ${minidyndns_opts:="--config /etc/minidyndns_config.yml --db /var/lib/minidyndns/db.yml"}
>
Will I not stand in a way of someone who will want to change the
location of these files? The administrator will need to edit both the
file in conf.d and the one init.d script as well. I feel it's better
to keep these options defined in conf.d file. If I'm overthinking it,
just say so and I will move them to init.d script.

/Martin


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---