X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by lists.alpinelinux.org (Postfix) with ESMTP id EE5A9F8145B for ; Sun, 12 May 2019 19:20:59 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id e19so8381394iob.3 for ; Sun, 12 May 2019 12:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0x5mDQWaZWVy46PczhQ7VNfx+iX6RQ0JRyng96QoguM=; b=UqGLc3NzKsfZ4lnVf/vVmVIlB+mx5qiniY8izBQaWEzZPLoEEIsfxl/Oq1TcXEsWRu lW8KXWdrFLRLaXxjfI00p6/Ptkslgkuf/iEKIJHVHPiKrfBVu0K+/pMFbTUoSRdFpgpp cj8Fech2BJ5xuRfj5kCKuF6rXDrARoJDTjjXol7jDE6MaSan0GjdKDLsoEYrpxa16l2R gePrrvHssi2YmDpU0ggH6/CcFcFj4lH4/FPQHuEdoKYfztxlTeFlhu6loHEUIEso/H6U NC+6FJW47YoSn+29pZ9ZoEPr/4s1uERmqFMP0qzzPGsApui7c4T26i2usem9o1CMew1Q 27lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0x5mDQWaZWVy46PczhQ7VNfx+iX6RQ0JRyng96QoguM=; b=hToYjWO2UTWhsy7BhWwETouYr91gyCJ91OgbFxPHIHXXA5W2B58rRk0rZy5Zt6oz4I 4DI7pPrpFEpcq/fENPRMpD24XDMXQCbfyjQ0kOhL0SCiHCMiwSEzmG5+s0EiyphYJMIm 7gyasgmtQmdO6Kt2ieNYD2usgRYsHMIdBoCCjCosr0fz9jl+cU60GOY/rrBFF1pZa4pn kgROlaewMLLZA/+5Hultln4iLh3PFXTaXYO4Esdf1ia3AwLXLadohrUG9onAoLht21+a ldwwkCstB3DDWd30NMvRkev6W/oK/KJAR+3wi12U+b68dN8rDCHpFNOQ7dAC6eMdzsjT MTeQ== X-Gm-Message-State: APjAAAUZ+0i8VkIvfkk3yLrnC7vfO+qU/8ClBNSo6fln2MQXXbohIZdP 4jEW/q9LWAhg0x+LajpLwj4dQBAxLk3rtYPb74sRfFs2 X-Google-Smtp-Source: APXvYqzDvw4dMzYxKccAwJ0h6UtNRhVHO38mksuuMHx/PnkRSJsc/3gvi2ZxYxwtIgVt96iYqEqHOOmtZRNAUHAP5rE= X-Received: by 2002:a6b:8b56:: with SMTP id n83mr11410503iod.33.1557688859477; Sun, 12 May 2019 12:20:59 -0700 (PDT) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 References: <20190512120751.27955-1-raschi.alex@gmail.com> <20190512164734.GB23109@alpha> In-Reply-To: <20190512164734.GB23109@alpha> From: Alex Raschi Date: Sun, 12 May 2019 19:20:05 +0000 Message-ID: Subject: Re: [alpine-aports] [PATCH] testing/telegram-desktop: drop maintainership To: Kevin Daudt Cc: alpine-aports Content-Type: multipart/alternative; boundary="00000000000023cbf40588b5b3aa" --00000000000023cbf40588b5b3aa Content-Type: text/plain; charset="UTF-8" Hi Kevin, I didn't know about the snapshots situation and i understand the issues of uploading archives. Yes there is an another way to avoid creating a snapshot but as you can see in the committed change, it requires keeping track of additional dependencies manually which involves of checking git hashes every time. That's why the aport used snapshots and i opted for this solution when i wrote it, with git submodules is a lot easier. Rewriting aport without any sort of advise to the maintainer should be avoided in my opinion, i found it rewritten without knowing anything since i don't use github and the patch comes from there. The new build seems to require to update the source file lists with every new update too, and this doesn't seem to me a good change. Let just clone gyp with another archive then, rather than using something not supported upstream if possible. Anyway i am a little busy lately so if there is someone that would maintain better the package then ok, i don't mind that. I can't hide the fact that the previous commit pissed me off a little... Cheers, Alex. On Sun, May 12, 2019 at 4:47 PM Kevin Daudt wrote: > Sad to here this. > > It was necessary because the build was failing and only a limited amount > of people have access to create snapshots and upload them to dev. > > We prefer being able to build packages without having to create archives > ourselfs. It just happened that this PR was already available so that > was the quickest way to get things building again. > > If you know a way to use the official build system but not having to > rely on creating snapshots, we're happy to use that. > > Kind regards, Kevin. > > On Sun, May 12, 2019 at 02:07:51PM +0200, Alex Raschi wrote: > > the aport has been rewritten and now uses an unofficial third party build > > system that i don't want to maintain > > --- > > testing/telegram-desktop/APKBUILD | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/testing/telegram-desktop/APKBUILD > b/testing/telegram-desktop/APKBUILD > > index d951cff246..77770120c5 100644 > > --- a/testing/telegram-desktop/APKBUILD > > +++ b/testing/telegram-desktop/APKBUILD > > @@ -1,4 +1,4 @@ > > -# Maintainer: Alex Raschi > > +# Maintainer: > > # Contributor: Leo > > pkgname=telegram-desktop > > pkgver=1.6.7 > > -- > > 2.21.0 > > > > > > > > --- > > Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org > > Help: alpine-aports+help@lists.alpinelinux.org > > --- > > > --00000000000023cbf40588b5b3aa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Kevin,

I didn't know about the snapshots sit= uation and i understand the issues of
uploading archives.

Yes the= re is an another way to avoid creating a snapshot but as you can see in
= the committed change, it requires keeping track of additional dependencies<= br>manually which involves of checking git hashes every time.

That&#= 39;s why the aport used snapshots and i opted for this solution when i wrot= e
it, with git submodules is a lot easier.

Rewriting aport withou= t any sort of advise to the maintainer should be avoided
in my opinion, = i found it rewritten without knowing anything since i don't use
gith= ub and the patch comes from there.

The new build seems to require to= update the source file lists with every new
update too, and this doesn&= #39;t seem to me a good change. Let just clone gyp with
another archive = then, rather than using something not supported upstream if
possible.
Anyway i am a little busy lately so if there is someone that would mai= ntain
better the package then ok, i don't mind that. I can't hid= e the fact that the
previous commit pissed me off a little...

Che= ers, Alex.

On Sun, May 12, 2019 at 4:47 PM Kevin Daudt <kdaudt@alpinelinux.org> wrote:
Sad to here this.

It was necessary because the build was failing and only a limited amount of people have access to create snapshots and upload them to dev.

We prefer being able to build packages without having to create archives ourselfs. It just happened that this PR was already available so that
was the quickest way to get things building again.

If you know a way to use the official build system but not having to
rely on creating snapshots, we're happy to use that.

Kind regards, Kevin.

On Sun, May 12, 2019 at 02:07:51PM +0200, Alex Raschi wrote:
> the aport has been rewritten and now uses an unofficial third party bu= ild
> system that i don't want to maintain
> ---
>=C2=A0 testing/telegram-desktop/APKBUILD | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testing/telegram-desktop/APKBUILD b/testing/telegram-desk= top/APKBUILD
> index d951cff246..77770120c5 100644
> --- a/testing/telegram-desktop/APKBUILD
> +++ b/testing/telegram-desktop/APKBUILD
> @@ -1,4 +1,4 @@
> -# Maintainer: Alex Raschi <raschi.alex@gmail.com>
> +# Maintainer:
>=C2=A0 # Contributor: Leo <thinkabit.ukim@gmail.com>
>=C2=A0 pkgname=3Dtelegram-desktop
>=C2=A0 pkgver=3D1.6.7
> --
> 2.21.0
>
>
>
> ---
> Unsubscribe:=C2=A0 alpine-aports+unsubscribe@lists.alpinel= inux.org
> Help:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0alpine-aports+help@lists.a= lpinelinux.org
> ---
>
--00000000000023cbf40588b5b3aa-- --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---