Date: Fri, 26 Oct 2018 16:41:26 +0000
To: Leonardo Arena <rnalrd@gmail.com>
Cc: alpine-aports <alpine-aports@lists.alpinelinux.org>
Subject: Re: [alpine-aports] [PATCH] main/darkhttpd: Fix multiple instances support
From: Milliardo Peacecraft <milliardo@firemail.cc>
References: <F61YXLPGSM.1YB7GLGGYUHJH@firemail.cc> <CAGG_d8Ddf5k1rZsxAT1UZ20WLVTKShU=VuZb7ZCVHQ94gpOWMg@mail.gmail.com>
In-Reply-To: <CAGG_d8Ddf5k1rZsxAT1UZ20WLVTKShU=VuZb7ZCVHQ94gpOWMg@mail.gmail.com>
Message-Id: <F634QGJDOT.26T5QP2YXMFZF@firemail.cc>
Precedence: list

> Looking at sources and man page I think $SVCNAME is deprecated, $RC_SVCNAME
> should be used instead.

I used $SVCNAME because it was what was in use, but I'll change it to
$RC_SVCNAME.

> Also, since it does not run as root it would be preferrable to place the
> pidfile under "/run/darkhttpd" and use "checkpath" from init in order to
> create $rundir with the right uid/gid. Since the pidfile is created by
> openrc, the $pidfile creation is successful anyway in this case.

Should this go in the same patch? It doesn't affects the problem I'm
trying to solve. I can make the other patch if wanted.

> Also please remember to bump $pkgrel in APKBUILD for any change.

Going to. First time contributing so I missed that.

> Thanks!

Thank you for taking the time to review it! I'll send an updated
patch once I hear back from you regarding to make 2 patches or one.

Milliardo


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---