Received: from vps892.directvps.nl (ikke.info [178.21.113.177])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id C56C0782B54
	for <~alpine/aports@lists.alpinelinux.org>; Sun,  6 Dec 2020 16:17:43 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id 60103440133; Sun,  6 Dec 2020 17:17:43 +0100 (CET)
Date: Sun, 6 Dec 2020 17:17:43 +0100
From: Kevin Daudt <kdaudt@alpinelinux.org>
To: Drew DeVault <sir@cmpwn.com>
Cc: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH 2/5] testing/libticables: new aport
Message-ID: <X80EJ8pnKLyUOd2+@alpha>
References: <20201206140248.844-1-sir@cmpwn.com>
 <20201206140248.844-2-sir@cmpwn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201206140248.844-2-sir@cmpwn.com>

On Sun, Dec 06, 2020 at 02:03:42PM +0000, Drew DeVault wrote:
> 
> ---
>  testing/libticables/69-libticables.rules | 18 +++++++++++++
>  testing/libticables/APKBUILD             | 32 ++++++++++++++++++++++++
>  2 files changed, 50 insertions(+)
>  create mode 100644 testing/libticables/69-libticables.rules
>  create mode 100644 testing/libticables/APKBUILD
> 
> diff --git a/testing/libticables/69-libticables.rules b/testing/libticables/69-libticables.rules
> new file mode 100644
> index 0000000000..edf812c30e
> --- /dev/null
> +++ b/testing/libticables/69-libticables.rules
> @@ -0,0 +1,18 @@
> +ACTION!="add", GOTO="libticables_end"
> +
> +# serial device (assume TI calculator)
> +KERNEL=="ttyS[0-3]", ENV{ID_PDA}="1"
> +# parallel device (assume TI calculator)
> +SUBSYSTEM=="ppdev", ENV{ID_PDA}="1"
> +# SilverLink
> +SUBSYSTEM=="usb", ATTR{idVendor}=="0451", ATTR{idProduct}=="e001", ENV{ID_PDA}="1"
> +# TI-84+ DirectLink
> +SUBSYSTEM=="usb", ATTR{idVendor}=="0451", ATTR{idProduct}=="e003", ENV{ID_PDA}="1"
> +# TI-89 Titanium DirectLink
> +SUBSYSTEM=="usb", ATTR{idVendor}=="0451", ATTR{idProduct}=="e004", ENV{ID_PDA}="1"
> +# TI-84+ SE DirectLink
> +SUBSYSTEM=="usb", ATTR{idVendor}=="0451", ATTR{idProduct}=="e008", ENV{ID_PDA}="1"
> +# TI-Nspire DirectLink
> +SUBSYSTEM=="usb", ATTR{idVendor}=="0451", ATTR{idProduct}=="e012", ENV{ID_PDA}="1"
> +
> +LABEL="libticables_end"
> diff --git a/testing/libticables/APKBUILD b/testing/libticables/APKBUILD
> new file mode 100644
> index 0000000000..03ba8d8bd6
> --- /dev/null
> +++ b/testing/libticables/APKBUILD
> @@ -0,0 +1,32 @@
> +# Maintainer:
> +pkgname=libticables
> +pkgver=1.3.5
> +pkgrel=0
> +pkgdesc="Texas Instruments link cable library"
> +url="http://lpg.ticalc.org/prj_tilp/"
> +arch="all"
> +license="GPL-2.0-only"
> +makedepends="bzip2 libusb-dev libtool glib-dev"

This is [missing autoreconf][0]

> +subpackages="$pkgname-dev"
> +source="
> +	$pkgname-$pkgver.tar.bz2::http://downloads.sourceforge.net/project/tilp/tilp2-linux/tilp2-1.18/${pkgname}2-$pkgver.tar.bz2
> +	69-libticables.rules
> +"
> +options="!check" # No upstream tests
> +builddir="$srcdir/${pkgname}2-$pkgver"
> +
> +build() {
> +	cd "$builddir"

This is redundant

> +	autoreconf -if
> +	./configure --prefix=/usr --enable-libusb10
> +}
> +
> +package() {
> +	make install DESTDIR="$pkgdir"
> +	rm -rf "$pkgdir"/usr/share/locale
> +	install -Dm644 "$srcdir/69-libticables.rules" \
> +		"$pkgdir/usr/lib/udev/rules.d/69-libticables.rules"
> +}
> +
> +sha512sums="171abdf41f496891c62da17a2b84d929ac32021b0f2abc0c37ed73ec93806d4a14df37a8ffbe2b0c172ff3461aa6c639fc1ba23aafb19e024b99448dd66c63bd  libticables-1.3.5.tar.bz2
> +423e0fcf072e7f4460ca00dedcc8839c3e22515f353813a058324dff0624c1eebcbd2385ca425fad351262520a30309d6d2a3148e4c0a5ec326eddb1428dbe1c  69-libticables.rules"
> -- 
> 2.29.2

[0]:https://gitlab.alpinelinux.org/kdaudt/aports/-/jobs/264068#L161