Received: from vps892.directvps.nl (ikke.info [178.21.113.177])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 7EAB0781EA0
	for <~alpine/aports@lists.alpinelinux.org>; Sun,  6 Dec 2020 16:17:51 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id 47AB5440131; Sun,  6 Dec 2020 17:17:51 +0100 (CET)
Date: Sun, 6 Dec 2020 17:17:51 +0100
From: Kevin Daudt <kdaudt@alpinelinux.org>
To: Drew DeVault <sir@cmpwn.com>
Cc: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH 3/5] testing/libticonv: new aport
Message-ID: <X80EL6VlWryzPG1P@alpha>
References: <20201206140248.844-1-sir@cmpwn.com>
 <20201206140248.844-3-sir@cmpwn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201206140248.844-3-sir@cmpwn.com>

On Sun, Dec 06, 2020 at 02:03:43PM +0000, Drew DeVault wrote:
> 
> ---
>  testing/libticonv/APKBUILD | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 testing/libticonv/APKBUILD
> 
> diff --git a/testing/libticonv/APKBUILD b/testing/libticonv/APKBUILD
> new file mode 100644
> index 0000000000..0fa52bcb9f
> --- /dev/null
> +++ b/testing/libticonv/APKBUILD
> @@ -0,0 +1,25 @@
> +# Maintainer:
> +pkgname=libticonv
> +pkgver=1.1.5
> +pkgrel=0
> +pkgdesc="Texas Instruments character set conversion library"
> +url="http://lpg.ticalc.org/prj_tilp/"
> +arch="all"
> +license="GPL-2.0-only"
> +makedepends="bzip2 glib-dev libtool"

This is [missing autoreconf][0]

> +subpackages="$pkgname-dev"
> +source="$pkgname-$pkgver.tar.bz2::http://downloads.sourceforge.net/project/tilp/tilp2-linux/tilp2-1.18/$pkgname-$pkgver.tar.bz2"
> +options="!check" # No upstream tests
> +
> +build() {
> +	cd "$builddir"

Redudant

> +	autoreconf -if
> +	./configure --prefix=/usr --enable-iconv
> +}
> +
> +package() {
> +	make install DESTDIR="$pkgdir"
> +	rm -rf "$pkgdir"/usr/share/locale
> +}
> +
> +sha512sums="ea589344a656c5c7d28ed45e8da36bf7b746b7a82d77a257ddd305e2ebdc34f0ae14a6090e991f47ef7ad37cdc8d7182181c705fb0814e671ef764ca2a6dc2bf  libticonv-1.1.5.tar.bz2"
> -- 
> 2.29.2

[0]:https://gitlab.alpinelinux.org/kdaudt/aports/-/jobs/264068#L312