Received: from theta.ikke.info (theta.ikke.info [178.21.117.236])
	by gbr-app-1.alpinelinux.org (Postfix) with ESMTPS id 73E462236C0
	for <alpine-aports@lists.alpinelinux.org>; Wed,  4 Jan 2023 06:41:27 +0000 (UTC)
Received: from 1e0710366712 (mutt_mutt_run_e99c3363f9c6.postfix_default [192.168.80.4])
	by theta.ikke.info (Postfix) with ESMTPS id 423E014081C;
	Wed,  4 Jan 2023 06:39:44 +0000 (UTC)
Date: Wed, 4 Jan 2023 06:39:44 +0000
From: Kevin Daudt <kdaudt@alpinelinux.org>
To: IP2Location Customer Success <support@ip2location.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [#GJN-886-58677]: [PATCH] testing/ip2location: new aport
Message-ID: <Y7UfMJjQQiDMU/JJ@1e0710366712>
References: <34c327b642c0bbf3428992bfc89efed2@kayako.hexasoft.com.my>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <34c327b642c0bbf3428992bfc89efed2@kayako.hexasoft.com.my>

On Wed, Jan 04, 2023 at 10:47:32AM +0800, IP2Location Customer Success wrote:
> https://www.ip2location.com/development-libraries/ip2location/c
> Lookup country, region and city information by IP addresses
> ---
>  testing/ip2location/APKBUILD | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 testing/ip2location/APKBUILD
> 
> diff --git a/testing/ip2location/APKBUILD b/testing/ip2location/APKBUILD
> new file mode 100644
> index 0000000000..bb96dcc7eb
> --- /dev/null
> +++ b/testing/ip2location/APKBUILD
> @@ -0,0 +1,31 @@
> +# Maintainer: IP2Location <support@ip2location.com>
> +pkgname=ip2location
> +_pkgname="IP2Location"
> +pkgver=8.5.1
> +pkgrel=1
> +pkgdesc="Lookup country, region and city information by IP addresses"
> +url="https://www.ip2location.com/development-libraries/ip2location/c"
> +arch="all"
> +license="GPL"

We use [SPDX license designations][0], so you'd have to be more specific
than just GPL, but if I look at the github repo, the license seems to be
MIT?

> +makedepends="autoconf zlib-dev"

automake is missing

> +subpackages="$pkgname-dev"
> +source="https://github.com/chrislim2888/IP2Location-C-Library/archive/refs/tags/$pkgver.zip"
> +builddir="$srcdir"/IP2Location-C-Library-$pkgver
> +
> +build() {
> +       autoreconf -i -v --force

This should be added in the prepare phase:

  prepare() {
  	default_prepare
  
  	autoreconf -i -v --force
  }

> +       ./configure
> +       make
> +}
> +
> +package() {
> +       make install
> +}
> +
> +check() {
> +       make check
> +}

Just a minor issue, but we typically put the check phase after build and before
package to match the actual execution order.

> +
> +sha512sums="
> +f6bebed88957eb17a5d2eb781808aa755f10ebbffe2cbd21d6c4fe7ece8dedd18ba784fb95ed05f92626c5931a4e5e66cc8a7440389331e3e34eb00c3a523445  8.5.1.zip
> +"
> -- 
> 2.38.2
> 
> 
> Regards,
> 
> SK Kiu
> IP2Location Customer Success Team
> Hexasoft Development Sdn Bhd
> Website: https://www.ip2location.com
> Facebook: https://www.facebook.com/ip2location
> Twitter: https://www.twitter.com/ip2location

Created a merge request:
https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/42862

[0]:https://spdx.org/licenses/