Date: Sat, 9 Mar 2024 18:48:32 +0100
From: Alejandro Colomar <alx@alejandro-colomar.es>
To: ~alpine/aports@lists.alpinelinux.org, datacobra@thinkbot.de
Cc: ~hallyn/shadow@lists.sr.ht
Subject: shadow 4.14 build errors on Alpine Linux
Message-ID: <Zeyg8ClVMNeRifua@debian>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Eay91h/XIdQBprH2"
Content-Disposition: inline


--Eay91h/XIdQBprH2
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sat, 9 Mar 2024 18:48:32 +0100
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Alejandro Colomar <alx@alejandro-colomar.es>
To: ~alpine/aports@lists.alpinelinux.org, datacobra@thinkbot.de
Cc: ~hallyn/shadow@lists.sr.ht
Subject: shadow 4.14 build errors on Alpine Linux

Hi,

I've noticed both Alpine Linux has a patch
<fix-undefined-reference.patch> for shadow, and that Void Linux
considered picking it.

The most likely reason for that patch was the bug reported by Gentoo:
<https://github.com/shadow-maint/shadow/issues/791>
and fixed in 4.14.1:
<https://github.com/shadow-maint/shadow/pull/792>
<https://github.com/shadow-maint/shadow/pull/794>

We never knew why it failed.  It was an obscure problem with the
autotools-based build system.  But we fixed it with the big hammer.

Please drop that patch, since the issue has been fixed upstream.  And
please report any build errors upstream.

Have a lovely day!
Alex

---

See the release annotations, which document the fix:

	$ git show 4.14.1
	tag 4.14.1
	Tagger: Alejandro Colomar <alx@kernel.org>
	Date:   Mon Sep 25 18:00:29 2023 +0200

	shadow-4.14.1 (Cas=C3=ADn) - shadow utils

	Bugfix release.  Changes since shadow-4.14.0:

	shadow-4.14.1:

	-  Build system:
>	   -  Merge libshadow and libmisc into a single libshadow.  This fixes
>	      problems in the linker, which were reported at least in Gentoo.

And also documented in 4.15.0:

	$ git show 4.15.0
	tag 4.15.0
	Tagger: Serge Hallyn <serge@hallyn.com>
	Date:   Fri Mar 8 16:06:06 2024 -0600

	Release 4.14.0: dubliner

	-  libshadow:
	   -  Use utmpx instead of utmp.  This fixes a regression introduced in
	      4.14.0.
	   -  Fix build error (parameter name omitted).
	-  Build system:
	   -  Link correctly with libdl.
	   -  Install pam configs for chpasswd(8) and newusers(8) when using
	      `./configure --with-libpam --disable-account-tools-setuid`.
>	   -  Merge libshadow and libmisc into a single libshadow.  This fixes
>	      problems in the linker, which were reported at least in Gentoo.
	   -  Fix build with musl libc.
	   -  Support out of tree builds
	-  useradd(8):
	   -  Set proper SELinux labels for def_usrtemplate


--=20
<https://www.alejandro-colomar.es/>

--Eay91h/XIdQBprH2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmXsoPAACgkQnowa+77/
2zKWuA//SrVA7lKJYsr/g5hxLd6CIHbInfYOsXncK7DUXI279Ajkhj9Z2lWXn2CA
jQxe23FWsUEsLJ/1GxI7v6SAT8E9RbBaDE3FAB6gMETfrkFpiODwx+lmH6TfTfbG
mM5kPD3M1PTWN53h+sYONM+fMdAupvih1c+zuripRiiZoniaIXKK9nbqL0qSbthJ
YDVeEA49Clj4VZRcTfk1qfPELClYLsodEuK6hB2NIIjmsuvK7K/1Gj9VHaro0Rh6
OGIS8hU0Mu7q9mPYz9HzpapQ+GLxLyzLpaSQG2lqMndnKV1EiTGZADKJqdgDN3t3
f9yjH1dPufRKezfudP883uvsdYwBPMIaRjiEmughOrd0GRGIb1B2XraDh6esdr+P
EMq5OLoiljIuusFqtJKm2/aJLcq6W1l/PAFogHCx9WtQ531nynBInYyvoqxYTyaV
DcZ/Pku5havs1M4l0KP9D8uHDGVtEZOVUPs6zCkGapCqCeM7hOWwU+0QDo992GCh
7ivCAWG/URnZfq/yzua5UsWDPbPIXTJa+f38p9bE+AmX0t8DKkfSxRWNdiBHYIXB
exV4jUQbCu6Pku5uqiZjpUnHVTCfx/g1xAIBdXnmoZ2eWCvLx/pkjN6AhMb3AZbW
AmHLoPUyJTdU0uhUg+StFWtgFsLcIb1PAdFTKb9Rq6lPcfrDvnY=
=/9cw
-----END PGP SIGNATURE-----

--Eay91h/XIdQBprH2--