Date: Sat, 9 Mar 2024 18:51:27 +0100
From: Alejandro Colomar <alx@kernel.org>
To: ~alpine/aports@lists.alpinelinux.org, datacobra@thinkbot.de
Cc: ~hallyn/shadow@lists.sr.ht
Subject: Re: shadow 4.14 build errors on Alpine Linux
Message-ID: <ZeyhoPLu42vjSfWL@debian>
References: <Zeyg8ClVMNeRifua@debian>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NyyiIHuJk7yXNaXY"
Content-Disposition: inline
In-Reply-To: <Zeyg8ClVMNeRifua@debian>


--NyyiIHuJk7yXNaXY
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Sat, 9 Mar 2024 18:51:27 +0100
From: Alejandro Colomar <alx@kernel.org>
To: ~alpine/aports@lists.alpinelinux.org, datacobra@thinkbot.de
Cc: ~hallyn/shadow@lists.sr.ht
Subject: Re: shadow 4.14 build errors on Alpine Linux

Oops, I've sent from the wrong address; please reply to this one.

On Sat, Mar 09, 2024 at 06:48:32PM +0100, Alejandro Colomar wrote:
> Hi,
>=20
> I've noticed both Alpine Linux has a patch
> <fix-undefined-reference.patch> for shadow, and that Void Linux
> considered picking it.
>=20
> The most likely reason for that patch was the bug reported by Gentoo:
> <https://github.com/shadow-maint/shadow/issues/791>
> and fixed in 4.14.1:
> <https://github.com/shadow-maint/shadow/pull/792>
> <https://github.com/shadow-maint/shadow/pull/794>
>=20
> We never knew why it failed.  It was an obscure problem with the
> autotools-based build system.  But we fixed it with the big hammer.
>=20
> Please drop that patch, since the issue has been fixed upstream.  And
> please report any build errors upstream.
>=20
> Have a lovely day!
> Alex
>=20
> ---
>=20
> See the release annotations, which document the fix:
>=20
> 	$ git show 4.14.1
> 	tag 4.14.1
> 	Tagger: Alejandro Colomar <alx@kernel.org>
> 	Date:   Mon Sep 25 18:00:29 2023 +0200
>=20
> 	shadow-4.14.1 (Cas=C3=ADn) - shadow utils
>=20
> 	Bugfix release.  Changes since shadow-4.14.0:
>=20
> 	shadow-4.14.1:
>=20
> 	-  Build system:
> >	   -  Merge libshadow and libmisc into a single libshadow.  This fixes
> >	      problems in the linker, which were reported at least in Gentoo.
>=20
> And also documented in 4.15.0:
>=20
> 	$ git show 4.15.0
> 	tag 4.15.0
> 	Tagger: Serge Hallyn <serge@hallyn.com>
> 	Date:   Fri Mar 8 16:06:06 2024 -0600
>=20
> 	Release 4.14.0: dubliner
>=20
> 	-  libshadow:
> 	   -  Use utmpx instead of utmp.  This fixes a regression introduced in
> 	      4.14.0.
> 	   -  Fix build error (parameter name omitted).
> 	-  Build system:
> 	   -  Link correctly with libdl.
> 	   -  Install pam configs for chpasswd(8) and newusers(8) when using
> 	      `./configure --with-libpam --disable-account-tools-setuid`.
> >	   -  Merge libshadow and libmisc into a single libshadow.  This fixes
> >	      problems in the linker, which were reported at least in Gentoo.
> 	   -  Fix build with musl libc.
> 	   -  Support out of tree builds
> 	-  useradd(8):
> 	   -  Set proper SELinux labels for def_usrtemplate
>=20
>=20
> --=20
> <https://www.alejandro-colomar.es/>



--=20
<https://www.alejandro-colomar.es/>

--NyyiIHuJk7yXNaXY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmXsoZ8ACgkQnowa+77/
2zIbSw//ZZHVbenWQL4b6qkXEI8do/dJ+s3xQE2K0h5rSrJC+jo7jGeCvY0wkV6S
+A83li5YerjIFEG3Lca1DsOV566u1OulyKy/h1lONjf+qkROykM2JbahOBkAcRVX
sXRbBogJQ1qVXXn2kouLnY5XPTk0qKuOtvZreKNAa6IGkwDcwTNqRyAyYUYSKpUQ
7ftQcZb7+3Qx258oVekQwo++s2mbPGGIEi7NqxfzrjW2TYVSkR3MZ0ATJVggrfjH
m0xy7kKOacClM8HF/UT8GHa1bffE3VCWIQoOb7kNj5CMT1pSbBR57sDrTc3QKG1f
558+kCFwR4hp3sUI7poSJS64aqxjnmfuXlvaiRuG7hOPf1TYXMyQtrXh//P39lvn
qPrtX+UqhK72qIQyUU4L0QxqGBsb864bFMU9lxQUzE4vwSdM7JRqJcECn40GU0Xc
LDTnyMtpMp2sAR+9aIAogv/glWuWo7QMnPAhjLfmO/nvt5w8GMq8WUJUOKHiaqU8
tLb98ZNgYVd0d7evzSLkAeVAYqLjENazHDnh4KrIHIFj9JiGJjUGjA3mtyNNFTCg
L+KKVJ/9Q+BPMy391/6qnWCYvjAUdjJHctfpijur2bdOWMvwAPQiczqjT+oKpRAS
hz04Z2fSqsgEpKgdC/d+FJ/trDTUGUuvq3rbKSPZH6+Bd6sprS0=
=m5ZJ
-----END PGP SIGNATURE-----

--NyyiIHuJk7yXNaXY--