DomainKey-Signature: a=rsa-sha1; c=nofws; d=toastin.space; h=subject:to
	:references:from:message-id:date:mime-version:in-reply-to
	:content-type:content-transfer-encoding; q=dns; s=ml; b=QXg4UwM6
	XFxK+PC2Coe50Y1GFuSe14qWUyQXbibDY/DT9Ee79wqiZmotcK8p8mpMtKezOiQM
	uOYxfZuWtffZ9KIfNcpz8UQP4aBB0fYhe8hmJtYaJt0YKIDZZSA+SrvssjiDG+HI
	pngc2aFCwAYDa76vq9qTxWjqCTn+G7zSMECHUW/HfQ/ohJXaivc5+SJxgA/PulXZ
	qCH/7dI9kUEYlgQ2g/MI5h7Y9YAGVKsC37h4R6XZHArDNFR52Z03PnyjZGwC1A88
	NMCNsIReXdrPy2s4TAcnQGHnjEMl/O4LROWUDCZ1qw1k22FA+WWSHka5bRosAYso
	cAQmztA+i5HWGg==
Subject: Re: [alpine-aports] [PATCH] community/fzf: Add neovim subpackage
To: alpine-aports@lists.alpinelinux.org
References: <20190305160038.8234-1-theothermatt@gmail.com>
From: Chloe Kudryavtsev <toast@toastin.space>
Message-ID: <bf6fc52a-f8e9-e88b-3c59-fc44f20b31b0@toastin.space>
Date: Tue, 5 Mar 2019 15:54:09 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:66.0) Gecko/20100101
 Thunderbird/66.0
Precedence: list
MIME-Version: 1.0
In-Reply-To: <20190305160038.8234-1-theothermatt@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 3/5/2019 11:00 AM, Matt Hill wrote:
> Basic integration for Neovim

>
> +	$pkgname-neovim:nvim:noarch

> +nvim() {
> +	pkgdesc="fzf vim plugin"
> +	cd "$builddir"
> +	mkdir -p "$subpkgdir"/usr/share/nvim/runtime/plugin/
> +	install -Dm0644 plugin/fzf.vim "$subpkgdir"/usr/share/nvim/runtime/plugin/
> +}
> +

Shouldn't this be s/nvim/vim/?
Iirc, nvim can take advantage of vim's runtime, but not vice-versa.
The plugin works for both, so we should either install the file twice, 
or once, but for vim.

Also, I'd imagine we want an install_if, so it's autoinstalled when 
vim/nvim *and* fzf are installed.
(note that the above is an argument for having two subpackages).


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---