Subject: Re: [PATCH v2] testing/telegraf: fix package setup
To: Galen Abell <galen@galenabell.com>, alpine-aports@lists.alpinelinux.org
References: <20200104193337.20034-1-galen@galenabell.com>
 <20200105174752.15708-1-galen@galenabell.com>
From: Konstantin Kulikov <k.kulikov2@gmail.com>
Message-ID: <c1cc91cb-3a20-0ee5-0985-1f19c5d2626d@gmail.com>
Date: Mon, 6 Jan 2020 04:20:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200105174752.15708-1-galen@galenabell.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 1/5/20 8:47 PM, Galen Abell wrote:
> Telegraf's conf.d command line uses the additional config directory
> `telegraf.d`, but the package installs the directory `telegraf.conf.d`.
> ---
> Bumped pkgrel (oops), switched -config-directory to /etc/telegraf.conf.d
> rather than changing created directory.
> 
>   testing/telegraf/APKBUILD       | 2 +-
>   testing/telegraf/telegraf.confd | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/testing/telegraf/APKBUILD b/testing/telegraf/APKBUILD
> index 7ede05c220..cb0cb4c1a0 100644
> --- a/testing/telegraf/APKBUILD
> +++ b/testing/telegraf/APKBUILD
> @@ -2,7 +2,7 @@
>   # Maintainer: Konstantin Kulikov <k.kulikov2@gmail.com>
>   pkgname=telegraf
>   pkgver=1.13.0
> -pkgrel=0
> +pkgrel=1
>   pkgdesc="A plugin-driven server agent for collecting & reporting metrics, part of the InfluxDB project"
>   url="https://www.influxdata.com/time-series-platform/telegraf/"
>   arch="x86_64 aarch64"
> diff --git a/testing/telegraf/telegraf.confd b/testing/telegraf/telegraf.confd
> index b29a46ea2a..bf6a22907d 100644
> --- a/testing/telegraf/telegraf.confd
> +++ b/testing/telegraf/telegraf.confd
> @@ -1,4 +1,4 @@
> -TELEGRAF_OPTS="-config /etc/telegraf.conf -config-directory /etc/telegraf.d"
> +TELEGRAF_OPTS="-config /etc/telegraf.conf -config-directory /etc/telegraf.conf.d"
>   
>   # Uncomment to enable logging to syslog.
>   #error_logger="logger -t $RC_SVCNAME"
> 

Looks good. Thanks.