Subject: Re: [PATCH] community/alertmanager: fix LDFLAGS issues
To: Drew DeVault <sir@cmpwn.com>, ~alpine/aports@lists.alpinelinux.org
References: <20200109191055.15187-1-sir@cmpwn.com>
From: Konstantin Kulikov <k.kulikov2@gmail.com>
Message-ID: <d4003b89-b915-a0c9-a5b7-f9e7e74dfab9@gmail.com>
Date: Thu, 9 Jan 2020 22:51:14 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200109191055.15187-1-sir@cmpwn.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 1/9/20 10:10 PM, Drew DeVault wrote:
> This should(?) fix the build on aarch64.
> ---
>   community/alertmanager/APKBUILD | 31 ++++++++++++++-----------------
>   1 file changed, 14 insertions(+), 17 deletions(-)
> 
> diff --git a/community/alertmanager/APKBUILD b/community/alertmanager/APKBUILD
> index e61bbb2526..c585d43871 100644
> --- a/community/alertmanager/APKBUILD
> +++ b/community/alertmanager/APKBUILD
> @@ -1,7 +1,7 @@
>   # Maintainer: Drew DeVault <sir@cmpwn.com>
>   pkgname=alertmanager
>   pkgver=0.20.0
> -pkgrel=0
> +pkgrel=1
>   pkgdesc="Prometheus Alertmanager"
>   url="https://github.com/prometheus/alertmanager"
>   arch="all"
> @@ -18,22 +18,19 @@ builddir="$srcdir/$pkgname-$pkgver"
>   options="!check" # timing-sensitive upstream tests
>   
>   build() {
> -	ldflags="-extldflags $LDFLAGS \
> -			-X github.com/prometheus/common/version.Version=$pkgver \
> -			-X github.com/prometheus/common/version.Revision=$pkgrel \
> -			-X github.com/prometheus/common/version.Branch=Alpine \
> -			-X github.com/prometheus/common/version.BuildUser=Alpine \
> -			-X github.com/prometheus/common/version.BuildDate=2020-01-08"
> -	go build \
> -		-trimpath \
> -		-mod=vendor \
> -		-ldflags "$ldflags" \
> -		./cmd/alertmanager
> -	go build \
> -		-trimpath \
> -		-mod=vendor \
> -		-ldflags "$ldflags" \
> -		./cmd/amtool
> +	for cmd in amtool alertmanager
> +	do
> +		go build \
> +			-trimpath \
> +			-mod=vendor \
> +			-ldflags "-extldflags $LDFLAGS \

I think LDFLAGS on aarch64 contains spaces and -extldflags expects 
single argument. My suggestion to remove ldflags var was incorrect, as 
whole argument to -ldflags still needs to be quoted.

To properly quote this string it is best to replace -extldflags $LDFLAGS
with -extldflags $(printf %q "$LDFLAGS").

If you're adamant against using printf, \"$LDFLAGS\" should work as long 
as contents of $LDFLAGS doesn't contain double quotes.

> +				-X github.com/prometheus/common/version.Version=$pkgver \
> +				-X github.com/prometheus/common/version.Revision=$pkgrel \
> +				-X github.com/prometheus/common/version.Branch=Alpine \
> +				-X github.com/prometheus/common/version.BuildUser=Alpine \
> +				-X github.com/prometheus/common/version.BuildDate=2020-01-08" \
> +			./cmd/$cmd
> +	done
>   }
>   
>   check() {
>