You committed this to main/ new packages should stay in testing/ for
a while. Furthermore, the commit message should be "testing/google-glog:
new aport". In addition to that: Why did you call the package
google-glog instead of simply calling it glog?
On 01.09.15, Michael Venezia wrote:
I am pretty sure that glog works on x86 and possibly arm too. Please
adjust this accordingly. If it works on arm and x86 too you can simply
use arch="all".
On 01.09.15, Michael Venezia wrote:
This notation is really strange, either use custom and install the
license file into /usr/share/licenses or use license="BSD". I would
prefer the former.
On 01.09.15, Michael Venezia wrote:
Two things: a) depends_dev is supposed to be used for -dev packages only,
those two package should theoretically be makedepends b) You don't need
to explicitly depend on make and gcc since they are both a part of
alpine-sdk and are thus installed by abuild(1) by default.
On 01.09.15, Michael Venezia wrote:
+makedepends="$depends_dev"+install=""+subpackages="$pkgname-dev $pkgname-doc"+source="glog-$pkgver.tar.gz::https://github.com/google/glog/archive/v$pkgver.tar.gz"++_builddir=+prepare() {+ local i+ cd "$_builddir"+ for i in $source; do+ case $i in+ *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;+ esac+ done+}++build() {+ cd "$srcdir/glog-${pkgver}"+ ./configure --prefix=/usr+ make+}++package() {+ cd "$_builddir"+ cd "$srcdir/glog-${pkgver}"+ make DESTDIR="$pkgdir" install++ find "$pkgdir" -name '*.la' -delete+}
As you can see the indention is completely broken here. Besides you
don't need to remove *.la files manually since abuild(1) automatically
removes them unless you enable the libtool option. Also why do you cd
into the undefined "$_builddir" here? That doesn't make any sense at
all.
S�ren.
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---