Hello Raman, thanks for your contribution.
Patch applies, but package does not build because libssh2-dev is
missing.
Besides that, there are some aspects that can be improved.
Please see the inline comments:
Rather than using static name and version, is better to use variables.
In this way, it's enough to change the package version only in one
place.
Specifically
> pkgname=php-ssh2
> pkgver=0.12
This two variables can be used in the source entry.
Just pay attention that the package is called "php-ssh2", while the link
is ssh2.
This can be also "optimized" by using:
_pkgname=${pkgname/*-/}
In this way, you can have the source file like:
> +source="http://pecl.php.net/get/$_pkgname-$pkgver.tgz ssh2.ini"
This can be improved by using _builddir variable, by setting:
_builddir = "$srcdir/"/$_pkgname-$pkgver
and then in build() and prepare() function you can simply put:
cd $_builddir
Can you please resend the patch with the correct dependencies?
Thanks!
--
:: Francesco Colista
:: Alpine Linux Infrstraucture
:: http://www.alpinelinux.org
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---