Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
Subject: Re: Fixing shell script libraries like /lib/libalpine.sh
From: Kaelan Thijs Fouwels <kaelan@fouwels.com>
In-Reply-To: <Yr1TRebPEJ/SfWoG@codewreck.org>
Date: Thu, 30 Jun 2022 08:47:51 +0100
Cc: "Daniel F. Dickinson" <dfdpublic@wildtechgarden.ca>,
 ~alpine/devel@lists.alpinelinux.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0B490FC5-4BE5-4047-8552-AD50580BD622@fouwels.com>
References: <4caa8c5f-7ebf-ad2f-0e92-29428785fe60@wildtechgarden.ca>
 <Yr1Lll3DNQGGeAGt@codewreck.org>
 <2512fab8-7ae4-c554-32a9-333a2b08813c@wildtechgarden.ca>
 <Yr1TRebPEJ/SfWoG@codewreck.org>
To: Dominique Martinet <asmadeus@codewreck.org>



> On 30 Jun 2022, at 08:39, Dominique Martinet <asmadeus@codewreck.org> =
wrote:
>=20
> Daniel F. Dickinson wrote on Thu, Jun 30, 2022 at 03:31:50AM -0400:
>> This calls setup-ntp with NTPOPTS as the parameter; perhaps the issue =
is
>> the quoting there. In any event, I've obviously got to do some more
>> complete troubleshooting, fix, and test thereof.
>=20
> The problem is setup-ntp sets 'resp' from parsing -c in getopts loop,
> but actually expects it to be the first positional parameter e.g.
> 'setup-ntp chrony' as it checks $# and assigns resp from $1 regardless
> of $#.
>=20
> It shouldn't be too hard to make it work with either -c or first
> positional parameter, letting you send a MR on gitlab :)
>=20
>=20
> (oh, and I use reply to all and think most others do as well -- but I
> don't know if it really is a rule or just habits from other lists =
where
> non-subscribers can post)
> --
> Dominique

I've previously attempted to diagnose this exact issue to no avail in =
our internal builds, so can second this problem during automated ANSWERS =
installed.

Daniel, if you have identified the root cause, PR would be most welcome!

Kaelan Thijs Fouwels
Kaelan@fouwels.com