DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=uM5cB38CgqRfOqCeod4pm1gcl/lT3PgiNg+qo68kXDO+gCs3nbW2aUXHWkaO7HcDtK
         hhh9R6orfGfNAxwbsmBn6Oh+Doc9WhVJIfzaO326fMSKfIAc8tsXsCKkxELvLmVdCk15
         jC/PSuVRp9mmKtP+Kb5tTl+vMPE/LM3exG7hM=
Subject: Re: [alpine-devel] new aport apcupsd
From: Natanael Copa <natanael.copa@gmail.com>
To: Leonardo Arena <rnalrd@gmail.com>
Cc: Alpine-devel <alpine-devel@lists.alpinelinux.org>
In-Reply-To: <9334be8a0901210253g7fd84172m78626db868552121@mail.gmail.com>
References: <9334be8a0901210253g7fd84172m78626db868552121@mail.gmail.com>
Content-Type: text/plain
Date: Wed, 21 Jan 2009 14:09:21 +0100
Message-Id: <1232543361.1947.178.camel@nc>
Precedence: list
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit



On Wed, 2009-01-21 at 11:53 +0100, Leonardo Arena wrote:
> Please review attached patch
> 
> Leo 

Thanks!

...

> 
> 
> 
> 
> +depends="uclibc util-linux-ng"
> +makedepends="g++"
> +source="http://surfnet.dl.sourceforge.net/sourceforge/apcupsd/apcupsd-3.14.5.tar.gz"

please use download.sourceforge.net rather than a specific sf mirror.
Also, if you use $pkgver in the source url, then you only need to change
the version number in pkgver when upgrading the package.

source="http://downloads.sourceforge.net/$pkgname/$pkgname-$pkgver.tar.gz"

> +
> +build() {
> +       cd "$srcdir/$pkgname-$pkgver"
> +
> +       ./configure --prefix=/usr \
> +       --mandir=/usr/share/man
> +       --enable-usb
> +       make || return 1
> +       make DESTDIR=$pkgdir install
> +}
> +
> +md5sums="4ac73ec91d8ab56f3fac894e172567c4  apcupsd-3.14.5.tar.gz"
> -- 
> 1.6.1
> 

Otherwise looks good. It needs an init.d script i suppose and we need to
check up if we can use busybox halt rather than depend on util-linux-ng
shutdown.

Hm... it looks like it needs 'wall'. Maybe just keep that util-linux-ng
there.

I alos copied the init.d script from gentoo.

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---