X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@lists.alpinelinux.org
Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10])
	by lists.alpinelinux.org (Postfix) with ESMTP id 2EA9F170000BA
	for <alpine-devel@lists.alpinelinux.org>; Mon, 26 Jan 2009 10:14:06 +0000 (UTC)
Received: by ewy3 with SMTP id 3so6959602ewy.1
        for <alpine-devel@lists.alpinelinux.org>; Mon, 26 Jan 2009 02:14:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:subject:from:to:cc
         :in-reply-to:references:content-type:date:message-id:mime-version
         :x-mailer:content-transfer-encoding;
        bh=IH7rKwTnewPFJ0SEdjXqtwGMxHrjLL15Gn6FzZ4RbPY=;
        b=l0Rkua5WYJRJKHblLtBaD59As6VmArIcl4ZQC1Wcge5gtD1/yjtX4k7B3QCBFMYI1s
         QOrywtK1G2HcS2GUunBaxBpKsnrIWOGWlw/W4R047HgiLHKZgGLsJYnNN5PHpVczxADh
         PiwEDt7yeVZPNdv6SJa4u6z78gRs6rchSQjvw=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=lIGSQ1Mo16OKYEhnMDgHqVyeuf8/H1dvIAUvHjEW29ULbTXbq4SsVnFC3jWVlEnWXT
         68c8GObb9s19rs2fvTq90pXOxVny4V1L/VlF4lj9xOsfO8VhC1YqRTBR79k7edR9lfIY
         /5ZG8zVtiRrNKSXdLXOGgFJWupDzQ19qFKa7k=
Received: by 10.210.42.13 with SMTP id p13mr1815334ebp.87.1232964844648;
        Mon, 26 Jan 2009 02:14:04 -0800 (PST)
Received: from ?10.65.65.1? (149-182-13.oke2-bras2.adsl.tele2.no [90.149.182.13])
        by mx.google.com with ESMTPS id 7sm14592824eyb.41.2009.01.26.02.14.03
        (version=SSLv3 cipher=RC4-MD5);
        Mon, 26 Jan 2009 02:14:03 -0800 (PST)
Subject: Re: [alpine-devel] new aport ncftp
From: Natanael Copa <natanael.copa@gmail.com>
To: Carlo Landmeter <clandmeter@gmail.com>
Cc: alpine <alpine-devel@lists.alpinelinux.org>
In-Reply-To: <20090125130403.C5F04187C69@smtp01.prioritytelecom.nl>
References: <20090125130403.C5F04187C69@smtp01.prioritytelecom.nl>
Content-Type: text/plain
Date: Mon, 26 Jan 2009 11:14:01 +0100
Message-Id: <1232964841.28748.184.camel@nc>
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
X-Mailer: Evolution 2.24.2 
Content-Transfer-Encoding: 7bit

On Sun, 2009-01-25 at 13:04 +0000, Carlo Landmeter wrote:
> New aport ncftp. Please see attached git patch.

cool!

> 
> Natanael, I still kept the license as arch does.
> If you have a new way of doing it please let me know and ill update
> the apkbuild.

ok. no i dont have any good idea how to deal with it.

> 
> Carlo
> 
> 
> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (0001-extra-ncftp-new-aport.patch)
> 
> From d45adc6f3afe454bbfac9b58ec794daca7b96dfb Mon Sep 17 00:00:00 2001
> From: Carlo Landmeter <clandmeter@gmail.com>
> Date: Sun, 25 Jan 2009 13:00:35 +0000
> Subject: [PATCH] extra/ncftp: new aport
> 
> ---
>  extra/ncftp/APKBUILD |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+), 0 deletions(-)
>  create mode 100644 extra/ncftp/APKBUILD
> 
> diff --git a/extra/ncftp/APKBUILD b/extra/ncftp/APKBUILD
> new file mode 100644
> index 0000000..3edb234
> --- /dev/null
> +++ b/extra/ncftp/APKBUILD
> @@ -0,0 +1,22 @@
> +# Maintainer: Carlo Landmeter <clandmeter at gmail>
> +pkgname=ncftp
> +pkgver=3.2.2
> +pkgrel=0
> +pkgdesc="A set of free application programs implementing FTP"
> +url="http://www.ncftp.com/"
> +license="custom"
> +depends="ncurses"
> +makedepends=""

If ncurses is linked in, then it will most likely need the ncurses-dev
package during buildtime so it should be added to makedepends.

> +source="ftp://ftp.$pkgname.com/$pkgname/$pkgname-$pkgver-src.tar.bz2"

The packages contains manpages. We should have a -doc subpackage.

> +
> +build () 
> +{ 
   ^^^
git complained about trailing whitespace in the row here over.

> +       cd ${srcdir}/${pkgname}-${pkgver} || return 1

If we consequesntly quote the "$srcdir" and "$pkgdir" will we be able to
build the stuff from paths with spaces. If not, things might break if a
parend directory name contains spaces.

> +       install -d ${pkgdir}/usr/share | return 1
> +       ./configure --prefix=/usr --sysconfdir=/etc || return 1
> +       make || return 1
> +       make prefix=${pkgdir}/usr mandir=${pkgdir}/usr/share/man
> install || return 1

make install seems to respect DESTDIR. So we set the mandir
with ./configure and use only 'make DESTDIR="$pkgdir" install'

> +       install -D doc/LICENSE.txt
> ${pkgdir}/usr/share/licenses/${pkgname}/LICENSE || return 1
> +}
> +
> +md5sums="b2b4b2fd38c81754b8f13895d784d491  ncftp-3.2.2-src.tar.bz2"
> -- 
> 1.6.1

I know it is details, but I think we can do better than Arch linux :)

I committed your patch and did the above changes.

Thanks alot!

btw. I have a cronjob that updates this list of packages needing to be
ported:
http://dev.alpinelinux.org/~ncopa/alpine/pkg-todo.txt


-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---