X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@lists.alpinelinux.org
Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10])
	by lists.alpinelinux.org (Postfix) with ESMTP id A191317005F2C
	for <alpine-devel@lists.alpinelinux.org>; Mon,  9 Feb 2009 08:45:56 +0000 (UTC)
Received: by ewy3 with SMTP id 3so2414932ewy.1
        for <alpine-devel@lists.alpinelinux.org>; Mon, 09 Feb 2009 00:45:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:subject:from:to:cc
         :in-reply-to:references:content-type:date:message-id:mime-version
         :x-mailer:content-transfer-encoding;
        bh=o32YND9Tt5fxLh6RF+OP6HZAi6NC/yB428u5L/owKjQ=;
        b=Zp7YFP91T3a2bhVySyfaAX5tp2O3Qu0I6RwsGBJiclAzY8nDwgH79lMDs+wJbTl9R1
         teg8Z0maMnaTaPuthVSEzm+hOgdGNhAWXnHbbcYp2ce3yFLVvLTvygcOyfeF7QkjmUQu
         Vgy+SxaP/KrsMExy57J/nKUFz+rWiQ+A/i2aE=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=uxEoIOjjg2SLdc8G9Orp7qgUFLAG8kb0BOvM4MtYvnl4N4mHrNv1vz3O5yW/b5c0de
         iY5vMLfEQ64QDwFo6SdGpfYVJJ7xLe5LyfBZY7poGosEuNmoa4iOZE+V4hHeXY4+y3nV
         qZhtcLzoF0uEk5tC9T0yc3hIi6iwb4Td9qjtY=
Received: by 10.210.66.13 with SMTP id o13mr3653661eba.157.1234169155675;
        Mon, 09 Feb 2009 00:45:55 -0800 (PST)
Received: from ?10.65.65.1? (149-182-13.oke2-bras2.adsl.tele2.no [90.149.182.13])
        by mx.google.com with ESMTPS id 10sm3753462eyz.30.2009.02.09.00.45.54
        (version=SSLv3 cipher=RC4-MD5);
        Mon, 09 Feb 2009 00:45:55 -0800 (PST)
Subject: Re: [alpine-devel] new aport libmcrypt
From: Natanael Copa <natanael.copa@gmail.com>
To: Carlo Landmeter <clandmeter@gmail.com>
Cc: alpine <alpine-devel@lists.alpinelinux.org>
In-Reply-To: <20090208205714.BCE92187162@smtp01.prioritytelecom.nl>
References: <20090208205714.BCE92187162@smtp01.prioritytelecom.nl>
Content-Type: text/plain
Date: Mon, 09 Feb 2009 09:45:52 +0100
Message-Id: <1234169152.11678.31.camel@nc>
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
X-Mailer: Evolution 2.24.4 
Content-Transfer-Encoding: 7bit

On Sun, 2009-02-08 at 20:58 +0000, Carlo Landmeter wrote:
> see attached git patch.
> 
> carlo
> 
> 
> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (0001-extra-libmcrypt-new-aport.patch)
> 
> From 1ab136614b82b22bf78a47a8461f78da7a5e4607 Mon Sep 17 00:00:00 2001
> From: Carlo Landmeter <clandmeter@gmail.com>
> Date: Sun, 8 Feb 2009 20:50:44 +0000
> Subject: [PATCH] extra/libmcrypt: new aport
> 
> ---
>  extra/libmcrypt/APKBUILD |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
>  create mode 100644 extra/libmcrypt/APKBUILD
> 
> diff --git a/extra/libmcrypt/APKBUILD b/extra/libmcrypt/APKBUILD
> new file mode 100644
> index 0000000..905d880
> --- /dev/null
> +++ b/extra/libmcrypt/APKBUILD
> @@ -0,0 +1,24 @@
> +# Contributor: Carlo Landmeter <clandmeter at gmail>
> +# Maintainer: Carlo Landmeter <clandmeter at gmail>
> +pkgname=libmcrypt
> +pkgver=2.5.8
> +pkgrel=0
> +pkgdesc="A library which provides a uniform interface to several
> symmetric encryption algorithms"
> +url="http://mcrypt.sourceforge.net/"
> +license="GPL"
> +depends="uclibc"
> +makedepends="libtool uclibc++-dev"

This looks suspicious. you have uclibc++-dev in make depends but not in
depends. This means that either is uclibc++ missing in the depends or is
the mcrypt configure script testing for g++ even if it does not need it.

Looking closer to this, its the configure script that checks for g++.
There is a nocxx.patch in extra/libogg, but it does not seem to solve
the issue. It would probably help to remove the AC_PROG_CXX in
configure.in and re-run autoconf/automake (after first run aclocal).
This is something for upstream to fix really.

I think you can just add g++ to makedepends rather than uclibc++-dev.
(in order to actually use uclibc++, you'd need to: export CXX=g++-uc)

I dont think you need libtool in the makedepends either. (Seems to work
here without it)

> +install=
> +subpackages="$pkgname-doc $pkgname-dev"
> +source="http://downloads.sourceforge.net/mcrypt/${pkgname}-${pkgver}.tar.bz2"
> +
> +build() {
> +       cd "$srcdir/$pkgname-$pkgver"
> +
> +       ./configure --prefix=/usr \
> +               --mandir=/usr/share/man 
trailing whitespace in the row over     ^^^

> +       make || return 1
> +       make DESTDIR="$pkgdir" install
> +}
> +
> +md5sums="c4f491dd411a09e9de3b8702ea6f73eb  libmcrypt-2.5.8.tar.bz2"
> -- 
> 1.6.1

I'm committing it as is. If you want you can send a patch fixing the
mentioned issues. If you don't want, we just let it be and move on. :)

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---