X-Original-To: alpine-devel@lists.alpinelinux.org
Delivered-To: alpine-devel@lists.alpinelinux.org
Received: from mail-ew0-f170.google.com (mail-ew0-f170.google.com [209.85.219.170])
	by lists.alpinelinux.org (Postfix) with ESMTP id 82EA617003DC0
	for <alpine-devel@lists.alpinelinux.org>; Mon,  9 Mar 2009 15:29:47 +0000 (UTC)
Received: by ewy18 with SMTP id 18so952490ewy.25
        for <alpine-devel@lists.alpinelinux.org>; Mon, 09 Mar 2009 08:29:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:subject:from:to:cc
         :in-reply-to:references:content-type:date:message-id:mime-version
         :x-mailer:content-transfer-encoding;
        bh=cv5eD5665KVeVyowW9PAtCii/23oQuGO+CEFV4qMxBs=;
        b=YOvmx99sAzFOgqCZQ8MAHzhNEkoxxDBKS9OtBicEjT9mUvNHX+E42ev0cbK2USrY7x
         u1gqJbtk341EpdqZSi6JKg5AjsWeDLhOfbacECEiDkL8ETFv4TdKqwExLLh1CywU3OiE
         S4LO8SqIfadAwAsN9kbde9FQrEtVp+Iv9eXjU=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=sTdamPfCDeWQg6OWRI+rVexHknnPD842sAInGLS2XW4GyO105YpLUegh81YwIFtmx7
         zoWv93l3Z4d1kpsgrnoRg8I7GTJQWxiVYMKQqkJSA0r80Zu2ioSB4PbR0kihxqWgjilW
         cWeRkuyToi36UdAbYXd3/aOnTExYuqyx4MW1I=
Received: by 10.216.28.15 with SMTP id f15mr2168593wea.30.1236612587031;
        Mon, 09 Mar 2009 08:29:47 -0700 (PDT)
Received: from ?10.65.65.1? (ti211310a081-0173.bb.online.no [85.164.0.173])
        by mx.google.com with ESMTPS id f4sm2268316nfh.46.2009.03.09.08.29.45
        (version=SSLv3 cipher=RC4-MD5);
        Mon, 09 Mar 2009 08:29:46 -0700 (PDT)
Subject: Re: [alpine-devel] extra/dansguardian
From: Natanael Copa <natanael.copa@gmail.com>
To: Michael Mason <ms13sp@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
In-Reply-To: <E979FA57-7DE2-4FD4-864B-CBB4DA0C3F53@gmail.com>
References: <E979FA57-7DE2-4FD4-864B-CBB4DA0C3F53@gmail.com>
Content-Type: text/plain
Date: Mon, 09 Mar 2009 16:29:44 +0100
Message-Id: <1236612584.19020.23.camel@nc>
X-Mailinglist: alpine-devel
Precedence: list
List-Id: Alpine Development <alpine-devel.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-devel+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-devel@lists.alpinelinux.org>
List-Help: <mailto:alpine-devel+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-devel+subscribe@lists.alpinelinux.org?subject=subscribe>
Mime-Version: 1.0
X-Mailer: Evolution 2.24.4 
Content-Transfer-Encoding: 7bit

On Fri, 2009-03-06 at 17:48 +0000, Michael Mason wrote:
> Please review.
> Thx
> 
> Tried to follow the new guidelines for install scripts.
> 

Looks perfect!

The only thing is, no other package removes created users. I dont think
we should remove users when removeing packages. The app might have
created dirs or files (logfiles for example) that is owned by the
created user.

I fixed that and committed.
Thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---