DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=subject:from:to:cc:in-reply-to:references:content-type:date
         :message-id:mime-version:x-mailer:content-transfer-encoding;
        b=vwMld8QM7auCDK8q0FVfYzKgmG1s88yt0lUxuiz7adXZINgGBuZVfcSU91rDscCeIX
         eqPsQRIKwaSn9CZwwdefah32M2CbNNz0bhnXWI7LoQoDxwTj2KaYNdNQiYk0vFZQ83xf
         tACMKaKdpzhA5z1bT61wELvjduS9BXeRREb3o=
Subject: Re: [alpine-devel] mrxvt
From: Natanael Copa <natanael.copa@gmail.com>
To: Mark Constable <markc@renta.net>
Cc: alpine-devel@lists.alpinelinux.org
In-Reply-To: <4A743D6D.3080100@renta.net>
References: <4A743D6D.3080100@renta.net>
Content-Type: text/plain
Date: Thu, 06 Aug 2009 13:13:44 +0200
Message-Id: <1249557224.12941.132.camel@localhost.localdomain>
Precedence: list
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Sat, 2009-08-01 at 23:04 +1000, Mark Constable wrote:
> FWIW
> 
> % cat eth-os/mrxvt/APKBUILD
> # Contributor: Mark Constable <markc@renta.net>
> # Maintainer: Mark Constable <markc@renta.net>
> pkgname=mrxvt
> pkgver=0.5.4
> pkgrel=$(date -u +%Y%m%d%H)

unfortunally we cannot have this in "official" alpine releases for
reasons Timo explained.

> pkgdesc="A multi-tabbed X terminal emulator based on rxvt code"
> url="http://materm.sourceforge.net/wiki/pmwiki.php"
> license="GPL"
> depends="libpng libjpeg libxft libxpm"
Should be:
makedepends="libpng-dev jpeg-dev libxft-dev libxpm-dev"

and depends should be empty. Nowdays abuild will detect dynamic linking
libs automatically.

> subpackages="$pkgname-dev $pkgname-doc"
> source="
>   http://downloads.sourceforge.net/sourceforge/materm/$pkgname-$pkgver.tar.gz
>   mrxvt-0.5.4-002-fix-segfault-when-wd-empty.patch
>   mrxvt.desktop
> "
> 
> # append extra dependencies to -dev subpackage
> # remove if not used.
> # depends_dev="somepackage-dev"

Since this is an x11 package and oviously have a -dev subpackage, I'd
like to have a look if there is some usr/lib/pkgconfig/*.pc file. The
-dev package migh have some dependencies. If the -dev package have no
dependencies those lines should be removed.

> build()
> {
>   cd "$srcdir"/$pkgname-$pkgver
>   patch -p0 < ../../mrxvt-0.5.4-002-fix-segfault-when-wd-empty.patch || return 1

use either $srcdir or ../
the fetch() function will create a link from $SRCDEST

>   ./configure \
>     --prefix=/usr \
>     --sysconfdir=/etc \
>     --enable-xft \
>     --enable-text-shadow \
>     --enable-transparency \
>     --enable-smart-resize \
>     --enable-menubar \
>     --disable-ourstrings \
>     --enable-linespace \
>     --enable-256colors \
>     --enable-xim \
>     --enable-thai \
>     --enable-greek \
>     --enable-cjk \
>     --enable-backspace-key \
>     --with-save-lines=2048 || return 1
>   make || return 1
>   make DESTDIR=$pkgdir install || return 1
>   install -Dm644 ../mrxvt.desktop $pkgdir/usr/share/applications/mrxvt.desktop
> 
>   # install -m755 -D "$srcdir"/$pkgname.initd "$pkgdir"/etc/init.d/$pkgname
>   # install -m644 -D "$srcdir"/$pkgname.confd "$pkgdir"/etc/conf.d/$pkgname

those shoudl be removed.

> }
> md5sums="0232c8868484751dcb931a28f0756f69  mrxvt-0.5.4.tar.gz
> ca3651babc1599a6a8b1be2fee18920d  mrxvt-0.5.4-002-fix-segfault-when-wd-empty.patch
> 8351fe9189c197b5c61e27ad8d25c062  mrxvt.desktop"
> 

Other than that, looks very good, specially when thinking of that this
is your first APKBUILD and the amount of available documentation.

Will look at it after beta2.

Thanks!

-nc




---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---