Subject: Re: [alpine-devel] [PATCH] main/nginx New package
From: Natanael Copa <ncopa@alpinelinux.org>
To: Cameron Banta <cbanta@gmail.com>
Cc: alpine-devel@lists.alpinelinux.org
In-Reply-To: <1288624808-1532-1-git-send-email-cbanta@gmail.com>
References: <1288624808-1532-1-git-send-email-cbanta@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 01 Nov 2010 16:28:44 +0100
Message-ID: <1288625324.16847.8.camel@ncopa-desktop.nor.wtbts.net>
Precedence: list
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

Thanks for the apkbuild.

We are in the middle of the 2.1 release. Is the release worth delaying
for this package?

On Mon, 2010-11-01 at 15:20 +0000, Cameron Banta wrote:
> ---
>  main/nginx/APKBUILD    |   58 ++++++++++++++++++++++++++++++++++++++++++++
>  main/nginx/nginx.confd |    7 +++++
>  main/nginx/nginx.initd |   62 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 127 insertions(+), 0 deletions(-)
>  create mode 100644 main/nginx/APKBUILD
>  create mode 100644 main/nginx/nginx.confd
>  create mode 100644 main/nginx/nginx.initd
> 
> diff --git a/main/nginx/APKBUILD b/main/nginx/APKBUILD

We normally add new packages to testing/ first


> new file mode 100644
> index 0000000..b35beab
> --- /dev/null
> +++ b/main/nginx/APKBUILD
> @@ -0,0 +1,58 @@
> +# Contributor: Cameron Banta <cbanta@gmail.com>
> +# Maintainer: Cameron Banta <cbanta@gmail.com>
> +pkgname=nginx
> +pkgver=0.8.53
> +pkgrel=0
> +pkgdesc="nginx [engine x] is a HTTP and reverse proxy server"
> +url="nginx.org"
> +license="Custom"
> +depends=
> +makedepends="pcre-dev openssl-dev libcrypto1.0 zlib-dev"
> +#install="$pkgname.pre-install $pkgname.post-install"
> +install=
> +subpackages=
> +source="http://nginx.org/download/$pkgname-$pkgver.tar.gz
> +	nginx.initd
> +	nginx.confd
> +	$install
> +	"
> +
> +# append extra dependencies to -dev subpackage
> +# remove if not used.
> +# depends_dev="somepackage-dev"

The 3 comment lines above should be removed.

> +
> +_builddir="$srcdir"/$pkgname-$pkgver
> +

[cutted the part that looked good]

> --- /dev/null
> +++ b/main/nginx/nginx.initd
> @@ -0,0 +1,62 @@
> +#! /bin/sh

Should be #!/sbin/runscript

> +
> +### BEGIN INIT INFO
> +# Provides:          nginx
> +# Required-Start:    $all
> +# Required-Stop:     $all
> +# Default-Start:     2 3 4 5
> +# Default-Stop:      0 1 6
> +# Short-Description: starts the nginx web server
> +# Description:       starts nginx using start-stop-daemon
> +### END INIT INFO

No. We use openrc (like gentoo) which does not understand the above
service dependency info.

The init.d needs to be rewritten to fit the rest of the system.

Thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---